fix(home dashboard): fixed handling error when default dashboard is not found, fixes #5141

This commit is contained in:
Torkel Ödegaard 2016-05-24 07:39:58 +02:00
parent f1ec270e3e
commit c41c771e9a

View File

@ -8,6 +8,7 @@ import (
"github.com/grafana/grafana/pkg/api/dtos" "github.com/grafana/grafana/pkg/api/dtos"
"github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/bus"
"github.com/grafana/grafana/pkg/log"
"github.com/grafana/grafana/pkg/metrics" "github.com/grafana/grafana/pkg/metrics"
"github.com/grafana/grafana/pkg/middleware" "github.com/grafana/grafana/pkg/middleware"
m "github.com/grafana/grafana/pkg/models" m "github.com/grafana/grafana/pkg/models"
@ -167,14 +168,12 @@ func GetHomeDashboard(c *middleware.Context) {
if prefsQuery.Result.HomeDashboardId != 0 { if prefsQuery.Result.HomeDashboardId != 0 {
slugQuery := m.GetDashboardSlugByIdQuery{Id: prefsQuery.Result.HomeDashboardId} slugQuery := m.GetDashboardSlugByIdQuery{Id: prefsQuery.Result.HomeDashboardId}
err := bus.Dispatch(&slugQuery) err := bus.Dispatch(&slugQuery)
if err != nil { if err == nil {
c.JsonApiErr(500, "Failed to get slug from database", err) dashRedirect := dtos.DashboardRedirect{RedirectUri: "db/" + slugQuery.Result}
return c.JSON(200, &dashRedirect)
} else {
log.Warn("Failed to get slug from database, %s", err.Error())
} }
dashRedirect := dtos.DashboardRedirect{RedirectUri: "db/" + slugQuery.Result}
c.JSON(200, &dashRedirect)
return
} }
filePath := path.Join(setting.StaticRootPath, "dashboards/home.json") filePath := path.Join(setting.StaticRootPath, "dashboards/home.json")