Feature Registry: Update toggle configs for admin page visibility (#78062)

* Feature Registry: Update toggle configs for admin page visibility * update * fix rebase
2025-02-25 18:55:37 -06:00 · 2023-11-14 17:04:54 +00:00 · 2023-11-14 17:04:54 +00:00 · c506da53f3
commit c506da53f3
parent 8c5fcc60b1
1 changed files with 112 additions and 97 deletions
--- a/pkg/services/featuremgmt/registry.go
+++ b/pkg/services/featuremgmt/registry.go
@ -12,11 +12,12 @@ var (
 	// Register each toggle here
 	standardFeatureFlags = []FeatureFlag{
 		{
-			Name:           "disableEnvelopeEncryption",
-			Description:    "Disable envelope encryption (emergency only)",
-			Stage:          FeatureStageGeneralAvailability,
-			Owner:          grafanaAsCodeSquad,
-			AllowSelfServe: falsePtr,
+			Name:              "disableEnvelopeEncryption",
+			Description:       "Disable envelope encryption (emergency only)",
+			Stage:             FeatureStageGeneralAvailability,
+			Owner:             grafanaAsCodeSquad,
+			HideFromAdminPage: true,
+			AllowSelfServe:    falsePtr,
 		},
 		{
 			Name:         "live-service-web-worker",
@ -33,10 +34,11 @@ var (
 			Owner:        grafanaAppPlatformSquad,
 		},
 		{
-			Name:        "panelTitleSearch",
-			Description: "Search for dashboards using panel title",
-			Stage:       FeatureStagePublicPreview,
-			Owner:       grafanaAppPlatformSquad,
+			Name:              "panelTitleSearch",
+			Description:       "Search for dashboards using panel title",
+			Stage:             FeatureStagePublicPreview,
+			Owner:             grafanaAppPlatformSquad,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:           "publicDashboards",
@ -47,12 +49,13 @@ var (
 			AllowSelfServe: truePtr,
 		},
 		{
-			Name:            "publicDashboardsEmailSharing",
-			Description:     "Enables public dashboard sharing to be restricted to only allowed emails",
-			Stage:           FeatureStagePublicPreview,
-			RequiresLicense: true,
-			Owner:           grafanaSharingSquad,
-			HideFromDocs:    true,
+			Name:              "publicDashboardsEmailSharing",
+			Description:       "Enables public dashboard sharing to be restricted to only allowed emails",
+			Stage:             FeatureStagePublicPreview,
+			RequiresLicense:   true,
+			Owner:             grafanaSharingSquad,
+			HideFromDocs:      true,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:        "lokiExperimentalStreaming",
@ -65,7 +68,7 @@ var (
 			Description:    "Highlight Grafana Enterprise features",
 			Stage:          FeatureStageGeneralAvailability,
 			Owner:          grafanaAsCodeSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:        "migrationLocking",
@ -92,7 +95,7 @@ var (
 			Owner:          grafanaExploreSquad,
 			Expression:     "true", // enabled by default
 			FrontendOnly:   true,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:        "datasourceQueryMultiStatus",
@ -115,18 +118,20 @@ var (
 			Owner:        grafanaDatavizSquad,
 		},
 		{
-			Name:         "disableAngular",
-			Description:  "Dynamic flag to disable angular at runtime. The preferred method is to set `angular_support_enabled` to `false` in the [security] settings, which allows you to change the state at runtime.",
-			Stage:        FeatureStagePublicPreview,
-			FrontendOnly: true,
-			Owner:        grafanaDatavizSquad,
+			Name:              "disableAngular",
+			Description:       "Dynamic flag to disable angular at runtime. The preferred method is to set `angular_support_enabled` to `false` in the [security] settings, which allows you to change the state at runtime.",
+			Stage:             FeatureStagePublicPreview,
+			FrontendOnly:      true,
+			Owner:             grafanaDatavizSquad,
+			HideFromAdminPage: true,
 		},
 		{
-			Name:         "canvasPanelNesting",
-			Description:  "Allow elements nesting",
-			Stage:        FeatureStageExperimental,
-			FrontendOnly: true,
-			Owner:        grafanaDatavizSquad,
+			Name:              "canvasPanelNesting",
+			Description:       "Allow elements nesting",
+			Stage:             FeatureStageExperimental,
+			FrontendOnly:      true,
+			Owner:             grafanaDatavizSquad,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:           "newVizTooltips",
@ -134,7 +139,7 @@ var (
 			Stage:          FeatureStageGeneralAvailability,
 			FrontendOnly:   true,
 			Owner:          grafanaDatavizSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:         "scenes",
@ -162,7 +167,7 @@ var (
 			Stage:          FeatureStageGeneralAvailability,
 			Expression:     "true", // turned on by default
 			Owner:          grafanaPluginsPlatformSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			// Some plugins rely on topnav feature flag being enabled, so we cannot remove this until we
@ -181,10 +186,11 @@ var (
 			Owner:        grafanaFrontendPlatformSquad,
 		},
 		{
-			Name:        "grpcServer",
-			Description: "Run the GRPC server",
-			Stage:       FeatureStagePublicPreview,
-			Owner:       grafanaAppPlatformSquad,
+			Name:              "grpcServer",
+			Description:       "Run the GRPC server",
+			Stage:             FeatureStagePublicPreview,
+			Owner:             grafanaAppPlatformSquad,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:            "entityStore",
@ -199,7 +205,7 @@ var (
 			Stage:          FeatureStageGeneralAvailability,
 			Expression:     "true", // enabled by default
 			Owner:          awsDatasourcesSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:           "redshiftAsyncQueryDataSupport",
@ -237,10 +243,11 @@ var (
 			Owner:       grafanaBackendPlatformSquad,
 		},
 		{
-			Name:        "accessControlOnCall",
-			Description: "Access control primitives for OnCall",
-			Stage:       FeatureStagePublicPreview,
-			Owner:       identityAccessTeam,
+			Name:              "accessControlOnCall",
+			Description:       "Access control primitives for OnCall",
+			Stage:             FeatureStagePublicPreview,
+			Owner:             identityAccessTeam,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:        "nestedFolders",
@ -255,7 +262,7 @@ var (
 			Owner:          grafanaFrontendPlatformSquad,
 			FrontendOnly:   true,
 			Expression:     "true", // enabled by default
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:           "accessTokenExpirationCheck",
@ -265,20 +272,21 @@ var (
 			AllowSelfServe: falsePtr,
 		},
 		{
-			Name:           "emptyDashboardPage",
-			Description:    "Enable the redesigned user interface of a dashboard page that includes no panels",
-			Stage:          FeatureStageGeneralAvailability,
-			FrontendOnly:   true,
-			Expression:     "true", // enabled by default
-			Owner:          grafanaDashboardsSquad,
-			AllowSelfServe: falsePtr,
+			Name:              "emptyDashboardPage",
+			Description:       "Enable the redesigned user interface of a dashboard page that includes no panels",
+			Stage:             FeatureStageGeneralAvailability,
+			FrontendOnly:      true,
+			Expression:        "true", // enabled by default
+			Owner:             grafanaDashboardsSquad,
+			AllowSelfServe:    falsePtr,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:           "disablePrometheusExemplarSampling",
 			Description:    "Disable Prometheus exemplar sampling",
 			Stage:          FeatureStageGeneralAvailability,
 			Owner:          grafanaObservabilityMetricsSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:        "alertingBacktesting",
@ -294,11 +302,12 @@ var (
 			Owner:        grafanaBiSquad,
 		},
 		{
-			Name:            "alertingNoNormalState",
-			Description:     "Stop maintaining state of alerts that are not firing",
-			Stage:           FeatureStagePublicPreview,
-			RequiresRestart: false,
-			Owner:           grafanaAlertingSquad,
+			Name:              "alertingNoNormalState",
+			Description:       "Stop maintaining state of alerts that are not firing",
+			Stage:             FeatureStagePublicPreview,
+			RequiresRestart:   false,
+			Owner:             grafanaAlertingSquad,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:           "logsContextDatasourceUi",
@ -307,7 +316,7 @@ var (
 			FrontendOnly:   true,
 			Owner:          grafanaObservabilityLogsSquad,
 			Expression:     "true", // turned on by default
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:           "lokiQuerySplitting",
@ -316,7 +325,7 @@ var (
 			FrontendOnly:   true,
 			Owner:          grafanaObservabilityLogsSquad,
 			Expression:     "true", // turned on by default
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:         "lokiQuerySplittingConfig",
@ -338,7 +347,7 @@ var (
 			Stage:          FeatureStageGeneralAvailability,
 			FrontendOnly:   true,
 			Owner:          grafanaObservabilityMetricsSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:           "influxdbBackendMigration",
@ -361,7 +370,7 @@ var (
 			Expression:     "true",
 			Stage:          FeatureStageGeneralAvailability,
 			Owner:          grafanaObservabilityMetricsSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:           "lokiMetricDataplane",
@ -369,7 +378,7 @@ var (
 			Stage:          FeatureStageGeneralAvailability,
 			Expression:     "true",
 			Owner:          grafanaObservabilityLogsSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:        "lokiLogsDataplane",
@ -384,7 +393,7 @@ var (
 			FrontendOnly:   true,
 			Expression:     "true",
 			Owner:          grafanaObservabilityMetricsSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:        "disableSSEDataplane",
@ -417,10 +426,11 @@ var (
 			Owner:       grafanaBackendPlatformSquad,
 		},
 		{
-			Name:        "renderAuthJWT",
-			Description: "Uses JWT-based auth for rendering instead of relying on remote cache",
-			Stage:       FeatureStagePublicPreview,
-			Owner:       grafanaAsCodeSquad,
+			Name:              "renderAuthJWT",
+			Description:       "Uses JWT-based auth for rendering instead of relying on remote cache",
+			Stage:             FeatureStagePublicPreview,
+			Owner:             grafanaAsCodeSquad,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:            "externalServiceAuth",
@ -430,10 +440,11 @@ var (
 			Owner:           identityAccessTeam,
 		},
 		{
-			Name:        "refactorVariablesTimeRange",
-			Description: "Refactor time range variables flow to reduce number of API calls made when query variables are chained",
-			Stage:       FeatureStagePublicPreview,
-			Owner:       grafanaDashboardsSquad,
+			Name:              "refactorVariablesTimeRange",
+			Description:       "Refactor time range variables flow to reduce number of API calls made when query variables are chained",
+			Stage:             FeatureStagePublicPreview,
+			Owner:             grafanaDashboardsSquad,
+			HideFromAdminPage: true, // Non-feature, used to test out a bug fix that impacts the performance of template variables.
 		},
 		{
 			Name:            "useCachingService",
@ -450,16 +461,17 @@ var (
 			Stage:          FeatureStageGeneralAvailability,
 			Owner:          grafanaObservabilityLogsSquad,
 			Expression:     "true", // enabled by default
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
-			Name:           "advancedDataSourcePicker",
-			Description:    "Enable a new data source picker with contextual information, recently used order and advanced mode",
-			Stage:          FeatureStageGeneralAvailability,
-			FrontendOnly:   true,
-			Expression:     "true", // enabled by default
-			Owner:          grafanaDashboardsSquad,
-			AllowSelfServe: falsePtr,
+			Name:              "advancedDataSourcePicker",
+			Description:       "Enable a new data source picker with contextual information, recently used order and advanced mode",
+			Stage:             FeatureStageGeneralAvailability,
+			FrontendOnly:      true,
+			Expression:        "true", // enabled by default
+			Owner:             grafanaDashboardsSquad,
+			AllowSelfServe:    falsePtr,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:         "faroDatasourceSelector",
@ -511,11 +523,12 @@ var (
 			Owner:        grafanaPluginsPlatformSquad,
 		},
 		{
-			Name:         "sqlDatasourceDatabaseSelection",
-			Description:  "Enables previous SQL data source dataset dropdown behavior",
-			FrontendOnly: true,
-			Stage:        FeatureStagePublicPreview,
-			Owner:        grafanaBiSquad,
+			Name:              "sqlDatasourceDatabaseSelection",
+			Description:       "Enables previous SQL data source dataset dropdown behavior",
+			FrontendOnly:      true,
+			Stage:             FeatureStagePublicPreview,
+			Owner:             grafanaBiSquad,
+			HideFromAdminPage: true,
 		},
 		{
 			Name:         "lokiFormatQuery",
@ -531,7 +544,7 @@ var (
 			FrontendOnly:   true,
 			Expression:     "true", // enabled by default
 			Owner:          awsDatasourcesSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:         "exploreScrollableLogsContainer",
@ -589,7 +602,7 @@ var (
 			FrontendOnly:   true,
 			Expression:     "true", // enabled by default
 			Owner:          grafanaObservabilityMetricsSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:         "mlExpressions",
@ -641,12 +654,13 @@ var (
 			Owner:       awsDatasourcesSquad,
 		},
 		{
-			Name:            "splitScopes",
-			Description:     "Support faster dashboard and folder search by splitting permission scopes into parts",
-			Stage:           FeatureStagePublicPreview,
-			FrontendOnly:    false,
-			Owner:           identityAccessTeam,
-			RequiresRestart: true,
+			Name:              "splitScopes",
+			Description:       "Support faster dashboard and folder search by splitting permission scopes into parts",
+			Stage:             FeatureStagePublicPreview,
+			FrontendOnly:      false,
+			Owner:             identityAccessTeam,
+			RequiresRestart:   true,
+			HideFromAdminPage: true, // This is internal work to speed up dashboard search, and is not ready for wider use
 		},
 		{
 			Name:         "traceToProfiles",
@ -709,7 +723,7 @@ var (
 			FrontendOnly:   true,
 			Owner:          grafanaDashboardsSquad,
 			Expression:     "true", // on by default
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:            "reportingRetries",
@ -726,7 +740,7 @@ var (
 			Owner:          grafanaFrontendPlatformSquad,
 			FrontendOnly:   true,
 			Expression:     "true", // on by default
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:        "sseGroupByDatasource",
@ -764,13 +778,14 @@ var (
 			Owner:        hostedGrafanaTeam,
 		},
 		{
-			Name:           "alertingInsights",
-			Description:    "Show the new alerting insights landing page",
-			FrontendOnly:   true,
-			Stage:          FeatureStageGeneralAvailability,
-			Owner:          grafanaAlertingSquad,
-			Expression:     "true", // enabled by default
-			AllowSelfServe: falsePtr,
+			Name:              "alertingInsights",
+			Description:       "Show the new alerting insights landing page",
+			FrontendOnly:      true,
+			Stage:             FeatureStageGeneralAvailability,
+			Owner:             grafanaAlertingSquad,
+			Expression:        "true", // enabled by default
+			AllowSelfServe:    falsePtr,
+			HideFromAdminPage: true, // This is moving away from being a feature toggle.
 		},
 		{
 			Name:         "alertingContactPointsV2",
@ -813,7 +828,7 @@ var (
 			Stage:          FeatureStageGeneralAvailability,
 			Expression:     "true", // enabled by default
 			Owner:          awsDatasourcesSquad,
-			AllowSelfServe: falsePtr,
+			AllowSelfServe: truePtr,
 		},
 		{
 			Name:            "externalServiceAccounts",