IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-16 18:34:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't allow editing rule types for existing rules (#47512)

Browse Source
This commit is contained in:
Gilles De Mey 2022-04-08 15:26:33 +02:00 committed by GitHub
parent b31c7d3654
commit c530100d45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
public/app/features/alerting/unified/components/rule-editor/AlertTypeStep.tsx
View File

@ -38,27 +38,24 @@ export const AlertTypeStep: FC<Props> = ({ editingExistingRule }) => {
return (
<RuleEditorSection stepNo={1} title="Rule type">
<Field
disabled={editingExistingRule}
error={errors.type?.message}
invalid={!!errors.type?.message}
data-testid="alert-type-picker"
>
<InputControl
render={({ field: { onChange } }) => (
<RuleTypePicker
aria-label="Rule type"
selected={getValues('type') ?? RuleFormType.grafana}
onChange={onChange}
/>
)}
name="type"
control={control}
rules={{
required: { value: true, message: 'Please select alert type' },
}}
/>
</Field>
{!editingExistingRule && (
<Field error={errors.type?.message} invalid={!!errors.type?.message} data-testid="alert-type-picker">
<InputControl
render={({ field: { onChange } }) => (
<RuleTypePicker
aria-label="Rule type"
selected={getValues('type') ?? RuleFormType.grafana}
onChange={onChange}
/>
)}
name="type"
control={control}
rules={{
required: { value: true, message: 'Please select alert type' },
}}
/>
</Field>
)}
<Field
className={styles.formInput}