Dashboard: Remove super old prop that has not been used in years (#50826)

docs/sources/dashboards/json-model.md

@@ -37,7 +37,6 @@ When a user creates a new dashboard, a new dashboard JSON object is initialized
   "style": "dark",
   "timezone": "browser",
   "editable": true,
-  "hideControls": false,
   "graphTooltip": 1,
   "panels": [],
   "time": {

docs/sources/developers/http_api/dashboard.md

@@ -406,7 +406,6 @@ Content-Type: application/json
 {
   "dashboard": {
     "editable":false,
-    "hideControls":true,
     "nav":[
       {
         "enable":false,

docs/sources/developers/http_api/dashboard_versions.md

@@ -177,7 +177,6 @@ Content-Length: 1300
 
 - **version** - The dashboard version to restore to
 
-**Example response**:
 **Example response**:
 
 ```http
@@ -290,7 +289,6 @@ Content-Length: 1300
 JSON body schema:
 
 - **base** - an object representing the base dashboard version
-- **diffType** - the type of diff to return. Can be "json" or "basic".
 - **new** - an object representing the new dashboard version
 - **diffType** - the type of diff to return. Can be "json" or "basic".
 

docs/sources/developers/http_api/snapshot.md

@@ -29,7 +29,6 @@ title: 'HTTP Snapshot API '
     {
       "dashboard": {
         "editable":false,
-        "hideControls":true,
         "nav":[
         {
           "enable":false,
@@ -157,7 +156,6 @@ Content-Type: application/json
 This API call can be used without authentication by using the secret delete key for the snapshot.
 
 `GET /api/snapshots-delete/:deleteKey`
-
 
 **Example Request**:
 

pkg/services/alerting/testdata/dash-without-id.json

@@ -6,7 +6,6 @@
     "style": "dark",
     "timezone": "browser",
     "editable": true,
-    "hideControls": false,
     "sharedCrosshair": false,
     "rows": [
       {

pkg/services/alerting/testdata/influxdb-alert.json

@@ -7,7 +7,6 @@
     "style": "dark",
     "timezone": "browser",
     "editable": true,
-    "hideControls": false,
     "sharedCrosshair": false,
     "rows": [
       {

public/app/features/dashboard/components/SaveDashboard/forms/SaveDashboardAsForm.test.tsx

@@ -66,7 +66,6 @@ describe('SaveDashboardAsForm', () => {
       expect(savedDashboardModel.id).toBe(null);
       expect(savedDashboardModel.title).toBe('name');
       expect(savedDashboardModel.editable).toBe(true);
-      expect(savedDashboardModel.hideControls).toBe(false);
     });
 
     it("appends 'Copy' to the name when the dashboard isnt new", async () => {

public/app/features/dashboard/components/SaveDashboard/forms/SaveDashboardAsForm.tsx

@@ -19,7 +19,6 @@ const getSaveAsDashboardClone = (dashboard: DashboardModel) => {
   clone.uid = '';
   clone.title += ' Copy';
   clone.editable = true;
-  clone.hideControls = false;
 
   // remove alerts if source dashboard is already persisted
   // do not want to create alert dupes

public/app/features/dashboard/components/VersionHistory/__mocks__/dashboardHistoryMocks.ts

@@ -72,7 +72,6 @@ export function restore(version: any, restoredFrom?: any): any {
         editable: true,
         gnetId: null,
         graphTooltip: 0,
-        hideControls: false,
         id: 1,
         links: [],
         restoredFrom: restoredFrom,

public/dashboards/template_vars.json

@@ -1,14 +1,10 @@
 {
   "id": null,
   "title": "Templated Graphs Nested",
-  "tags": [
+  "tags": ["showcase", "templated"],
-    "showcase",
-    "templated"
-  ],
   "style": "dark",
   "timezone": "browser",
   "editable": true,
-  "hideControls": false,
   "rows": [
     {
       "title": "Row1",
@@ -27,10 +23,7 @@
           "x-axis": true,
           "y-axis": true,
           "scale": 1,
-          "y_formats": [
+          "y_formats": ["short", "short"],
-            "short",
-            "short"
-          ],
           "grid": {
             "max": null,
             "min": 0,
@@ -110,10 +103,7 @@
           "x-axis": true,
           "y-axis": true,
           "scale": 1,
-          "y_formats": [
+          "y_formats": ["short", "short"],
-            "short",
-            "short"
-          ],
           "grid": {
             "max": null,
             "min": 0,
@@ -180,29 +170,8 @@
       "notice": false,
       "enable": true,
       "status": "Stable",
-      "time_options": [
+      "time_options": ["5m", "15m", "1h", "6h", "12h", "24h", "2d", "7d", "30d"],
-        "5m",
+      "refresh_intervals": ["5s", "10s", "30s", "1m", "5m", "15m", "30m", "1h", "2h", "1d"],
-        "15m",
-        "1h",
-        "6h",
-        "12h",
-        "24h",
-        "2d",
-        "7d",
-        "30d"
-      ],
-      "refresh_intervals": [
-        "5s",
-        "10s",
-        "30s",
-        "1m",
-        "5m",
-        "15m",
-        "30m",
-        "1h",
-        "2h",
-        "1d"
-      ],
       "now": true
     }
   ],