IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Dashboards: Fix issue causing crashes when saving new dashboard (#77620)

Browse Source 
Closes #77593
This commit is contained in:
kay delaney 2023-11-03 16:33:59 +00:00 committed by GitHub
parent 549787d4f9
commit c98add6e5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.betterer.results
View File

@ -3000,9 +3000,10 @@ exports[`better eslint`] = {
[0, 0, 0, "Do not use any type assertions.", "2"],
[0, 0, 0, "Do not use any type assertions.", "3"],
[0, 0, 0, "Do not use any type assertions.", "4"],
[0, 0, 0, "Unexpected any. Specify a different type.", "5"],
[0, 0, 0, "Do not use any type assertions.", "6"],
[0, 0, 0, "Unexpected any. Specify a different type.", "7"]
[0, 0, 0, "Do not use any type assertions.", "5"],
[0, 0, 0, "Unexpected any. Specify a different type.", "6"],
[0, 0, 0, "Do not use any type assertions.", "7"],
[0, 0, 0, "Unexpected any. Specify a different type.", "8"]
],
"public/app/features/dashboard/components/DashboardRow/DashboardRow.test.tsx:5381": [
[0, 0, 0, "Unexpected any. Specify a different type.", "0"]

5
public/app/features/dashboard/components/DashboardPrompt/DashboardPrompt.tsx
View File

@ -146,6 +146,11 @@ export function ignoreChanges(current: DashboardModel | null, original: object |
return true;
}
// Ignore changes if original is unsaved
if ((original as DashboardModel).version === 0) {
return true;
}
// Ignore changes if the user has been signed out
if (!contextSrv.isSignedIn) {
return true;

1
public/app/features/dashboard/state/__fixtures__/dashboardFixtures.ts
View File

@ -22,6 +22,7 @@ export function createDashboardModelFixture(
editable: true,
graphTooltip: defaultDashboardCursorSync,
schemaVersion: 1,
version: 1,
timezone: '',
...dashboardInput,
};