From c9f7e3059f0c8f800656e420fa5dc46cb6a1f5a8 Mon Sep 17 00:00:00 2001 From: Sofia Papagiannaki Date: Thu, 1 Aug 2019 16:52:00 +0300 Subject: [PATCH] Fix failing end to end tests job for release (#18323) Create and push the expected tag to grafana-dev repository and use this instead for running the end to end tests for the release. --- .circleci/config.yml | 2 +- packaging/docker/build.sh | 2 ++ packaging/docker/push_to_docker_hub.sh | 6 ++++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3102816ce20..6f08f80c92d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -101,7 +101,7 @@ jobs: end-to-end-test-release: docker: - image: circleci/node:10-browsers - - image: grafana/grafana:$CIRCLE_TAG + - image: grafana/grafana-dev:$CIRCLE_TAG steps: - run: dockerize -wait tcp://127.0.0.1:3000 -timeout 120s - checkout diff --git a/packaging/docker/build.sh b/packaging/docker/build.sh index d1793904096..98f6914907d 100755 --- a/packaging/docker/build.sh +++ b/packaging/docker/build.sh @@ -67,6 +67,8 @@ fi # Tag as 'latest' for official release; otherwise tag as grafana/grafana:master if echo "$_grafana_tag" | grep -q "^v"; then docker_tag_all "${_docker_repo}" "latest" + # Create the expected tag for running the end to end tests successfully + docker tag "${_docker_repo}:${_grafana_version}" "grafana/grafana-dev:${_grafana_tag}" else docker_tag_all "${_docker_repo}" "master" docker tag "${_docker_repo}:${_grafana_version}" "grafana/grafana-dev:${_grafana_version}" diff --git a/packaging/docker/push_to_docker_hub.sh b/packaging/docker/push_to_docker_hub.sh index 37b5ae0095c..cdbc35ce8eb 100755 --- a/packaging/docker/push_to_docker_hub.sh +++ b/packaging/docker/push_to_docker_hub.sh @@ -38,8 +38,14 @@ if echo "$_grafana_tag" | grep -q "^v" && echo "$_grafana_tag" | grep -vq "beta" echo "pushing ${_docker_repo}:latest" docker_push_all "${_docker_repo}" "latest" docker_push_all "${_docker_repo}" "${_grafana_version}" + # Push to the grafana-dev repository with the expected tag + # for running the end to end tests successfully + docker push "grafana/grafana-dev:${_grafana_tag}" elif echo "$_grafana_tag" | grep -q "^v" && echo "$_grafana_tag" | grep -q "beta"; then docker_push_all "${_docker_repo}" "${_grafana_version}" + # Push to the grafana-dev repository with the expected tag + # for running the end to end tests successfully + docker push "grafana/grafana-dev:${_grafana_tag}" elif echo "$_grafana_tag" | grep -q "master"; then docker_push_all "${_docker_repo}" "master" docker push "grafana/grafana-dev:${_grafana_version}"