From ca66133636d2049f69527af61c9d04cda418e775 Mon Sep 17 00:00:00 2001 From: linoman <2051016+linoman@users.noreply.github.com> Date: Fri, 23 Aug 2024 16:35:00 +0200 Subject: [PATCH] SSO LDAP - Address pending PR review comments (#92368) * Address pending PR review comments * Update i18n --- public/app/features/admin/ldap/LdapDrawer.tsx | 33 +++++++++++-------- public/locales/en-US/grafana.json | 8 ++--- public/locales/pseudo-LOCALE/grafana.json | 8 ++--- 3 files changed, 26 insertions(+), 23 deletions(-) diff --git a/public/app/features/admin/ldap/LdapDrawer.tsx b/public/app/features/admin/ldap/LdapDrawer.tsx index f5cd65db6ff..eec47a0100d 100644 --- a/public/app/features/admin/ldap/LdapDrawer.tsx +++ b/public/app/features/admin/ldap/LdapDrawer.tsx @@ -1,4 +1,5 @@ import { css } from '@emotion/css'; +import { useId } from 'react'; import { useFormContext } from 'react-hook-form'; import { GrafanaTheme2, SelectableValue } from '@grafana/data'; @@ -31,6 +32,12 @@ export const LdapDrawerComponent = ({ onClose }: Props) => { const styles = useStyles2(getStyles); const { register, setValue, watch } = useFormContext(); + const nameId = useId(); + const surnameId = useId(); + const usernameId = useId(); + const memberOfId = useId(); + const emailId = useId(); + const groupMappingsLabel = (