Remove ioutil.ReadDir from usage (#53550)

* add depguard rule for ioutil

* replace ioutil.ReadDir with os.ReadDir

* use legacy option in depguard supported in golangci-lint v1.40

* replace ioutil.ReadDir with os.ReadDir

* return error for file info

pkg/cmd/grafana-cli/commands/commandstest/fake_ioutil.go

@@ -1,12 +1,13 @@
 package commandstest
 
 import (
+	"io/fs"
 	"os"
 	"time"
 )
 
 type FakeIoUtil struct {
-	FakeReadDir     []os.FileInfo
+	FakeReadDir     []fs.DirEntry
 	FakeIsDirectory bool
 }
 
@@ -18,7 +19,7 @@ func (util *FakeIoUtil) RemoveAll(path string) error {
 	return nil
 }
 
-func (util *FakeIoUtil) ReadDir(path string) ([]os.FileInfo, error) {
+func (util *FakeIoUtil) ReadDir(path string) ([]fs.DirEntry, error) {
 	return util.FakeReadDir, nil
 }
 

pkg/cmd/grafana-cli/models/model.go

@@ -1,6 +1,7 @@
 package models
 
 import (
+	"io/fs"
 	"os"
 )
 
@@ -49,6 +50,6 @@ type PluginRepo struct {
 type IoUtil interface {
 	Stat(path string) (os.FileInfo, error)
 	RemoveAll(path string) error
-	ReadDir(path string) ([]os.FileInfo, error)
+	ReadDir(path string) ([]fs.DirEntry, error)
 	ReadFile(filename string) ([]byte, error)
 }

pkg/cmd/grafana-cli/services/io_util.go

@@ -1,7 +1,7 @@
 package services
 
 import (
-	"io/ioutil"
+	"io/fs"
 	"os"
 )
 
@@ -16,8 +16,8 @@ func (i IoUtilImp) RemoveAll(path string) error {
 	return os.RemoveAll(path)
 }
 
-func (i IoUtilImp) ReadDir(path string) ([]os.FileInfo, error) {
-	return ioutil.ReadDir(path)
+func (i IoUtilImp) ReadDir(path string) ([]fs.DirEntry, error) {
+	return os.ReadDir(path)
 }
 
 func (i IoUtilImp) ReadFile(filename string) ([]byte, error) {