Feature Toggles: Remove DocsURL from FeatureFlag struct (#79774)

Co-authored-by: Ryan McKinley <ryantxu@gmail.com>

pkg/services/featuremgmt/manager.go

@@ -43,9 +43,6 @@ func (fm *FeatureManager) registerFlags(flags ...FeatureFlag) {
 		if add.Description != "" {
 			flag.Description = add.Description
 		}
-		if add.DocsURL != "" {
-			flag.DocsURL = add.DocsURL
-		}
 		if add.Expression != "" {
 			flag.Expression = add.Expression
 		}

pkg/services/featuremgmt/manager_test.go

@@ -24,7 +24,7 @@ func TestFeatureManager(t *testing.T) {
 		require.Equal(t, map[string]bool{"a": true}, ft.GetEnabled(context.Background()))
 	})
 
-	t.Run("check description and docs configs", func(t *testing.T) {
+	t.Run("check description and stage configs", func(t *testing.T) {
 		ft := FeatureManager{
 			flags: map[string]*FeatureFlag{},
 		}
@@ -35,14 +35,14 @@ func TestFeatureManager(t *testing.T) {
 			Name:        "a",
 			Description: "second",
 		}, FeatureFlag{
-			Name:    "a",
+			Name:  "a",
-			DocsURL: "http://something",
+			Stage: FeatureStagePrivatePreview,
 		}, FeatureFlag{
 			Name: "a",
 		})
 		flag := ft.flags["a"]
 		require.Equal(t, "second", flag.Description)
-		require.Equal(t, "http://something", flag.DocsURL)
+		require.Equal(t, FeatureStagePrivatePreview, flag.Stage)
 	})
 
 	t.Run("check startup false flags", func(t *testing.T) {

pkg/services/featuremgmt/models.go

@@ -130,9 +130,8 @@ type FeatureFlag struct {
 	FrontendOnly    bool `json:"frontend,omitempty"`        // change is only seen in the frontend
 	HideFromDocs    bool `json:"hideFromDocs,omitempty"`    // don't add the values to docs
 
-	// These are currently unused
+	// The server must be initialized with the value
-	DocsURL         string `json:"docsURL,omitempty"`
+	RequiresRestart bool `json:"requiresRestart,omitempty"`
-	RequiresRestart bool   `json:"requiresRestart,omitempty"` // The server must be initialized with the value
 }
 
 type UpdateFeatureTogglesCommand struct {