diff --git a/public/app/core/actions/user.ts b/public/app/core/actions/user.ts deleted file mode 100644 index dba0588c058..00000000000 --- a/public/app/core/actions/user.ts +++ /dev/null @@ -1,28 +0,0 @@ -import { ThunkAction } from 'redux-thunk'; -import { getBackendSrv } from '../services/backend_srv'; -import { DashboardAcl, DashboardSearchHit, StoreState } from '../../types'; - -type ThunkResult = ThunkAction; - -export type Action = LoadStarredDashboardsAction; - -export enum ActionTypes { - LoadStarredDashboards = 'LOAD_STARRED_DASHBOARDS', -} - -interface LoadStarredDashboardsAction { - type: ActionTypes.LoadStarredDashboards; - payload: DashboardSearchHit[]; -} - -const starredDashboardsLoaded = (dashboards: DashboardAcl[]) => ({ - type: ActionTypes.LoadStarredDashboards, - payload: dashboards, -}); - -export function loadStarredDashboards(): ThunkResult { - return async dispatch => { - const starredDashboards = await getBackendSrv().search({ starred: true }); - dispatch(starredDashboardsLoaded(starredDashboards)); - }; -} diff --git a/public/app/core/components/Picker/SimplePicker.tsx b/public/app/core/components/Picker/SimplePicker.tsx index 6c9e8aca199..817cd14150f 100644 --- a/public/app/core/components/Picker/SimplePicker.tsx +++ b/public/app/core/components/Picker/SimplePicker.tsx @@ -5,13 +5,14 @@ import ResetStyles from './ResetStyles'; interface Props { className?: string; - defaultValue: any; + defaultValue?: any; getOptionLabel: (item: any) => string; getOptionValue: (item: any) => string; onSelected: (item: any) => {} | void; options: any[]; placeholder?: string; width: number; + value: any; } const SimplePicker: SFC = ({ @@ -23,6 +24,7 @@ const SimplePicker: SFC = ({ options, placeholder, width, + value, }) => { return ( - - - -
- - Home Dashboard - - Not finding dashboard you want? Star it first, then it should appear in this select box. - - - - -
- -
- -
- -
-
- -
- -
- -`; - -export function prefsControlDirective() { - return { - restrict: 'E', - controller: PrefsControlCtrl, - bindToController: true, - controllerAs: 'ctrl', - template: template, - scope: { - mode: '@', - }, - }; -} - -coreModule.directive('prefsControl', prefsControlDirective); +react2AngularDirective('prefsControl', SharedPreferences, ['resourceUri']); diff --git a/public/app/features/profile/partials/profile.html b/public/app/features/profile/partials/profile.html index 7858e00c683..543b0e2e39a 100644 --- a/public/app/features/profile/partials/profile.html +++ b/public/app/features/profile/partials/profile.html @@ -24,7 +24,7 @@ - +

Teams

diff --git a/public/app/features/teams/TeamPages.test.tsx b/public/app/features/teams/TeamPages.test.tsx index 0070f8dee6c..5d751f46989 100644 --- a/public/app/features/teams/TeamPages.test.tsx +++ b/public/app/features/teams/TeamPages.test.tsx @@ -1,7 +1,7 @@ import React from 'react'; import { shallow } from 'enzyme'; import { TeamPages, Props } from './TeamPages'; -import { NavModel, Team, OrganizationPreferences } from '../../types'; +import { NavModel, Team } from '../../types'; import { getMockTeam } from './__mocks__/teamMocks'; jest.mock('app/core/config', () => ({ @@ -15,9 +15,6 @@ const setup = (propOverrides?: object) => { loadTeam: jest.fn(), pageName: 'members', team: {} as Team, - loadStarredDashboards: jest.fn(), - loadTeamPreferences: jest.fn(), - preferences: {} as OrganizationPreferences, }; Object.assign(props, propOverrides); diff --git a/public/app/features/teams/TeamPages.tsx b/public/app/features/teams/TeamPages.tsx index 0e39eab7260..38ba23262ba 100644 --- a/public/app/features/teams/TeamPages.tsx +++ b/public/app/features/teams/TeamPages.tsx @@ -7,14 +7,12 @@ import PageHeader from 'app/core/components/PageHeader/PageHeader'; import TeamMembers from './TeamMembers'; import TeamSettings from './TeamSettings'; import TeamGroupSync from './TeamGroupSync'; -import TeamPreferences from './TeamPreferences'; -import { NavModel, Team, OrganizationPreferences } from 'app/types'; -import { loadTeam, loadTeamPreferences } from './state/actions'; +import { NavModel, Team } from 'app/types'; +import { loadTeam } from './state/actions'; import { getTeam } from './state/selectors'; import { getTeamLoadingNav } from './state/navModel'; import { getNavModel } from 'app/core/selectors/navModel'; import { getRouteParamsId, getRouteParamsPage } from '../../core/selectors/location'; -import { loadStarredDashboards } from '../../core/actions/user'; export interface Props { team: Team; @@ -22,9 +20,6 @@ export interface Props { teamId: number; pageName: string; navModel: NavModel; - preferences: OrganizationPreferences; - loadStarredDashboards: typeof loadStarredDashboards; - loadTeamPreferences: typeof loadTeamPreferences; } interface State { @@ -47,9 +42,7 @@ export class TeamPages extends PureComponent { } async componentDidMount() { - await this.props.loadStarredDashboards(); await this.fetchTeam(); - await this.props.loadTeamPreferences(); } async fetchTeam() { @@ -73,13 +66,7 @@ export class TeamPages extends PureComponent { return ; case PageTypes.Settings: - return ( -
- - -
- ); - + return ; case PageTypes.GroupSync: return isSyncEnabled && ; } @@ -109,14 +96,11 @@ function mapStateToProps(state) { teamId: teamId, pageName: pageName, team: getTeam(state.team, teamId), - preferences: state.preferences, }; } const mapDispatchToProps = { loadTeam, - loadStarredDashboards, - loadTeamPreferences, }; export default hot(module)(connect(mapStateToProps, mapDispatchToProps)(TeamPages)); diff --git a/public/app/features/teams/TeamPreferences.test.tsx b/public/app/features/teams/TeamPreferences.test.tsx deleted file mode 100644 index 2da8b2b1cfb..00000000000 --- a/public/app/features/teams/TeamPreferences.test.tsx +++ /dev/null @@ -1,28 +0,0 @@ -import React from 'react'; -import { shallow } from 'enzyme'; -import { TeamPreferences, Props } from './TeamPreferences'; - -const setup = () => { - const props: Props = { - preferences: { - homeDashboardId: 1, - timezone: 'UTC', - theme: 'Default', - }, - starredDashboards: [{ id: 1, title: 'Standard dashboard', url: '', uri: '', uid: '', type: '', tags: [] }], - setTeamTimezone: jest.fn(), - setTeamTheme: jest.fn(), - setTeamHomeDashboard: jest.fn(), - updateTeamPreferences: jest.fn(), - }; - - return shallow(); -}; - -describe('Render', () => { - it('should render component', () => { - const wrapper = setup(); - - expect(wrapper).toMatchSnapshot(); - }); -}); diff --git a/public/app/features/teams/TeamPreferences.tsx b/public/app/features/teams/TeamPreferences.tsx deleted file mode 100644 index a6b8547c4db..00000000000 --- a/public/app/features/teams/TeamPreferences.tsx +++ /dev/null @@ -1,105 +0,0 @@ -import React, { PureComponent } from 'react'; -import { connect } from 'react-redux'; -import { Label } from '../../core/components/Label/Label'; -import SimplePicker from '../../core/components/Picker/SimplePicker'; -import { DashboardSearchHit, OrganizationPreferences } from 'app/types'; -import { setTeamHomeDashboard, setTeamTheme, setTeamTimezone, updateTeamPreferences } from './state/actions'; - -export interface Props { - preferences: OrganizationPreferences; - starredDashboards: DashboardSearchHit[]; - setTeamHomeDashboard: typeof setTeamHomeDashboard; - setTeamTheme: typeof setTeamTheme; - setTeamTimezone: typeof setTeamTimezone; - updateTeamPreferences: typeof updateTeamPreferences; -} - -const themes = [{ value: '', text: 'Default' }, { value: 'dark', text: 'Dark' }, { value: 'light', text: 'Light' }]; - -const timezones = [ - { value: '', text: 'Default' }, - { value: 'browser', text: 'Local browser time' }, - { value: 'utc', text: 'UTC' }, -]; - -export class TeamPreferences extends PureComponent { - onSubmitForm = event => { - event.preventDefault(); - this.props.updateTeamPreferences(); - }; - - render() { - const { preferences, starredDashboards, setTeamHomeDashboard, setTeamTimezone, setTeamTheme } = this.props; - - const dashboards: DashboardSearchHit[] = [ - { id: 0, title: 'Default', tags: [], type: '', uid: '', uri: '', url: '' }, - ...starredDashboards, - ]; - - return ( -
-

Preferences

-
- UI Theme - theme.value === preferences.theme)} - options={themes} - getOptionValue={i => i.value} - getOptionLabel={i => i.text} - onSelected={theme => setTeamTheme(theme.value)} - width={20} - /> -
-
- - dashboard.id === preferences.homeDashboardId)} - getOptionValue={i => i.id} - getOptionLabel={i => i.title} - onSelected={(dashboard: DashboardSearchHit) => setTeamHomeDashboard(dashboard.id)} - options={dashboards} - placeholder="Chose default dashboard" - width={20} - /> -
-
- - timezone.value === preferences.timezone)} - getOptionValue={i => i.value} - getOptionLabel={i => i.text} - onSelected={timezone => setTeamTimezone(timezone.value)} - options={timezones} - width={20} - /> -
-
- -
-
- ); - } -} - -function mapStateToProps(state) { - return { - preferences: state.team.preferences, - starredDashboards: state.user.starredDashboards, - }; -} - -const mapDispatchToProps = { - setTeamHomeDashboard, - setTeamTimezone, - setTeamTheme, - updateTeamPreferences, -}; - -export default connect(mapStateToProps, mapDispatchToProps)(TeamPreferences); diff --git a/public/app/features/teams/TeamSettings.tsx b/public/app/features/teams/TeamSettings.tsx index 45977de95bf..35c306d664e 100644 --- a/public/app/features/teams/TeamSettings.tsx +++ b/public/app/features/teams/TeamSettings.tsx @@ -1,10 +1,12 @@ import React from 'react'; import { connect } from 'react-redux'; + import { Label } from 'app/core/components/Label/Label'; -import { Team } from '../../types'; +import { SharedPreferences } from 'app/core/components/SharedPreferences/SharedPreferences'; import { updateTeam } from './state/actions'; -import { getRouteParamsId } from '../../core/selectors/location'; +import { getRouteParamsId } from 'app/core/selectors/location'; import { getTeam } from './state/selectors'; +import { Team } from 'app/types'; export interface Props { team: Team; @@ -41,6 +43,7 @@ export class TeamSettings extends React.Component { }; render() { + const { team } = this.props; const { name, email } = this.state; return ( @@ -76,6 +79,7 @@ export class TeamSettings extends React.Component {
+ ); } diff --git a/public/app/features/teams/__mocks__/teamMocks.ts b/public/app/features/teams/__mocks__/teamMocks.ts index c3ab2cdfbea..339f227c081 100644 --- a/public/app/features/teams/__mocks__/teamMocks.ts +++ b/public/app/features/teams/__mocks__/teamMocks.ts @@ -1,4 +1,4 @@ -import { Team, TeamGroup, TeamMember, OrganizationPreferences } from 'app/types'; +import { Team, TeamGroup, TeamMember } from 'app/types'; export const getMultipleMockTeams = (numberOfTeams: number): Team[] => { const teams: Team[] = []; @@ -65,11 +65,3 @@ export const getMockTeamGroups = (amount: number): TeamGroup[] => { return groups; }; - -export const getMockTeamPreferences = (): OrganizationPreferences => { - return { - theme: 'dark', - timezone: 'browser', - homeDashboardId: 1, - }; -}; diff --git a/public/app/features/teams/state/actions.ts b/public/app/features/teams/state/actions.ts index d8bdfb88f47..d948dc1c5a3 100644 --- a/public/app/features/teams/state/actions.ts +++ b/public/app/features/teams/state/actions.ts @@ -1,20 +1,16 @@ import { ThunkAction } from 'redux-thunk'; import { getBackendSrv } from 'app/core/services/backend_srv'; -import { StoreState, Team, TeamGroup, TeamMember, OrganizationPreferences } from 'app/types'; +import { StoreState, Team, TeamGroup, TeamMember } from 'app/types'; import { updateNavIndex, UpdateNavIndexAction } from 'app/core/actions'; import { buildNavModel } from './navModel'; export enum ActionTypes { LoadTeams = 'LOAD_TEAMS', LoadTeam = 'LOAD_TEAM', - LoadTeamPreferences = 'LOAD_TEAM_PREFERENCES', SetSearchQuery = 'SET_TEAM_SEARCH_QUERY', SetSearchMemberQuery = 'SET_TEAM_MEMBER_SEARCH_QUERY', LoadTeamMembers = 'TEAM_MEMBERS_LOADED', LoadTeamGroups = 'TEAM_GROUPS_LOADED', - SetTeamTheme = 'SET_TEAM_THEME', - SetTeamHomeDashboard = 'SET_TEAM_HOME_DASHBOARD', - SetTeamTimezone = 'SET_TEAM_TIMEZONE', } export interface LoadTeamsAction { @@ -27,11 +23,6 @@ export interface LoadTeamAction { payload: Team; } -export interface LoadTeamPreferencesAction { - type: ActionTypes.LoadTeamPreferences; - payload: OrganizationPreferences; -} - export interface LoadTeamMembersAction { type: ActionTypes.LoadTeamMembers; payload: TeamMember[]; @@ -52,32 +43,13 @@ export interface SetSearchMemberQueryAction { payload: string; } -export interface SetTeamThemeAction { - type: ActionTypes.SetTeamTheme; - payload: string; -} - -export interface SetTeamHomeDashboardAction { - type: ActionTypes.SetTeamHomeDashboard; - payload: number; -} - -export interface SetTeamTimezoneAction { - type: ActionTypes.SetTeamTimezone; - payload: string; -} - export type Action = | LoadTeamsAction | SetSearchQueryAction | LoadTeamAction - | LoadTeamPreferencesAction | LoadTeamMembersAction | SetSearchMemberQueryAction - | LoadTeamGroupsAction - | SetTeamThemeAction - | SetTeamHomeDashboardAction - | SetTeamTimezoneAction; + | LoadTeamGroupsAction; type ThunkResult = ThunkAction; @@ -101,11 +73,6 @@ const teamGroupsLoaded = (teamGroups: TeamGroup[]): LoadTeamGroupsAction => ({ payload: teamGroups, }); -const teamPreferencesLoaded = (preferences: OrganizationPreferences): LoadTeamPreferencesAction => ({ - type: ActionTypes.LoadTeamPreferences, - payload: preferences, -}); - export const setSearchMemberQuery = (searchQuery: string): SetSearchMemberQueryAction => ({ type: ActionTypes.SetSearchMemberQuery, payload: searchQuery, @@ -116,21 +83,6 @@ export const setSearchQuery = (searchQuery: string): SetSearchQueryAction => ({ payload: searchQuery, }); -export const setTeamTheme = (theme: string) => ({ - type: ActionTypes.SetTeamTheme, - payload: theme, -}); - -export const setTeamHomeDashboard = (id: number) => ({ - type: ActionTypes.SetTeamHomeDashboard, - payload: id, -}); - -export const setTeamTimezone = (timezone: string) => ({ - type: ActionTypes.SetTeamTimezone, - payload: timezone, -}); - export function loadTeams(): ThunkResult { return async dispatch => { const response = await getBackendSrv().get('/api/teams/search', { perpage: 1000, page: 1 }); @@ -208,22 +160,3 @@ export function deleteTeam(id: number): ThunkResult { dispatch(loadTeams()); }; } - -export function loadTeamPreferences(): ThunkResult { - return async (dispatch, getStore) => { - const team = getStore().team.team; - const response = await getBackendSrv().get(`/api/teams/${team.id}/preferences`); - dispatch(teamPreferencesLoaded(response)); - }; -} - -export function updateTeamPreferences() { - return async (dispatch, getStore) => { - const team = getStore().team.team; - const preferences = getStore().team.preferences; - - await getBackendSrv().put(`/api/teams/${team.id}/preferences`, preferences); - - dispatch(loadTeamPreferences()); - }; -} diff --git a/public/app/features/teams/state/reducers.test.ts b/public/app/features/teams/state/reducers.test.ts index 892895d4184..7f7a33d60ac 100644 --- a/public/app/features/teams/state/reducers.test.ts +++ b/public/app/features/teams/state/reducers.test.ts @@ -1,6 +1,6 @@ import { Action, ActionTypes } from './actions'; import { initialTeamsState, initialTeamState, teamReducer, teamsReducer } from './reducers'; -import { getMockTeam, getMockTeamMember, getMockTeamPreferences } from '../__mocks__/teamMocks'; +import { getMockTeam, getMockTeamMember } from '../__mocks__/teamMocks'; describe('teams reducer', () => { it('should set teams', () => { @@ -69,17 +69,4 @@ describe('team reducer', () => { expect(result.searchMemberQuery).toEqual('member'); }); - - it('should set team preferences', () => { - const mockTeamPrefs = getMockTeamPreferences(); - - const action: Action = { - type: ActionTypes.LoadTeamPreferences, - payload: mockTeamPrefs, - }; - - const result = teamReducer(initialTeamState, action); - - expect(result.preferences).toEqual(mockTeamPrefs); - }); }); diff --git a/public/app/features/teams/state/reducers.ts b/public/app/features/teams/state/reducers.ts index 0ef358e19d7..2e72dce0afb 100644 --- a/public/app/features/teams/state/reducers.ts +++ b/public/app/features/teams/state/reducers.ts @@ -1,4 +1,4 @@ -import { Team, TeamGroup, TeamMember, TeamsState, TeamState, OrganizationPreferences } from 'app/types'; +import { Team, TeamGroup, TeamMember, TeamsState, TeamState } from 'app/types'; import { Action, ActionTypes } from './actions'; export const initialTeamsState: TeamsState = { teams: [], searchQuery: '', hasFetched: false }; @@ -7,7 +7,6 @@ export const initialTeamState: TeamState = { members: [] as TeamMember[], groups: [] as TeamGroup[], searchMemberQuery: '', - preferences: {} as OrganizationPreferences, }; export const teamsReducer = (state = initialTeamsState, action: Action): TeamsState => { @@ -34,18 +33,6 @@ export const teamReducer = (state = initialTeamState, action: Action): TeamState case ActionTypes.LoadTeamGroups: return { ...state, groups: action.payload }; - - case ActionTypes.LoadTeamPreferences: - return { ...state, preferences: action.payload }; - - case ActionTypes.SetTeamTheme: - return { ...state, preferences: { ...state.preferences, theme: action.payload } }; - - case ActionTypes.SetTeamHomeDashboard: - return { ...state, preferences: { ...state.preferences, homeDashboardId: action.payload } }; - - case ActionTypes.SetTeamTimezone: - return { ...state, preferences: { ...state.preferences, timezone: action.payload } }; } return state; diff --git a/public/app/features/teams/state/selectors.test.ts b/public/app/features/teams/state/selectors.test.ts index 3aab99da1c2..e88fbdfd4b1 100644 --- a/public/app/features/teams/state/selectors.test.ts +++ b/public/app/features/teams/state/selectors.test.ts @@ -1,6 +1,6 @@ import { getTeam, getTeamMembers, getTeams } from './selectors'; import { getMockTeam, getMockTeamMembers, getMultipleMockTeams } from '../__mocks__/teamMocks'; -import { Team, TeamGroup, TeamsState, TeamState, OrganizationPreferences } from '../../../types'; +import { Team, TeamGroup, TeamsState, TeamState } from '../../../types'; describe('Teams selectors', () => { describe('Get teams', () => { @@ -10,7 +10,6 @@ describe('Teams selectors', () => { const mockState: TeamsState = { teams: mockTeams, searchQuery: '', hasFetched: false }; const teams = getTeams(mockState); - expect(teams).toEqual(mockTeams); }); @@ -18,7 +17,6 @@ describe('Teams selectors', () => { const mockState: TeamsState = { teams: mockTeams, searchQuery: '5', hasFetched: false }; const teams = getTeams(mockState); - expect(teams.length).toEqual(1); }); }); @@ -34,11 +32,9 @@ describe('Team selectors', () => { searchMemberQuery: '', members: [], groups: [], - preferences: {} as OrganizationPreferences, }; const team = getTeam(mockState, '1'); - expect(team).toEqual(mockTeam); }); }); @@ -52,11 +48,9 @@ describe('Team selectors', () => { searchMemberQuery: '', members: mockTeamMembers, groups: [] as TeamGroup[], - preferences: {} as OrganizationPreferences, }; const members = getTeamMembers(mockState); - expect(members).toEqual(mockTeamMembers); }); }); diff --git a/public/app/types/index.ts b/public/app/types/index.ts index fc176fed7e2..3bf6b4c9803 100644 --- a/public/app/types/index.ts +++ b/public/app/types/index.ts @@ -22,7 +22,7 @@ import { } from './series'; import { PanelProps, PanelOptionsProps } from './panel'; import { PluginDashboard, PluginMeta, Plugin, PluginsState } from './plugins'; -import { Organization, OrganizationPreferences, OrganizationState } from './organization'; +import { Organization, OrganizationState } from './organization'; import { AppNotification, AppNotificationSeverity, @@ -81,7 +81,6 @@ export { PluginDashboard, Organization, OrganizationState, - OrganizationPreferences, AppNotification, AppNotificationsState, AppNotificationSeverity, diff --git a/public/app/types/organization.ts b/public/app/types/organization.ts index 52cb130e082..da67ead34ae 100644 --- a/public/app/types/organization.ts +++ b/public/app/types/organization.ts @@ -3,13 +3,6 @@ export interface Organization { id: number; } -export interface OrganizationPreferences { - homeDashboardId: number; - theme: string; - timezone: string; -} - export interface OrganizationState { organization: Organization; - preferences: OrganizationPreferences; } diff --git a/public/app/types/teams.ts b/public/app/types/teams.ts index b0480f875d6..a524f0dcf87 100644 --- a/public/app/types/teams.ts +++ b/public/app/types/teams.ts @@ -1,5 +1,3 @@ -import { OrganizationPreferences } from './organization'; - export interface Team { id: number; name: string; @@ -33,5 +31,4 @@ export interface TeamState { members: TeamMember[]; groups: TeamGroup[]; searchMemberQuery: string; - preferences: OrganizationPreferences; }