From d0afa60febb211cc06ba52aab87935db3392aed8 Mon Sep 17 00:00:00 2001
From: Leonor Oliveira <9090754+leonorfmartins@users.noreply.github.com>
Date: Thu, 11 Jul 2024 14:31:37 +0100
Subject: [PATCH] Remove unused metric (#90327)

---
 pkg/apiserver/rest/dualwriter_mode2.go |  2 --
 pkg/apiserver/rest/metrics.go          | 17 +++--------------
 2 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/pkg/apiserver/rest/dualwriter_mode2.go b/pkg/apiserver/rest/dualwriter_mode2.go
index df725b1c58e..91a5ed68223 100644
--- a/pkg/apiserver/rest/dualwriter_mode2.go
+++ b/pkg/apiserver/rest/dualwriter_mode2.go
@@ -106,7 +106,6 @@ func (d *DualWriterMode2) Get(ctx context.Context, name string, options *metav1.
 
 	// if there is no object in storage, we return the object from legacy
 	if objStorage == nil {
-		d.recordReadLegacyCount(options.Kind, method)
 		return objLegacy, nil
 	}
 	return objStorage, err
@@ -185,7 +184,6 @@ func (d *DualWriterMode2) List(ctx context.Context, options *metainternalversion
 		return sl, nil
 	}
 	log.Info("lists from legacy and storage are not the same size")
-	d.recordReadLegacyCount(options.Kind, method)
 	return ll, nil
 }
 
diff --git a/pkg/apiserver/rest/metrics.go b/pkg/apiserver/rest/metrics.go
index 0b85e7268b6..674e54d0635 100644
--- a/pkg/apiserver/rest/metrics.go
+++ b/pkg/apiserver/rest/metrics.go
@@ -9,10 +9,9 @@ import (
 )
 
 type dualWriterMetrics struct {
-	legacy      *prometheus.HistogramVec
-	storage     *prometheus.HistogramVec
-	outcome     *prometheus.HistogramVec
-	legacyReads *prometheus.CounterVec
+	legacy  *prometheus.HistogramVec
+	storage *prometheus.HistogramVec
+	outcome *prometheus.HistogramVec
 }
 
 // DualWriterStorageDuration is a metric summary for dual writer storage duration per mode
@@ -39,12 +38,6 @@ var DualWriterOutcome = prometheus.NewHistogramVec(prometheus.HistogramOpts{
 	NativeHistogramBucketFactor: 1.1,
 }, []string{"mode", "name", "method"})
 
-var DualWriterReadLegacyCounts = prometheus.NewCounterVec(prometheus.CounterOpts{
-	Name:      "dual_writer_read_legacy_count",
-	Help:      "Histogram for the runtime of dual writer reads from legacy",
-	Namespace: "grafana",
-}, []string{"kind", "method"})
-
 func (m *dualWriterMetrics) init(reg prometheus.Registerer) {
 	log := klog.NewKlogr()
 	m.legacy = DualWriterLegacyDuration
@@ -75,7 +68,3 @@ func (m *dualWriterMetrics) recordOutcome(mode string, name string, areEqual boo
 	}
 	m.outcome.WithLabelValues(mode, name, method).Observe(observeValue)
 }
-
-func (m *dualWriterMetrics) recordReadLegacyCount(kind string, method string) {
-	m.legacyReads.WithLabelValues(kind, method).Inc()
-}