From d0f046ccd3d820575f58d9a60cfcedf5cbdb217d Mon Sep 17 00:00:00 2001 From: joshhunt Date: Wed, 8 Feb 2023 18:35:56 +0000 Subject: [PATCH] undo async --- .../dashboard/services/DashboardSrv.ts | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/public/app/features/dashboard/services/DashboardSrv.ts b/public/app/features/dashboard/services/DashboardSrv.ts index 933af914346..61a9b83494b 100644 --- a/public/app/features/dashboard/services/DashboardSrv.ts +++ b/public/app/features/dashboard/services/DashboardSrv.ts @@ -92,7 +92,7 @@ export class DashboardSrv { ); } - async starDashboard(dashboardUid: string, isStarred: boolean) { + starDashboard(dashboardUid: string, isStarred: boolean) { const backendSrv = getBackendSrv(); const request = { @@ -101,21 +101,21 @@ export class DashboardSrv { method: isStarred ? 'DELETE' : 'POST', }; - await backendSrv.request(request); + return backendSrv.request(request).then(() => { + const newIsStarred = !isStarred; - const newIsStarred = !isStarred; + if (this.dashboard?.uid === dashboardUid) { + this.dashboard.meta.isStarred = newIsStarred; + } - if (this.dashboard?.uid === dashboardUid) { - this.dashboard.meta.isStarred = newIsStarred; - } + const message = newIsStarred + ? t('notifications.starred-dashboard', 'Dashboard starred') + : t('notifications.unstarred-dashboard', 'Dashboard unstarred'); - const message = newIsStarred - ? t('notifications.starred-dashboard', 'Dashboard starred') - : t('notifications.unstarred-dashboard', 'Dashboard unstarred'); + appEvents.emit(AppEvents.alertSuccess, [message]); - appEvents.emit(AppEvents.alertSuccess, [message]); - - return newIsStarred; + return newIsStarred; + }); } }