diff --git a/docs/sources/plugins/developing/datasources.md b/docs/sources/plugins/developing/datasources.md index 064f3a850ae..f8792441bbd 100644 --- a/docs/sources/plugins/developing/datasources.md +++ b/docs/sources/plugins/developing/datasources.md @@ -25,7 +25,6 @@ To interact with the rest of grafana the plugins module file can export 5 differ - Datasource (Required) - QueryCtrl (Required) - ConfigCtrl (Required) -- QueryOptionsCtrl - AnnotationsQueryCtrl ## Plugin json @@ -182,12 +181,6 @@ A JavaScript class that will be instantiated and treated as an Angular controlle Requires a static template or templateUrl variable which will be rendered as the view for this controller. -## QueryOptionsCtrl - -A JavaScript class that will be instantiated and treated as an Angular controller when the user edits metrics in a panel. This controller is responsible for handling panel wide settings for the datasource, such as interval, rate and aggregations if needed. - -Requires a static template or templateUrl variable which will be rendered as the view for this controller. - ## AnnotationsQueryCtrl A JavaScript class that will be instantiated and treated as an Angular controller when the user choose this type of datasource in the templating menu in the dashboard. diff --git a/public/app/features/plugins/plugin_component.ts b/public/app/features/plugins/plugin_component.ts index dc9a83d72df..1936e57f558 100644 --- a/public/app/features/plugins/plugin_component.ts +++ b/public/app/features/plugins/plugin_component.ts @@ -126,24 +126,6 @@ function pluginDirectiveLoader($compile, datasourceSrv, $rootScope, $q, $http, $ }); }); } - // QueryOptionsCtrl - case 'query-options-ctrl': { - return datasourceSrv.get(scope.ctrl.panel.datasource).then(ds => { - return importPluginModule(ds.meta.module).then((dsModule): any => { - if (!dsModule.QueryOptionsCtrl) { - return { notFound: true }; - } - - return { - baseUrl: ds.meta.baseUrl, - name: 'query-options-ctrl-' + ds.meta.id, - bindings: { panelCtrl: '=' }, - attrs: { 'panel-ctrl': 'ctrl.panelCtrl' }, - Component: dsModule.QueryOptionsCtrl, - }; - }); - }); - } // Annotations case 'annotations-query-ctrl': { return importPluginModule(scope.ctrl.currentDatasource.meta.module).then(function(dsModule) { diff --git a/public/app/plugins/datasource/elasticsearch/module.ts b/public/app/plugins/datasource/elasticsearch/module.ts index f836e8807ee..022347d43c6 100644 --- a/public/app/plugins/datasource/elasticsearch/module.ts +++ b/public/app/plugins/datasource/elasticsearch/module.ts @@ -2,10 +2,6 @@ import { ElasticDatasource } from './datasource'; import { ElasticQueryCtrl } from './query_ctrl'; import { ElasticConfigCtrl } from './config_ctrl'; -class ElasticQueryOptionsCtrl { - static templateUrl = 'partials/query.options.html'; -} - class ElasticAnnotationsQueryCtrl { static templateUrl = 'partials/annotations.editor.html'; } @@ -14,6 +10,5 @@ export { ElasticDatasource as Datasource, ElasticQueryCtrl as QueryCtrl, ElasticConfigCtrl as ConfigCtrl, - ElasticQueryOptionsCtrl as QueryOptionsCtrl, ElasticAnnotationsQueryCtrl as AnnotationsQueryCtrl, };