Chore: Enable Go linter gocritic (#26224)

* Chore: Enable gocritic linter

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
This commit is contained in:
Arve Knudsen
2020-07-16 14:39:01 +02:00
committed by GitHub
parent 317c7b269c
commit d4e4cb4c71
43 changed files with 184 additions and 171 deletions

View File

@@ -51,9 +51,7 @@ func TestRouteSimpleRegister(t *testing.T) {
}
// Setup
rr := NewRouteRegister(func(name string) macaron.Handler {
return emptyHandler(name)
})
rr := NewRouteRegister(emptyHandler)
rr.Delete("/admin", emptyHandler("1"))
rr.Get("/down", emptyHandler("1"), emptyHandler("2"))
@@ -199,10 +197,7 @@ func TestDuplicateRoutShouldPanic(t *testing.T) {
}
}()
rr := NewRouteRegister(func(name string) macaron.Handler {
return emptyHandler(name)
})
rr := NewRouteRegister(emptyHandler)
rr.Get("/api", emptyHandler("1"))
rr.Get("/api", emptyHandler("1"))
@@ -220,9 +215,7 @@ func TestNamedMiddlewareRouteRegister(t *testing.T) {
}
// Setup
rr := NewRouteRegister(func(name string) macaron.Handler {
return emptyHandler(name)
})
rr := NewRouteRegister(emptyHandler)
rr.Delete("/admin", emptyHandler("1"))
rr.Get("/down", emptyHandler("1"), emptyHandler("2"))