IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

datatrails: include description of related metrics tab (#84525)

Browse Source 
* fix: include description of related metrics tab
This commit is contained in:
Darren Janeczek 2024-03-20 18:20:23 -04:00 committed by GitHub
parent 5d5e22ae11
commit d58e652cc3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
public/app/features/trails/MetricScene.tsx
View File

@ -12,7 +12,7 @@ import {
SceneVariableSet,
QueryVariable,
} from '@grafana/scenes';
import { ToolbarButton, Box, Stack, Icon, TabsBar, Tab, useStyles2, LinkButton } from '@grafana/ui';
import { ToolbarButton, Box, Stack, Icon, TabsBar, Tab, useStyles2, LinkButton, Tooltip } from '@grafana/ui';
import { getExploreUrl } from '../../core/utils/explore';
@ -109,7 +109,12 @@ export class MetricScene extends SceneObjectBase<MetricSceneState> {
const actionViewsDefinitions: ActionViewDefinition[] = [
{ displayName: 'Overview', value: 'overview', getScene: buildMetricOverviewScene },
{ displayName: 'Breakdown', value: 'breakdown', getScene: buildBreakdownActionScene },
{ displayName: 'Related metrics', value: 'related', getScene: buildRelatedMetricsScene },
{
displayName: 'Related metrics',
value: 'related',
getScene: buildRelatedMetricsScene,
description: 'Relevant metrics based on current label filters',
},
];
export interface MetricActionBarState extends SceneObjectState {}
@ -179,7 +184,7 @@ export class MetricActionBar extends SceneObjectBase<MetricActionBarState> {
<TabsBar>
{actionViewsDefinitions.map((tab, index) => {
return (
const tabRender = (
<Tab
key={index}
label={tab.displayName}
@ -187,6 +192,15 @@ export class MetricActionBar extends SceneObjectBase<MetricActionBarState> {
onChangeTab={() => metricScene.setActionView(tab.value)}
/>
);
if (tab.description) {
return (
<Tooltip key={index} content={tab.description} placement="bottom-start" theme="info">
{tabRender}
</Tooltip>
);
}
return tabRender;
})}
</TabsBar>
</Box>

1
public/app/features/trails/shared.ts
View File

@ -6,6 +6,7 @@ export type ActionViewType = 'overview' | 'breakdown' | 'logs' | 'related';
export interface ActionViewDefinition {
displayName: string;
value: ActionViewType;
description?: string;
getScene: () => SceneObject;
}