IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Revert "LegendIcon: only render color picker when the props change (#33141)" (#33313)

Browse Source 
This reverts commit af46bbf654.
This commit is contained in:
Dominik Prokop 2021-04-23 15:50:34 +02:00 committed by GitHub
parent bf83fb80b7
commit d76c056656
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
packages/grafana-ui/src/components/VizLegend/VizLegendSeriesIcon.tsx
View File

@ -8,29 +8,25 @@ interface Props {
onColorChange: (color: string) => void; onColorChange: (color: string) => void;
} }
export const VizLegendSeriesIcon = React.memo<Props>( /**
({ disabled, color, onColorChange }) => { * @internal
return disabled ? ( */
<SeriesIcon color={color} /> export const VizLegendSeriesIcon: React.FunctionComponent<Props> = ({ disabled, color, onColorChange }) => {
) : ( return disabled ? (
<SeriesColorPicker color={color} onChange={onColorChange} enableNamedColors> <SeriesIcon color={color} />
{({ ref, showColorPicker, hideColorPicker }) => ( ) : (
<SeriesIcon <SeriesColorPicker color={color} onChange={onColorChange} enableNamedColors>
color={color} {({ ref, showColorPicker, hideColorPicker }) => (
className="pointer" <SeriesIcon
ref={ref} color={color}
onClick={showColorPicker} className="pointer"
onMouseLeave={hideColorPicker} ref={ref}
/> onClick={showColorPicker}
)} onMouseLeave={hideColorPicker}
</SeriesColorPicker> />
); )}
}, </SeriesColorPicker>
// areEqual -- return true if they are the same. );
// onColorChange updates frequently, so ignore that };
(prevProps, nextProps) => {
return prevProps.color === nextProps.color && prevProps.disabled === nextProps.disabled;
}
);
VizLegendSeriesIcon.displayName = 'VizLegendSeriesIcon'; VizLegendSeriesIcon.displayName = 'VizLegendSeriesIcon';