IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

InfluxDB: InfluxQL query editor: generate better HTML (#34467)

Browse Source
This commit is contained in:
Gábor Farkas
2021-05-20 16:46:08 +02:00
committed by GitHub
parent dbe281530c
commit d95cc4a08f
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/app/plugins/datasource/influxdb/components/VisualInfluxQLEditor/Seg.tsx
View File

@@ -176,11 +176,9 @@ export const Seg = ({
const [isOpen, setOpen] = useState(false); const [isOpen, setOpen] = useState(false);
if (!isOpen) { if (!isOpen) {
const className = cx(defaultButtonClass, buttonClassName); const className = cx(defaultButtonClass, buttonClassName);
// this should not be a label, this should be a button,
// but this is what is used inside a Segment, and i just
// want the same look
return ( return (
<InlineLabel <InlineLabel
as="button"
className={className} className={className}
onClick={() => { onClick={() => {
setOpen(true); setOpen(true);

2
public/app/plugins/datasource/influxdb/components/VisualInfluxQLEditor/TagsSection.test.tsx
View File

@@ -31,7 +31,7 @@ async function assertSegmentSelect(
callbackValue: unknown callbackValue: unknown
) { ) {
// we find the segment // we find the segment
const segs = screen.getAllByText(segmentText, { selector: 'label' }); const segs = screen.getAllByRole('button', { name: segmentText });
expect(segs.length).toBe(1); expect(segs.length).toBe(1);
const seg = segs[0]; const seg = segs[0];
expect(seg).toBeInTheDocument(); expect(seg).toBeInTheDocument();