IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Alerting: Add "no-rules" to redirect to rule viewer (#73111)

Browse Source
This commit is contained in:
Gilles De Mey 2023-08-09 17:17:41 +02:00 committed by GitHub
parent e53e22ef2a
commit d9695eb507
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
public/app/features/alerting/unified/RedirectToRuleViewer.test.tsx
View File

@ -59,6 +59,17 @@ describe('Redirect to Rule viewer', () => {
expect(screen.getAllByText('Cloud test alert')).toHaveLength(2);
});
it('should show no rules if empty response', () => {
jest.mocked(combinedRuleHooks.useCloudCombinedRulesMatching).mockReturnValue({
rules: [],
loading: false,
error: undefined,
});
mockRuleSourceByName();
renderRedirectToRuleViewer('/alerting/test prom/prom alert/find');
expect(screen.getByTestId('no-rules')).toBeInTheDocument();
});
it('should redirect to view rule page if only one match', () => {
jest.mocked(combinedRuleHooks.useCloudCombinedRulesMatching).mockReturnValue({
rules: [mockedRules[0]],

11
public/app/features/alerting/unified/RedirectToRuleViewer.tsx
View File

@ -98,6 +98,17 @@ export function RedirectToRuleViewer(): JSX.Element | null {
return <Redirect to={to} />;
}
if (rules.length === 0) {
return (
<RuleViewerLayout title={pageTitle}>
<div data-testid="no-rules">
No rules in <span className={styles.param}>{sourceName}</span> matched the name{' '}
<span className={styles.param}>{name}</span>
</div>
</RuleViewerLayout>
);
}
return (
<RuleViewerLayout title={pageTitle}>
<div>