mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
added two new variables in default theme for panel padding, replaced panelhorizontalpadding and variables.panelverticalpadding with new variables
This commit is contained in:
@@ -248,9 +248,4 @@ $external-services: (
|
|||||||
icon: '',
|
icon: '',
|
||||||
),
|
),
|
||||||
) !default;
|
) !default;
|
||||||
|
|
||||||
:export {
|
|
||||||
panelhorizontalpadding: $panel-horizontal-padding;
|
|
||||||
panelverticalpadding: $panel-vertical-padding;
|
|
||||||
}
|
|
||||||
`;
|
`;
|
||||||
|
|||||||
@@ -61,6 +61,10 @@ const theme: GrafanaThemeCommons = {
|
|||||||
s: '1px',
|
s: '1px',
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
panelPadding: {
|
||||||
|
horizontal: 10,
|
||||||
|
vertical: 5,
|
||||||
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
export default theme;
|
export default theme;
|
||||||
|
|||||||
@@ -66,6 +66,10 @@ export interface GrafanaThemeCommons {
|
|||||||
s: string;
|
s: string;
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
panelPadding: {
|
||||||
|
horizontal: number;
|
||||||
|
vertical: number;
|
||||||
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export interface GrafanaTheme extends GrafanaThemeCommons {
|
export interface GrafanaTheme extends GrafanaThemeCommons {
|
||||||
|
|||||||
@@ -6,11 +6,6 @@ import { cleanUpDashboard } from '../state/actions';
|
|||||||
import { getNoPayloadActionCreatorMock, NoPayloadActionCreatorMock } from 'app/core/redux';
|
import { getNoPayloadActionCreatorMock, NoPayloadActionCreatorMock } from 'app/core/redux';
|
||||||
import { DashboardRouteInfo, DashboardInitPhase } from 'app/types';
|
import { DashboardRouteInfo, DashboardInitPhase } from 'app/types';
|
||||||
|
|
||||||
jest.mock('sass/_variables.generated.scss', () => ({
|
|
||||||
panelhorizontalpadding: 10,
|
|
||||||
panelVerticalPadding: 10,
|
|
||||||
}));
|
|
||||||
|
|
||||||
jest.mock('app/features/dashboard/components/DashboardSettings/SettingsCtrl', () => ({}));
|
jest.mock('app/features/dashboard/components/DashboardSettings/SettingsCtrl', () => ({}));
|
||||||
|
|
||||||
interface ScenarioContext {
|
interface ScenarioContext {
|
||||||
|
|||||||
@@ -1,10 +1,5 @@
|
|||||||
import { PanelChrome } from './PanelChrome';
|
import { PanelChrome } from './PanelChrome';
|
||||||
|
|
||||||
jest.mock('sass/_variables.generated.scss', () => ({
|
|
||||||
panelhorizontalpadding: 10,
|
|
||||||
panelVerticalPadding: 10,
|
|
||||||
}));
|
|
||||||
|
|
||||||
describe('PanelChrome', () => {
|
describe('PanelChrome', () => {
|
||||||
let chrome: PanelChrome;
|
let chrome: PanelChrome;
|
||||||
|
|
||||||
|
|||||||
@@ -14,6 +14,7 @@ import ErrorBoundary from '../../../core/components/ErrorBoundary/ErrorBoundary'
|
|||||||
import { applyPanelTimeOverrides, snapshotDataToPanelData } from 'app/features/dashboard/utils/panel';
|
import { applyPanelTimeOverrides, snapshotDataToPanelData } from 'app/features/dashboard/utils/panel';
|
||||||
import { PANEL_HEADER_HEIGHT } from 'app/core/constants';
|
import { PANEL_HEADER_HEIGHT } from 'app/core/constants';
|
||||||
import { profiler } from 'app/core/profiler';
|
import { profiler } from 'app/core/profiler';
|
||||||
|
import config from 'app/core/config';
|
||||||
|
|
||||||
// Types
|
// Types
|
||||||
import { DashboardModel, PanelModel } from '../state';
|
import { DashboardModel, PanelModel } from '../state';
|
||||||
@@ -21,7 +22,6 @@ import { PanelPlugin } from 'app/types';
|
|||||||
import { DataQueryResponse, TimeRange, LoadingState, PanelData, DataQueryError } from '@grafana/ui';
|
import { DataQueryResponse, TimeRange, LoadingState, PanelData, DataQueryError } from '@grafana/ui';
|
||||||
import { ScopedVars } from '@grafana/ui';
|
import { ScopedVars } from '@grafana/ui';
|
||||||
|
|
||||||
import variables from 'sass/_variables.generated.scss';
|
|
||||||
import templateSrv from 'app/features/templating/template_srv';
|
import templateSrv from 'app/features/templating/template_srv';
|
||||||
|
|
||||||
const DEFAULT_PLUGIN_ERROR = 'Error in plugin';
|
const DEFAULT_PLUGIN_ERROR = 'Error in plugin';
|
||||||
@@ -160,8 +160,8 @@ export class PanelChrome extends PureComponent<Props, State> {
|
|||||||
panelData={panelData}
|
panelData={panelData}
|
||||||
timeRange={timeRange}
|
timeRange={timeRange}
|
||||||
options={panel.getOptions(plugin.exports.reactPanel.defaults)}
|
options={panel.getOptions(plugin.exports.reactPanel.defaults)}
|
||||||
width={width - 2 * variables.panelhorizontalpadding}
|
width={width - 2 * config.theme.panelPadding.horizontal}
|
||||||
height={height - PANEL_HEADER_HEIGHT - variables.panelverticalpadding}
|
height={height - PANEL_HEADER_HEIGHT - config.theme.panelPadding.vertical}
|
||||||
renderCounter={renderCounter}
|
renderCounter={renderCounter}
|
||||||
replaceVariables={this.replaceVariables}
|
replaceVariables={this.replaceVariables}
|
||||||
/>
|
/>
|
||||||
|
|||||||
@@ -251,8 +251,3 @@ $external-services: (
|
|||||||
icon: '',
|
icon: '',
|
||||||
),
|
),
|
||||||
) !default;
|
) !default;
|
||||||
|
|
||||||
:export {
|
|
||||||
panelhorizontalpadding: $panel-horizontal-padding;
|
|
||||||
panelverticalpadding: $panel-vertical-padding;
|
|
||||||
}
|
|
||||||
|
|||||||
8
public/sass/_variables.generated.scss.d.ts
vendored
8
public/sass/_variables.generated.scss.d.ts
vendored
@@ -1,8 +0,0 @@
|
|||||||
export interface GrafanaVariables {
|
|
||||||
panelhorizontalpadding: number;
|
|
||||||
panelverticalpadding: number;
|
|
||||||
}
|
|
||||||
|
|
||||||
declare const variables: GrafanaVariables;
|
|
||||||
|
|
||||||
export default variables;
|
|
||||||
Reference in New Issue
Block a user