IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Datasources: Rename a UI tracking event property (#62788)

Browse Source 
refactor: rename the the `editLink` property to `path`
This commit is contained in:
Levente Balogh 2023-02-03 09:00:04 +01:00 committed by GitHub
parent 7391793504
commit de97ac7128
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
public/app/features/datasources/state/actions.test.ts
View File

@ -242,7 +242,7 @@ describe('testDataSource', () => {
datasource_uid: 'CW1234',
grafana_version: '1.0',
success: true,
editLink: '/datasources/edit/CloudWatch',
path: '/datasources/edit/CloudWatch',
});
});
@ -279,7 +279,7 @@ describe('testDataSource', () => {
datasource_uid: 'azM0nit0R',
grafana_version: '1.0',
success: false,
editLink: '/datasources/edit/Azure Monitor',
path: '/datasources/edit/Azure Monitor',
});
});
@ -360,7 +360,7 @@ describe('addDataSource', () => {
plugin_version: '1.2.3',
datasource_uid: 'azure23',
grafana_version: '1.0',
editLink: DATASOURCES_ROUTES.Edit.replace(':uid', 'azure23'),
path: DATASOURCES_ROUTES.Edit.replace(':uid', 'azure23'),
});
});
});

6
public/app/features/datasources/state/actions.ts
View File

@ -116,7 +116,7 @@ export const testDataSource = (
plugin_id: dsApi.type,
datasource_uid: dsApi.uid,
success: true,
editLink,
path: editLink,
});
} catch (err) {
let message: string | undefined;
@ -137,7 +137,7 @@ export const testDataSource = (
plugin_id: dsApi.type,
datasource_uid: dsApi.uid,
success: false,
editLink,
path: editLink,
});
}
});
@ -221,7 +221,7 @@ export function addDataSource(plugin: DataSourcePluginMeta, editRoute = DATASOUR
plugin_id: plugin.id,
datasource_uid: result.datasource.uid,
plugin_version: result.meta?.info?.version,
editLink,
path: editLink,
});
locationService.push(editLink);

8
public/app/features/datasources/tracking.ts
View File

@ -24,8 +24,8 @@ type DataSourceCreatedProps = {
plugin_id: string;
/** The plugin version (especially interesting in external plugins - core plugins are aligned with grafana version) */
plugin_version?: string;
/** The URL that points to the edit page for the datasoruce. We are using this to be able to distinguish between the performance of different datasource edit locations. */
editLink?: string;
/** The URL path that points to the page where the event was triggered. We are using this to be able to distinguish between the performance of different datasource edit locations. */
path?: string;
};
/**
@ -53,6 +53,6 @@ type DataSourceTestedProps = {
plugin_version?: string;
/** Whether or not the datasource test succeeded = the datasource was successfully configured */
success: boolean;
/** The URL that points to the edit page for the datasoruce. We are using this to be able to distinguish between the performance of different datasource edit locations. */
editLink?: string;
/** The URL path that points to the page where the event was triggered. We are using this to be able to distinguish between the performance of different datasource edit locations. */
path?: string;
};