IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Canvas: Add icon value mapping (#59013)

Browse Source
This commit is contained in:
Nathan Marrs 2022-11-22 15:39:19 -07:00 committed by GitHub
parent 51359fe90d
commit e157ef1171
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
public/app/features/dimensions/resource.test.ts Normal file
View File

@ -0,0 +1,19 @@
import { getResourceDimension } from './resource';
import { ResourceDimensionMode } from './types';
describe('getResourceDimension', () => {
const publicPath = '/public/';
beforeAll(() => {
window.__grafana_public_path__ = publicPath;
});
it('fixed mode', () => {
const frame = undefined;
const fixedValue = 'img/icons/unicons/question-circle.svg';
const config = { mode: ResourceDimensionMode.Fixed, fixed: fixedValue };
expect(getResourceDimension(frame, config).fixed).toEqual(publicPath + fixedValue);
});
// TODO: write tests for field and mapping modes
});

8
public/app/features/dimensions/resource.ts
View File

@ -50,8 +50,12 @@ export function getResourceDimension(
// mode === ResourceDimensionMode.Field case
const getIcon = (value: string): string => {
const display = field.display!;
return getPublicOrAbsoluteUrl(display(value).icon ?? value ?? '');
if (field && field.display) {
const icon = field.display(value).icon;
return getPublicOrAbsoluteUrl(icon ?? '');
}
return '';
};
return {

12
public/app/plugins/panel/canvas/module.tsx
View File

@ -1,4 +1,4 @@
import { PanelOptionsEditorBuilder, PanelPlugin } from '@grafana/data';
import { FieldConfigProperty, PanelOptionsEditorBuilder, PanelPlugin } from '@grafana/data';
import { FrameState } from 'app/features/canvas/runtime/frame';
import { CanvasPanel, InstanceState } from './CanvasPanel';
@ -25,7 +25,15 @@ export const addStandardCanvasEditorOptions = (builder: PanelOptionsEditorBuilde
export const plugin = new PanelPlugin<PanelOptions>(CanvasPanel)
.setNoPadding() // extend to panel edges
.useFieldConfig()
.useFieldConfig({
standardOptions: {
[FieldConfigProperty.Mappings]: {
settings: {
icon: true,
},
},
},
})
.setMigrationHandler(canvasMigrationHandler)
.setPanelOptions((builder, context) => {
const state: InstanceState = context.instanceState;