LDAP: finishing touches (#17945)

* LDAP:Docs: `active_sync_enabled` setting

Mention `active_sync_enabled` setting and enable it by default

* LDAP: move "disableExternalUser" method

Idea behind new design of the LDAP module is to minimise conflation
between other parts of the system, so it would decoupled as much as
possible from stuff like database, HTTP transport and etc.

Following "Do One Thing and Do It Well" Unix philosophy principal, other things
could be better fitted on the consumer side of things.

Which what this commit trying to archive

* LDAP: correct user/admin binding

The second binding was not happening, so if the admin login/password
in LDAP configuration was correct, anyone could had login as anyone using
incorrect password
This commit is contained in:
Oleg Gaidarenko
2019-07-05 17:49:00 +03:00
committed by GitHub
parent 88a2c6fce7
commit e2cf7c9698
9 changed files with 311 additions and 97 deletions

View File

@@ -413,7 +413,7 @@ allow_sign_up = true
# LDAP backround sync (Enterprise only)
# At 1 am every day
sync_cron = "0 0 1 * * *"
active_sync_enabled = false
active_sync_enabled = true
#################################### SMTP / Emailing #####################
[smtp]

View File

@@ -378,7 +378,7 @@
# LDAP backround sync (Enterprise only)
# At 1 am every day
;sync_cron = "0 0 1 * * *"
;active_sync_enabled = false
;active_sync_enabled = true
#################################### SMTP / Emailing ##########################
[smtp]