IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

RBAC: Remove sort and unique values when fetching permissions (#53461)

Browse Source 
* RBAC: remove sort and unique values for fetching permissions
This commit is contained in:
Karl Persson
2022-08-09 15:52:14 +02:00
committed by GitHub
parent 27e2953951
commit e4c45c4f98
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/services/accesscontrol/database/database.go
View File

@@ -26,8 +26,7 @@ func (s *AccessControlStore) GetUserPermissions(ctx context.Context, query acces
err := s.sql.WithDbSession(ctx, func(sess *sqlstore.DBSession) error { err := s.sql.WithDbSession(ctx, func(sess *sqlstore.DBSession) error {
filter, params := userRolesFilter(query.OrgID, query.UserID, query.Roles) filter, params := userRolesFilter(query.OrgID, query.UserID, query.Roles)
// TODO: optimize this q := `SELECT
q := `SELECT DISTINCT
permission.action, permission.action,
permission.scope permission.scope
FROM permission FROM permission
@@ -45,10 +44,6 @@ func (s *AccessControlStore) GetUserPermissions(ctx context.Context, query acces
} }
} }
q += `
ORDER BY permission.scope
`
if err := sess.SQL(q, params...).Find(&result); err != nil { if err := sess.SQL(q, params...).Find(&result); err != nil {
return err return err
} }