ResourceStore: Fix sql List (#91043)

* fix resource list

* ensure we get the resource version without FOR SHARE

pkg/storage/unified/sql/backend.go

@@ -541,6 +541,7 @@ func fetchLatestRV(ctx context.Context, x db.ContextExecer, d sqltemplate.Dialec
 		SQLTemplate:     sqltemplate.New(d),
 		Group:           group,
 		Resource:        resource,
+		ReadOnly:        true,
 		resourceVersion: new(resourceVersion),
 	})
 	if errors.Is(err, sql.ErrNoRows) {

pkg/storage/unified/sql/data/resource_version_get.sql

@@ -4,5 +4,7 @@ SELECT
     WHERE 1 = 1
         AND {{ .Ident "group" }}    = {{ .Arg .Group }}
         AND {{ .Ident "resource" }} = {{ .Arg .Resource }}
+    {{ if not .ReadOnly }}
     {{ .SelectFor "UPDATE" }}
+    {{ end}}
 ;

pkg/storage/unified/sql/queries.go

@@ -189,6 +189,7 @@ func (r *resourceVersion) Results() (*resourceVersion, error) {
 type sqlResourceVersionRequest struct {
 	*sqltemplate.SQLTemplate
 	Group, Resource string
+	ReadOnly        bool
 	*resourceVersion
 }
 

pkg/storage/unified/sql/queries_test.go

@@ -268,6 +268,7 @@ func TestQueries(t *testing.T) {
 				Data: &sqlResourceVersionRequest{
 					SQLTemplate:     new(sqltemplate.SQLTemplate),
 					resourceVersion: new(resourceVersion),
+					ReadOnly:        false,
 				},
 				Expected: expected{
 					"resource_version_get_mysql.sql": dialects{