Tempo: Always use time range even if timeShiftEnabled is false (#85477)

* Tempo: Always use time range even if timeShiftEnabled is false

* Fix unused import and failing test
This commit is contained in:
Olivier Giniaux 2024-05-20 10:28:07 +02:00 committed by GitHub
parent fe991a9a7b
commit e91136338a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 15 deletions

View File

@ -434,8 +434,8 @@ describe('Tempo data source', () => {
[{ refId: 'refid1', queryType: 'traceql', query: '' } as TempoQuery]
);
expect(request.range.from.unix()).toBe(dateTime(0).unix());
expect(request.range.to.unix()).toBe(dateTime(0).unix());
expect(request.range.from.unix()).toBe(dateTime(new Date(2022, 8, 13, 16, 0, 0, 0)).unix());
expect(request.range.to.unix()).toBe(dateTime(new Date(2022, 8, 13, 16, 15, 0, 0)).unix());
});
});

View File

@ -12,7 +12,6 @@ import {
DataQueryResponseData,
DataSourceGetTagValuesOptions,
DataSourceInstanceSettings,
dateTime,
FieldType,
LoadingState,
rangeUtil,
@ -666,18 +665,18 @@ export class TempoDatasource extends DataSourceWithBackend<TempoQuery, TempoJson
targets,
};
if (this.traceQuery?.timeShiftEnabled) {
request.range = options.range && {
...options.range,
from: options.range.from.subtract(
rangeUtil.intervalToMs(this.traceQuery?.spanStartTimeShift || '30m'),
'milliseconds'
),
to: options.range.to.add(rangeUtil.intervalToMs(this.traceQuery?.spanEndTimeShift || '30m'), 'milliseconds'),
};
} else {
request.range = { from: dateTime(0), to: dateTime(0), raw: { from: dateTime(0), to: dateTime(0) } };
}
request.range = options.range && {
...options.range,
from: this.traceQuery?.timeShiftEnabled
? options.range.from.subtract(
rangeUtil.intervalToMs(this.traceQuery?.spanStartTimeShift || '30m'),
'milliseconds'
)
: options.range.from,
to: this.traceQuery?.timeShiftEnabled
? options.range.to.add(rangeUtil.intervalToMs(this.traceQuery?.spanEndTimeShift || '30m'), 'milliseconds')
: options.range.to,
};
return request;
}