IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Alerting: Save and restore condition reference while switching type (#71629)

Browse Source 
Save and restore condition reference while switching type
This commit is contained in:
Sonia Aguilar
2023-07-18 10:06:47 +02:00
committed by GitHub
parent 8f76647386
commit ec479b8d88
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
public/app/features/alerting/unified/components/rule-editor/query-and-alert-condition/QueryAndExpressionsStep.tsx
View File

@@ -303,8 +303,9 @@ export const QueryAndExpressionsStep = ({ editingExistingRule, onDataChange }: P
[dispatch]
);
// we need to keep track of the previous expressions to be able to restore them when switching back to grafana managed
// we need to keep track of the previous expressions and condition reference to be able to restore them when switching back to grafana managed
const [prevExpressions, setPrevExpressions] = useState<AlertQuery[]>([]);
const [prevCondition, setPrevCondition] = useState<string | null>(null);
const restoreExpressionsInQueries = useCallback(() => {
addExpressionsInQueries(prevExpressions);
@@ -314,14 +315,26 @@ export const QueryAndExpressionsStep = ({ editingExistingRule, onDataChange }: P
const typeInForm = getValues('type');
if (typeInForm === RuleFormType.cloudAlerting) {
setValue('type', RuleFormType.grafana);
setPrevExpressions.length > 0 && restoreExpressionsInQueries();
prevExpressions.length > 0 && restoreExpressionsInQueries();
prevCondition && setValue('condition', prevCondition);
} else {
setValue('type', RuleFormType.cloudAlerting);
const expressions = queries.filter((query) => query.datasourceUid === ExpressionDatasourceUID);
setPrevExpressions(expressions);
removeExpressionsInQueries();
setPrevCondition(condition);
}
}, [getValues, setValue, queries, removeExpressionsInQueries, restoreExpressionsInQueries, setPrevExpressions]);
}, [
getValues,
setValue,
queries,
removeExpressionsInQueries,
restoreExpressionsInQueries,
setPrevExpressions,
prevExpressions,
prevCondition,
condition,
]);
return (
<RuleEditorSection stepNo={2} title="Define query and alert condition">