IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

tests: migrated tests for link_srv to jest, #9666

Browse Source
This commit is contained in:
Torkel Ödegaard 2017-10-31 14:29:25 +01:00
parent f097bce565
commit ec94dfa890
2 changed files with 4 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
public/app/features/panellinks/link_srv.ts
View File

@ -5,8 +5,7 @@ import kbn from 'app/core/utils/kbn';
export class LinkSrv { export class LinkSrv {
/** @ngInject */ /** @ngInject */
constructor(private templateSrv, private timeSrv) { constructor(private templateSrv, private timeSrv) {}
}
getLinkUrl(link) { getLinkUrl(link) {
var url = this.templateSrv.replace(link.url || ''); var url = this.templateSrv.replace(link.url || '');
@ -29,7 +28,9 @@ export class LinkSrv {
var paramsArray = []; var paramsArray = [];
_.each(params, function(value, key) { _.each(params, function(value, key) {
if (value === null) { return; } if (value === null) {
return;
}
if (value === true) { if (value === true) {
paramsArray.push(key); paramsArray.push(key);
} else if (_.isArray(value)) { } else if (_.isArray(value)) {
@ -107,7 +108,6 @@ export class LinkSrv {
return info; return info;
} }
} }
angular.module('grafana.services').service('linkSrv', LinkSrv); angular.module('grafana.services').service('linkSrv', LinkSrv);

46
public/app/features/panellinks/specs/link_srv_specs.ts
View File

@ -1,46 +0,0 @@
import {describe, beforeEach, it, expect, angularMocks} from 'test/lib/common';
import 'app/features/panellinks/link_srv';
import _ from 'lodash';
describe('linkSrv', function() {
var _linkSrv;
beforeEach(angularMocks.module('grafana.core'));
beforeEach(angularMocks.module('grafana.services'));
beforeEach(angularMocks.inject(function(linkSrv) {
_linkSrv = linkSrv;
}));
describe('when appending query strings', function() {
it('add ? to URL if not present', function() {
var url = _linkSrv.appendToQueryString('http://example.com', 'foo=bar');
expect(url).to.be('http://example.com?foo=bar');
});
it('do not add & to URL if ? is present but query string is empty', function() {
var url = _linkSrv.appendToQueryString('http://example.com?', 'foo=bar');
expect(url).to.be('http://example.com?foo=bar');
});
it('add & to URL if query string is present', function() {
var url = _linkSrv.appendToQueryString('http://example.com?foo=bar', 'hello=world');
expect(url).to.be('http://example.com?foo=bar&hello=world');
});
it('do not change the URL if there is nothing to append', function() {
_.each(['', undefined, null], function(toAppend) {
var url1 = _linkSrv.appendToQueryString('http://example.com', toAppend);
expect(url1).to.be('http://example.com');
var url2 = _linkSrv.appendToQueryString('http://example.com?', toAppend);
expect(url2).to.be('http://example.com?');
var url3 = _linkSrv.appendToQueryString('http://example.com?foo=bar', toAppend);
expect(url3).to.be('http://example.com?foo=bar');
});
});
});
});