mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
loki: removed unused fields, params, attributes (#47571)
* loki: refactor: removed unused param * loki: removed unused attribute * loki: removed unused fields * loki: remove unused query.format * loki: removed unused prop
This commit is contained in:
parent
9a0f626948
commit
eca61e6dd7
@ -411,7 +411,7 @@ describe('LokiDatasource', () => {
|
||||
|
||||
it('should not modify expression with no filters', async () => {
|
||||
await lastValueFrom(ds.query(options as any));
|
||||
expect(ds.runRangeQuery).toBeCalledWith({ expr: DEFAULT_EXPR }, expect.anything(), expect.anything());
|
||||
expect(ds.runRangeQuery).toBeCalledWith({ expr: DEFAULT_EXPR }, expect.anything());
|
||||
});
|
||||
|
||||
it('should add filters to expression', async () => {
|
||||
@ -431,7 +431,6 @@ describe('LokiDatasource', () => {
|
||||
await lastValueFrom(ds.query(options as any));
|
||||
expect(ds.runRangeQuery).toBeCalledWith(
|
||||
{ expr: 'rate({bar="baz",job="foo",k1="v1",k2!="v2"} |= "bar" [5m])' },
|
||||
expect.anything(),
|
||||
expect.anything()
|
||||
);
|
||||
});
|
||||
@ -452,7 +451,6 @@ describe('LokiDatasource', () => {
|
||||
await lastValueFrom(ds.query(options as any));
|
||||
expect(ds.runRangeQuery).toBeCalledWith(
|
||||
{ expr: 'rate({bar="baz",job="foo",k1=~"v.*",k2=~"v\\\\\'.*"} |= "bar" [5m])' },
|
||||
expect.anything(),
|
||||
expect.anything()
|
||||
);
|
||||
});
|
||||
|
@ -191,7 +191,7 @@ export class LokiDatasource
|
||||
) {
|
||||
subQueries.push(doLokiChannelStream(target, this, request));
|
||||
} else {
|
||||
subQueries.push(this.runRangeQuery(target, request, filteredTargets.length));
|
||||
subQueries.push(this.runRangeQuery(target, request));
|
||||
}
|
||||
}
|
||||
|
||||
@ -262,7 +262,7 @@ export class LokiDatasource
|
||||
}
|
||||
|
||||
return {
|
||||
data: [lokiResultsToTableModel(response.data.data.result, responseListLength, target.refId, meta, true)],
|
||||
data: [lokiResultsToTableModel(response.data.data.result, responseListLength, target.refId, meta)],
|
||||
key: `${target.refId}_instant`,
|
||||
};
|
||||
}),
|
||||
@ -303,11 +303,7 @@ export class LokiDatasource
|
||||
/**
|
||||
* Attempts to send a query to /loki/api/v1/query_range
|
||||
*/
|
||||
runRangeQuery = (
|
||||
target: LokiQuery,
|
||||
options: RangeQueryOptions,
|
||||
responseListLength = 1
|
||||
): Observable<DataQueryResponse> => {
|
||||
runRangeQuery = (target: LokiQuery, options: RangeQueryOptions): Observable<DataQueryResponse> => {
|
||||
// For metric query we use maxDataPoints from the request options which should be something like width of the
|
||||
// visualisation in pixels. In case of logs request we either use lines limit defined in the query target or
|
||||
// global limit defined for the data source which ever is lower.
|
||||
@ -334,7 +330,6 @@ export class LokiDatasource
|
||||
response.data,
|
||||
target,
|
||||
query,
|
||||
responseListLength,
|
||||
maxDataPoints,
|
||||
this.instanceSettings.jsonData,
|
||||
(options as DataQueryRequest<LokiQuery>).scopedVars
|
||||
|
@ -226,8 +226,7 @@ export function lokiResultsToTableModel(
|
||||
lokiResults: Array<LokiMatrixResult | LokiVectorResult>,
|
||||
resultCount: number,
|
||||
refId: string,
|
||||
meta: QueryResultMeta,
|
||||
valueWithRefId?: boolean
|
||||
meta: QueryResultMeta
|
||||
): TableModel {
|
||||
if (!lokiResults || lokiResults.length === 0) {
|
||||
return new TableModel();
|
||||
@ -246,7 +245,7 @@ export function lokiResultsToTableModel(
|
||||
table.columns = [
|
||||
{ text: 'Time', type: FieldType.time },
|
||||
...sortedLabels.map((label) => ({ text: label, filterable: true, type: FieldType.string })),
|
||||
{ text: resultCount > 1 || valueWithRefId ? `Value #${refId}` : 'Value', type: FieldType.number },
|
||||
{ text: `Value #${refId}`, type: FieldType.number },
|
||||
];
|
||||
|
||||
// Populate rows, set value to empty string when label not present.
|
||||
@ -453,7 +452,6 @@ function rangeQueryResponseToTimeSeries(
|
||||
response: LokiResponse,
|
||||
query: LokiRangeQueryRequest,
|
||||
target: LokiQuery,
|
||||
responseListLength: number,
|
||||
scopedVars: ScopedVars
|
||||
): TimeSeries[] {
|
||||
/** Show results of Loki metric queries only in graph */
|
||||
@ -461,16 +459,10 @@ function rangeQueryResponseToTimeSeries(
|
||||
preferredVisualisationType: 'graph',
|
||||
};
|
||||
const transformerOptions: TransformerOptions = {
|
||||
format: target.format,
|
||||
legendFormat: target.legendFormat ?? '',
|
||||
start: query.start!,
|
||||
end: query.end!,
|
||||
step: query.step!,
|
||||
query: query.query,
|
||||
responseListLength,
|
||||
refId: target.refId,
|
||||
meta,
|
||||
valueWithRefId: target.valueWithRefId,
|
||||
scopedVars,
|
||||
};
|
||||
|
||||
@ -490,10 +482,9 @@ export function rangeQueryResponseToDataFrames(
|
||||
response: LokiResponse,
|
||||
query: LokiRangeQueryRequest,
|
||||
target: LokiQuery,
|
||||
responseListLength: number,
|
||||
scopedVars: ScopedVars
|
||||
): DataFrame[] {
|
||||
const series = rangeQueryResponseToTimeSeries(response, query, target, responseListLength, scopedVars);
|
||||
const series = rangeQueryResponseToTimeSeries(response, query, target, scopedVars);
|
||||
const frames = series.map((s) => toDataFrame(s));
|
||||
|
||||
const { step } = query;
|
||||
@ -517,7 +508,6 @@ export function processRangeQueryResponse(
|
||||
response: LokiResponse,
|
||||
target: LokiQuery,
|
||||
query: LokiRangeQueryRequest,
|
||||
responseListLength: number,
|
||||
limit: number,
|
||||
config: LokiOptions,
|
||||
scopedVars: ScopedVars
|
||||
@ -532,16 +522,7 @@ export function processRangeQueryResponse(
|
||||
case LokiResultType.Vector:
|
||||
case LokiResultType.Matrix:
|
||||
return of({
|
||||
data: rangeQueryResponseToDataFrames(
|
||||
response,
|
||||
query,
|
||||
{
|
||||
...target,
|
||||
format: 'time_series',
|
||||
},
|
||||
responseListLength,
|
||||
scopedVars
|
||||
),
|
||||
data: rangeQueryResponseToDataFrames(response, query, target, scopedVars),
|
||||
key: target.refId,
|
||||
});
|
||||
default:
|
||||
|
@ -33,10 +33,7 @@ export enum LokiQueryType {
|
||||
export interface LokiQuery extends DataQuery {
|
||||
queryType?: LokiQueryType;
|
||||
expr: string;
|
||||
query?: string;
|
||||
format?: string;
|
||||
legendFormat?: string;
|
||||
valueWithRefId?: boolean;
|
||||
maxLines?: number;
|
||||
resolution?: number;
|
||||
/** Used in range queries */
|
||||
@ -134,15 +131,9 @@ export type DerivedFieldConfig = {
|
||||
};
|
||||
|
||||
export interface TransformerOptions {
|
||||
format?: string;
|
||||
legendFormat?: string;
|
||||
step: number;
|
||||
start: number;
|
||||
end: number;
|
||||
query: string;
|
||||
responseListLength: number;
|
||||
refId: string;
|
||||
scopedVars: ScopedVars;
|
||||
meta?: QueryResultMeta;
|
||||
valueWithRefId?: boolean;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user