From ef5d71711a523efc65da089d45083e28201b58ab Mon Sep 17 00:00:00 2001 From: Giuseppe Guerra Date: Fri, 22 Mar 2024 10:22:36 +0100 Subject: [PATCH] Plugins: Enable feature toggle `enablePluginsTracingByDefault` by default (#84645) * Enable feature flag enablePluginsTracingByDefault by default * re-generate feature toggles --- .../configure-grafana/feature-toggles/index.md | 2 +- pkg/services/featuremgmt/registry.go | 3 ++- pkg/services/featuremgmt/toggles_gen.csv | 2 +- pkg/services/featuremgmt/toggles_gen.json | 9 ++++++--- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 4d6efd2a180..95e68bcb61f 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -55,6 +55,7 @@ Some features are enabled by default. You can disable these feature by setting t | `annotationPermissionUpdate` | Change the way annotation permissions work by scoping them to folders and dashboards. | Yes | | `logRowsPopoverMenu` | Enable filtering menu displayed when text of a log line is selected | Yes | | `lokiQueryHints` | Enables query hints for Loki | Yes | +| `enablePluginsTracingByDefault` | Enable plugin tracing for all external plugins | Yes | | `alertingQueryOptimization` | Optimizes eligible queries in order to reduce load on datasources | | | `betterPageScrolling` | Removes CustomScrollbar from the UI, relying on native browser scrollbars | Yes | @@ -164,7 +165,6 @@ Experimental features might be changed or removed without prior notice. | `pluginsSkipHostEnvVars` | Disables passing host environment variable to plugin processes | | `tableSharedCrosshair` | Enables shared crosshair in table panel | | `kubernetesFeatureToggles` | Use the kubernetes API for feature toggle management in the frontend | -| `enablePluginsTracingByDefault` | Enable plugin tracing for all external plugins | | `newFolderPicker` | Enables the nested folder picker without having nested folders enabled | | `onPremToCloudMigrations` | In-development feature that will allow users to easily migrate their on-prem Grafana instances to Grafana Cloud. | | `promQLScope` | In-development feature that will allow injection of labels into prometheus queries. | diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 8fe26969f27..6a0b1a93614 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -1030,9 +1030,10 @@ var ( Name: "enablePluginsTracingByDefault", Description: "Enable plugin tracing for all external plugins", FrontendOnly: false, - Stage: FeatureStageExperimental, + Stage: FeatureStageGeneralAvailability, Owner: grafanaPluginsPlatformSquad, RequiresRestart: true, + Expression: "true", // enabled by default }, { Name: "cloudRBACRoles", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index 42b236b38b1..e4aab78c534 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -137,7 +137,7 @@ tableSharedCrosshair,experimental,@grafana/dataviz-squad,false,false,true regressionTransformation,preview,@grafana/dataviz-squad,false,false,true lokiQueryHints,GA,@grafana/observability-logs,false,false,true kubernetesFeatureToggles,experimental,@grafana/grafana-operator-experience-squad,false,false,true -enablePluginsTracingByDefault,experimental,@grafana/plugins-platform-backend,false,true,false +enablePluginsTracingByDefault,GA,@grafana/plugins-platform-backend,false,true,false cloudRBACRoles,experimental,@grafana/identity-access-team,false,true,false alertingQueryOptimization,GA,@grafana/alerting-squad,false,false,false newFolderPicker,experimental,@grafana/grafana-frontend-platform,false,false,true diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 6b63ff639fd..cb99c9c6c31 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -973,12 +973,15 @@ { "metadata": { "name": "enablePluginsTracingByDefault", - "resourceVersion": "1709648236447", - "creationTimestamp": "2024-03-05T14:17:16Z" + "resourceVersion": "1710760980171", + "creationTimestamp": "2024-03-05T14:17:16Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-03-18 11:23:00.171105276 +0000 UTC" + } }, "spec": { "description": "Enable plugin tracing for all external plugins", - "stage": "experimental", + "stage": "GA", "codeowner": "@grafana/plugins-platform-backend", "requiresRestart": true }