Service accounts: Grafana service accounts are enabled by default (#51402)

* Remove feature flag for service accounts

* Fix failing tests and remove remaining usage

* Fix failing tests and remove remaining usage

pkg/services/featuremgmt/registry.go

@@ -19,11 +19,6 @@ var (
 			Description: "Disable envelope encryption (emergency only)",
 			State:       FeatureStateStable,
 		},
-		{
-			Name:        "serviceAccounts",
-			Description: "support service accounts",
-			State:       FeatureStateBeta,
-		},
 		{
 			Name:        "database_metrics",
 			Description: "Add prometheus metrics for database tables",

pkg/services/featuremgmt/toggles_gen.go

@@ -15,10 +15,6 @@ const (
 	// Disable envelope encryption (emergency only)
 	FlagDisableEnvelopeEncryption = "disableEnvelopeEncryption"
 
-	// FlagServiceAccounts
-	// support service accounts
-	FlagServiceAccounts = "serviceAccounts"
-
 	// FlagDatabaseMetrics
 	// Add prometheus metrics for database tables
 	FlagDatabaseMetrics = "database_metrics"

pkg/services/featuremgmt/usage_stats_test.go

@@ -11,7 +11,6 @@ func TestFeatureUsageStats(t *testing.T) {
 	featureManagerWithAllFeatures := WithFeatures(
 		"trimDefaults",
 		"httpclientprovider_azure_auth",
-		"serviceAccounts",
 		"database_metrics",
 		"dashboardPreviews",
 		"live-config",
@@ -23,7 +22,6 @@ func TestFeatureUsageStats(t *testing.T) {
 	require.Equal(t, map[string]interface{}{
 		"stats.features.trim_defaults.count":                 1,
 		"stats.features.httpclientprovider_azure_auth.count": 1,
-		"stats.features.service_accounts.count":              1,
 		"stats.features.database_metrics.count":              1,
 		"stats.features.dashboard_previews.count":            1,
 		"stats.features.live_config.count":                   1,