IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Dashboard: Call destroy when panel is removed (#77017)

Browse Source
This commit is contained in:
Greg Tan 2023-11-29 17:53:15 +08:00 committed by GitHub
parent 059ba25973
commit f53839e4fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
public/app/features/dashboard/state/DashboardModel.test.ts
View File

@ -189,6 +189,16 @@ describe('DashboardModel', () => {
expect(dashboard.panels[1].repeat).toBe(undefined); expect(dashboard.panels[1].repeat).toBe(undefined);
expect(dashboard.panels[1].scopedVars).toBe(undefined); expect(dashboard.panels[1].scopedVars).toBe(undefined);
}); });
it('remove panel should call destroy', () => {
dashboard.addPanel({ type: 'test', title: 'test' });
const panel = dashboard.panels[0];
panel.destroy = jest.fn();
dashboard.removePanel(panel);
expect(panel.destroy).toHaveBeenCalled();
});
}); });
describe('Given editable false dashboard', () => { describe('Given editable false dashboard', () => {

1
public/app/features/dashboard/state/DashboardModel.ts
View File

@ -864,6 +864,7 @@ export class DashboardModel implements TimeModel {
removePanel(panel: PanelModel) { removePanel(panel: PanelModel) {
this.panels = this.panels.filter((item) => item !== panel); this.panels = this.panels.filter((item) => item !== panel);
panel.destroy();
this.events.publish(new DashboardPanelsChangedEvent()); this.events.publish(new DashboardPanelsChangedEvent());
} }