From 7f7f080ad883b6c869f2b09887d29e4e5178d91e Mon Sep 17 00:00:00 2001 From: Pavlos Daoglou Date: Tue, 29 Nov 2016 12:24:34 +0200 Subject: [PATCH] [5443] Check if title is empty before save a new dashboard --- pkg/api/dashboard.go | 4 ++++ pkg/models/dashboards.go | 1 + 2 files changed, 5 insertions(+) diff --git a/pkg/api/dashboard.go b/pkg/api/dashboard.go index bff88045cc2..0ed77fe982e 100644 --- a/pkg/api/dashboard.go +++ b/pkg/api/dashboard.go @@ -121,6 +121,10 @@ func PostDashboard(c *middleware.Context, cmd m.SaveDashboardCommand) Response { } dash := cmd.GetDashboardModel() + // Check if Title is empty + if dash.Title == "" { + return ApiError(400, m.ErrDashboardTitleEmpty.Error(), nil) + } if dash.Id == 0 { limitReached, err := middleware.QuotaReached(c, "dashboard") if err != nil { diff --git a/pkg/models/dashboards.go b/pkg/models/dashboards.go index 53ba11c0237..634b26c3f29 100644 --- a/pkg/models/dashboards.go +++ b/pkg/models/dashboards.go @@ -15,6 +15,7 @@ var ( ErrDashboardSnapshotNotFound = errors.New("Dashboard snapshot not found") ErrDashboardWithSameNameExists = errors.New("A dashboard with the same name already exists") ErrDashboardVersionMismatch = errors.New("The dashboard has been changed by someone else") + ErrDashboardTitleEmpty = errors.New("Dashboard title cannot be empty") ) type UpdatePluginDashboardError struct {