IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

singlestat: fix ignoring zero value for table data

Browse Source 
When table data returns a column with the value 0, it should not ignore
it. This change checks for undefined instead of if the value is truthy.

Fixes #8531
This commit is contained in:
Daniel Lee
2017-06-08 11:06:37 +02:00
parent c5d5d7ac5a
commit f7c48c5a5f
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
public/app/plugins/panel/singlestat/module.ts
View File

@@ -165,7 +165,7 @@ class SingleStatCtrl extends MetricsPanelCtrl {
return;
}
if (tableData[0].length === 0 || !tableData[0][0][this.panel.tableColumn]) {
if (tableData[0].length === 0 || tableData[0][0][this.panel.tableColumn] === undefined) {
return;
}

16
public/app/plugins/panel/singlestat/specs/singlestat_specs.ts
View File

@@ -65,7 +65,7 @@ describe('SingleStatCtrl', function() {
expect(ctx.data.valueRounded).to.be(0);
});
it('should set formatted falue', function() {
it('should set formatted value', function() {
expect(ctx.data.valueFormatted).to.be('test.cpu1');
});
});
@@ -82,7 +82,7 @@ describe('SingleStatCtrl', function() {
expect(ctx.data.valueRounded).to.be(100);
});
it('should set formatted falue', function() {
it('should set formatted value', function() {
expect(ctx.data.valueFormatted).to.be('100');
});
});
@@ -254,6 +254,18 @@ describe('SingleStatCtrl', function() {
expect(ctx.data.valueFormatted).to.be('ignore1');
});
});
singleStatScenario('When value is zero', function(ctx) {
ctx.setup(function() {
ctx.data = tableData;
ctx.data[0].rows[0] = [1492759673649, 'ignore1', 0, 'ignore2'];
ctx.ctrl.panel.tableColumn = 'mean';
});
it('Should return zero', function() {
expect(ctx.data.value).to.be(0);
});
});
});
});