From fb114a75241aaef4c08581b42509c750738b768a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Wed, 1 Apr 2020 16:04:46 +0200 Subject: [PATCH] Snapshots: Sanitize orignal url (#23254) --- public/app/features/dashboard/components/DashNav/DashNav.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/public/app/features/dashboard/components/DashNav/DashNav.tsx b/public/app/features/dashboard/components/DashNav/DashNav.tsx index 4bb89fa3b96..ff5a9f76f63 100644 --- a/public/app/features/dashboard/components/DashNav/DashNav.tsx +++ b/public/app/features/dashboard/components/DashNav/DashNav.tsx @@ -17,6 +17,7 @@ import { DashboardModel } from '../../state'; import { CoreEvents, StoreState } from 'app/types'; import { ShareModal } from 'app/features/dashboard/components/ShareModal'; import { SaveDashboardModalProxy } from 'app/features/dashboard/components/SaveDashboard/SaveDashboardModalProxy'; +import { sanitizeUrl } from 'app/core/utils/text'; export interface OwnProps { dashboard: DashboardModel; @@ -134,6 +135,7 @@ export class DashNav extends PureComponent { const { canStar, canSave, canShare, showSettings, isStarred } = dashboard.meta; const { snapshot } = dashboard; const snapshotUrl = snapshot && snapshot.originalUrl; + return (
{isFullscreen && this.renderBackButton()} @@ -222,7 +224,7 @@ export class DashNav extends PureComponent { tooltip="Open original dashboard" classSuffix="snapshot-origin" icon="gicon gicon-link" - href={snapshotUrl} + href={sanitizeUrl(snapshotUrl)} /> )}