Dashboards: Fix minor i18n papercuts that snuck through (#86802)

* fix two issues in dashboards i18n

* import

* fix another

packages/grafana-e2e-selectors/src/selectors/pages.ts

@@ -83,7 +83,7 @@ export const Pages = {
         close: 'data-testid dashboard-settings-close',
       },
       General: {
-        deleteDashBoard: 'Dashboard settings page delete dashboard button',
+        deleteDashBoard: 'data-testid Dashboard settings page delete dashboard button',
         sectionItems: (item: string) => `Dashboard settings section item ${item}`,
         saveDashBoard: 'Dashboard settings aside actions Save button',
         saveAsDashBoard: 'Dashboard settings aside actions Save As button',

public/app/features/dashboard-scene/settings/DeleteDashboardButton.tsx

@@ -1,6 +1,7 @@
 import React from 'react';
 import { useAsyncFn, useToggle } from 'react-use';
 
+import { selectors } from '@grafana/e2e-selectors';
 import { Button, ConfirmModal, Modal } from '@grafana/ui';
 import { Trans } from 'app/core/internationalization';
 
@@ -15,7 +16,11 @@ export function DeleteDashboardButton({ dashboard }: ButtonProps) {
 
   return (
     <>
-      <Button variant="destructive" onClick={toggleModal} aria-label="Dashboard settings page delete dashboard button">
+      <Button
+        variant="destructive"
+        onClick={toggleModal}
+        data-testid={selectors.pages.Dashboard.Settings.General.deleteDashBoard}
+      >
         <Trans i18nKey="dashboard-settings.dashboard-delete-button">Delete dashboard</Trans>
       </Button>
 

public/app/features/dashboard-scene/sharing/ShareLinkTab.tsx

@@ -220,7 +220,7 @@ function ShareLinkTabRenderer({ model }: SceneComponentProps<ShareLinkTab>) {
           bottomSpacing={0}
         >
           <Trans i18nKey="share-modal.link.render-instructions">
-            To render a panel image, you must install the
+            To render a panel image, you must install the{' '}
             <a
               href="https://grafana.com/grafana/plugins/grafana-image-renderer"
               target="_blank"

public/app/features/dashboard/components/DeleteDashboard/DeleteDashboardButton.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
 
+import { selectors } from '@grafana/e2e-selectors';
 import { Button, ModalsController } from '@grafana/ui';
 import { Trans } from 'app/core/internationalization';
 
@@ -20,9 +21,9 @@ export const DeleteDashboardButton = () => {
               hideModal,
             });
           }}
-          aria-label="Dashboard settings page delete dashboard button"
+          data-testid={selectors.pages.Dashboard.Settings.General.deleteDashBoard}
         >
-          <Trans i18nKey="dashboard-settings.dashboard-delete-button">Delete Dashboard</Trans>
+          <Trans i18nKey="dashboard-settings.dashboard-delete-button">Delete dashboard</Trans>
         </Button>
       )}
     </ModalsController>

public/app/features/dashboard/components/ShareModal/ShareLink.tsx

@@ -163,7 +163,7 @@ export class ShareLink extends PureComponent<Props, State> {
             bottomSpacing={0}
           >
             <Trans i18nKey="share-modal.link.render-instructions">
-              To render a panel image, you must install the
+              To render a panel image, you must install the{' '}
               <TextLink href="https://grafana.com/grafana/plugins/grafana-image-renderer" external>
                 Grafana image renderer plugin
               </TextLink>

public/app/features/dashboard/dashgrid/DashboardEmpty.tsx

@@ -138,8 +138,7 @@ const DashboardEmpty = ({ dashboard, canCreate }: Props) => {
                 <Box marginBottom={2}>
                   <Text element="p" textAlignment="center" color="secondary">
                     <Trans i18nKey="dashboard.empty.import-a-dashboard-body">
-                      Import dashboards from files or
-                      <a href="https://grafana.com/grafana/dashboards/">grafana.com</a>.
+                      Import dashboards from files or <a href="https://grafana.com/grafana/dashboards/">grafana.com</a>.
                     </Trans>
                   </Text>
                 </Box>

public/locales/en-US/grafana.json

@@ -276,7 +276,7 @@
       "add-widget-body": "Create lists, markdowns and other widgets",
       "add-widget-button": "Add widget",
       "add-widget-header": "Add a widget",
-      "import-a-dashboard-body": "Import dashboards from files or<1>grafana.com</1>.",
+      "import-a-dashboard-body": "Import dashboards from files or <1>grafana.com</1>.",
       "import-a-dashboard-header": "Import a dashboard",
       "import-dashboard-button": "Import dashboard"
     },
@@ -385,7 +385,7 @@
     "annotations": {
       "title": "Annotations"
     },
-    "dashboard-delete-button": "Delete Dashboard",
+    "dashboard-delete-button": "Delete dashboard",
     "general": {
       "auto-refresh-description": "Define the auto refresh intervals that should be available in the auto refresh list. Use the format '5s' for seconds, '1m' for minutes, '1h' for hours, and '1d' for days (e.g.: '5s,10s,30s,1m,5m,15m,30m,1h,2h,1d').",
       "auto-refresh-label": "Auto refresh",
@@ -1524,7 +1524,7 @@
       "info-text": "Create a direct link to this dashboard or panel, customized with the options below.",
       "link-url": "Link URL",
       "render-alert": "Image renderer plugin not installed",
-      "render-instructions": "To render a panel image, you must install the<1>Grafana image renderer plugin</1>. Please contact your Grafana administrator to install the plugin.",
+      "render-instructions": "To render a panel image, you must install the <2>Grafana image renderer plugin</2>. Please contact your Grafana administrator to install the plugin.",
       "rendered-image": "Direct link rendered image",
       "save-alert": "Dashboard is not saved",
       "save-dashboard": "To render a panel image, you must save the dashboard first.",

public/locales/pseudo-LOCALE/grafana.json

@@ -276,7 +276,7 @@
       "add-widget-body": "Cřęäŧę ľįşŧş, mäřĸđőŵʼnş äʼnđ őŧĥęř ŵįđģęŧş",
       "add-widget-button": "Åđđ ŵįđģęŧ",
       "add-widget-header": "Åđđ ä ŵįđģęŧ",
-      "import-a-dashboard-body": "Ĩmpőřŧ đäşĥþőäřđş ƒřőm ƒįľęş őř<1>ģřäƒäʼnä.čőm</1>.",
+      "import-a-dashboard-body": "Ĩmpőřŧ đäşĥþőäřđş ƒřőm ƒįľęş őř <1>ģřäƒäʼnä.čőm</1>.",
       "import-a-dashboard-header": "Ĩmpőřŧ ä đäşĥþőäřđ",
       "import-dashboard-button": "Ĩmpőřŧ đäşĥþőäřđ"
     },
@@ -385,7 +385,7 @@
     "annotations": {
       "title": "Åʼnʼnőŧäŧįőʼnş"
     },
-    "dashboard-delete-button": "Đęľęŧę Đäşĥþőäřđ",
+    "dashboard-delete-button": "Đęľęŧę đäşĥþőäřđ",
     "general": {
       "auto-refresh-description": "Đęƒįʼnę ŧĥę äūŧő řęƒřęşĥ įʼnŧęřväľş ŧĥäŧ şĥőūľđ þę äväįľäþľę įʼn ŧĥę äūŧő řęƒřęşĥ ľįşŧ. Ůşę ŧĥę ƒőřmäŧ '5ş' ƒőř şęčőʼnđş, '1m' ƒőř mįʼnūŧęş, '1ĥ' ƒőř ĥőūřş, äʼnđ '1đ' ƒőř đäyş (ę.ģ.: '5ş,10ş,30ş,1m,5m,15m,30m,1ĥ,2ĥ,1đ').",
       "auto-refresh-label": "Åūŧő řęƒřęşĥ",
@@ -1524,7 +1524,7 @@
       "info-text": "Cřęäŧę ä đįřęčŧ ľįʼnĸ ŧő ŧĥįş đäşĥþőäřđ őř päʼnęľ, čūşŧőmįžęđ ŵįŧĥ ŧĥę őpŧįőʼnş þęľőŵ.",
       "link-url": "Ŀįʼnĸ ŮŖĿ",
       "render-alert": "Ĩmäģę řęʼnđęřęř pľūģįʼn ʼnőŧ įʼnşŧäľľęđ",
-      "render-instructions": "Ŧő řęʼnđęř ä päʼnęľ įmäģę, yőū mūşŧ įʼnşŧäľľ ŧĥę<1>Ğřäƒäʼnä įmäģę řęʼnđęřęř pľūģįʼn</1>. Pľęäşę čőʼnŧäčŧ yőūř Ğřäƒäʼnä äđmįʼnįşŧřäŧőř ŧő įʼnşŧäľľ ŧĥę pľūģįʼn.",
+      "render-instructions": "Ŧő řęʼnđęř ä päʼnęľ įmäģę, yőū mūşŧ įʼnşŧäľľ ŧĥę <2>Ğřäƒäʼnä įmäģę řęʼnđęřęř pľūģįʼn</2>. Pľęäşę čőʼnŧäčŧ yőūř Ğřäƒäʼnä äđmįʼnįşŧřäŧőř ŧő įʼnşŧäľľ ŧĥę pľūģįʼn.",
       "rendered-image": "Đįřęčŧ ľįʼnĸ řęʼnđęřęđ įmäģę",
       "save-alert": "Đäşĥþőäřđ įş ʼnőŧ şävęđ",
       "save-dashboard": "Ŧő řęʼnđęř ä päʼnęľ įmäģę, yőū mūşŧ şävę ŧĥę đäşĥþőäřđ ƒįřşŧ.",