IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix deleting prom rules endpoints via ds_proxy (#33491)

Browse Source
This commit is contained in:
Sofia Papagiannaki 2021-04-29 10:20:51 +03:00 committed by GitHub
parent e977085933
commit fcd674ec58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/api/pluginproxy/ds_proxy.go
View File

@ -290,6 +290,9 @@ func (proxy *DataSourceProxy) validateRequest() error {
if proxy.ctx.Req.Request.Method == "PUT" { if proxy.ctx.Req.Request.Method == "PUT" {
return errors.New("non allow-listed PUTs not allowed on proxied Prometheus datasource") return errors.New("non allow-listed PUTs not allowed on proxied Prometheus datasource")
} }
if proxy.ctx.Req.Request.Method == "POST" {
return errors.New("non allow-listed POSTs not allowed on proxied Prometheus datasource")
}
} }
return nil return nil

6
public/app/plugins/datasource/prometheus/plugin.json
View File

@ -31,17 +31,17 @@
}, },
{ {
"method": "GET", "method": "GET",
"path": "api/v1/rules", "path": "/rules",
"reqRole": "Viewer" "reqRole": "Viewer"
}, },
{ {
"method": "POST", "method": "POST",
"path": "api/v1/rules", "path": "/rules",
"reqRole": "Editor" "reqRole": "Editor"
}, },
{ {
"method": "DELETE", "method": "DELETE",
"path": "api/v1/rules", "path": "/rules",
"reqRole": "Editor" "reqRole": "Editor"
} }
], ],