IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Dashboard: Fixes random scrolling on time range change (#50379)

Browse Source 
* Dashboard: Fixes random scrolling on time range change

* fix ts issue

* removed logging
This commit is contained in:
Torkel Ödegaard 2022-06-08 10:34:44 +02:00 committed by GitHub
parent 8bd56b8226
commit fd408652dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/grafana-ui/src/components/CustomScrollbar/CustomScrollbar.tsx
View File

@ -1,6 +1,5 @@
import { css } from '@emotion/css';
import classNames from 'classnames';
import { isNil } from 'lodash';
import React, { FC, RefCallback, useCallback, useEffect, useRef } from 'react';
import Scrollbars, { positionValues } from 'react-custom-scrollbars-2';
@ -46,28 +45,24 @@ export const CustomScrollbar: FC<Props> = ({
children,
}) => {
const ref = useRef<Scrollbars & { view: HTMLDivElement }>(null);
useEffect(() => {
if (ref.current) {
scrollRefCallback?.(ref.current.view);
}
}, [ref, scrollRefCallback]);
const styles = useStyles2(getStyles);
const updateScroll = () => {
if (ref.current && !isNil(scrollTop)) {
ref.current.scrollTop(scrollTop);
useEffect(() => {
if (ref.current && scrollRefCallback) {
scrollRefCallback(ref.current.view);
}
};
}, [ref, scrollRefCallback]);
useEffect(() => {
updateScroll();
});
if (ref.current && scrollTop != null) {
ref.current.scrollTop(scrollTop);
}
}, [scrollTop]);
/**
* Special logic for doing a update a few milliseconds after mount to check for
* updated height due to dynamic content
*/
useEffect(() => {
if (!updateAfterMountMs) {
return;