IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Fix typescript strict null fixes now at 298 (#26125)

Browse Source 
* Chore: Fix typescript strict null errors

* Added new limit

* Fixed ts issue

* fixed tests

* trying to fix type inference

* Fixing more ts errors

* Revert tsconfig option

* Fix

* Fixed code

* More fixes

* fix tests

* Updated snapshot

* Chore: More ts strict null fixes

* More fixes in some really messed up azure config components

* More fixes, current count: 441

* 419

* More fixes

* Fixed invalid initial state in explore

* Fixing tests

* Fixed tests

* Explore fix

* More fixes

* Progress

* Sub 300

* Fixed incorrect type

* removed unused import
This commit is contained in:
Torkel Ödegaard
2020-07-08 11:05:20 +02:00
committed by GitHub
parent 89b56782c6
commit fd44c01675
103 changed files with 386 additions and 331 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
public/app/plugins/datasource/dashboard/DashboardQueryEditor.tsx
View File

@@ -52,7 +52,7 @@ export class DashboardQueryEditor extends PureComponent<Props, State> {
}
async componentDidMount() {
this.componentDidUpdate(null);
this.componentDidUpdate(this.props);
}
async componentDidUpdate(prevProps: Props) {
@@ -60,9 +60,9 @@ export class DashboardQueryEditor extends PureComponent<Props, State> {
if (!prevProps || prevProps.panelData !== panelData) {
const query = this.props.panel.targets[0] as DashboardQuery;
const defaultDS = await getDatasourceSrv().get(null);
const defaultDS = await getDatasourceSrv().get();
const dashboard = getDashboardSrv().getCurrent();
const panel = dashboard.getPanelById(query.panelId);
const panel = dashboard.getPanelById(query.panelId ?? -124134);
if (!panel) {
this.setState({ defaultDatasource: defaultDS.name });
@@ -143,7 +143,7 @@ export class DashboardQueryEditor extends PureComponent<Props, State> {
const dashboard = getDashboardSrv().getCurrent();
const query = this.getQuery();
let selected: SelectableValue<number>;
let selected: SelectableValue<number> | undefined;
const panels: Array<SelectableValue<number>> = [];
for (const panel of dashboard.panels) {
@@ -188,7 +188,7 @@ export class DashboardQueryEditor extends PureComponent<Props, State> {
isSearchable={true}
options={panels}
value={selected}
onChange={item => this.onPanelChanged(item.value)}
onChange={item => this.onPanelChanged(item.value!)}
/>
</div>
<div className={css({ padding: '16px' })}>{query.panelId && this.renderQueryData(editURL)}</div>