Explore: Use SeriesData format for loki/logs (#16793)

This is the first step moving towards Explore supporting logs for 
more datasources than Loki. In the first step we move all the log 
processing from Loki into Explore.
- Make explore convert logs result returned from datasources to SeriesData, 
if needed, and for now convert SeriesData to LogsModel.
- Loki datasource query now returns SeriesData and all
processing have been moved into explore instead.
- Removed key from LogRowModel and use log row indexes as 
the unique key instead.
- Removed id from LogsModel since it looks like it's not in use.
- Introduced a new class FieldCache which is convenient to use when
looking up multiple fields and/or field types and series values.

Closes #16287

packages/grafana-ui/src/types/data.ts

@@ -19,6 +19,12 @@ export interface QueryResultMeta {
 
   // Match the result to the query
   requestId?: string;
+
+  // Used in Explore for highlighting
+  search?: string;
+
+  // Used in Explore to show limit applied to search result
+  limit?: number;
 }
 
 export interface QueryResultBase {

packages/grafana-ui/src/utils/fieldCache.test.ts

@@ -0,0 +1,71 @@
+import { FieldType } from '../types/index';
+import { FieldCache } from './fieldCache';
+
+describe('FieldCache', () => {
+  it('when creating a new FieldCache from fields should be able to query cache', () => {
+    const fields = [
+      { name: 'time', type: FieldType.time },
+      { name: 'string', type: FieldType.string },
+      { name: 'number', type: FieldType.number },
+      { name: 'boolean', type: FieldType.boolean },
+      { name: 'other', type: FieldType.other },
+      { name: 'undefined' },
+    ];
+    const fieldCache = new FieldCache(fields);
+    const allFields = fieldCache.getFields();
+    expect(allFields).toHaveLength(6);
+
+    const expectedFields = [
+      { ...fields[0], index: 0 },
+      { ...fields[1], index: 1 },
+      { ...fields[2], index: 2 },
+      { ...fields[3], index: 3 },
+      { ...fields[4], index: 4 },
+      { ...fields[5], type: FieldType.other, index: 5 },
+    ];
+
+    expect(allFields).toMatchObject(expectedFields);
+
+    expect(fieldCache.hasFieldOfType(FieldType.time)).toBeTruthy();
+    expect(fieldCache.hasFieldOfType(FieldType.string)).toBeTruthy();
+    expect(fieldCache.hasFieldOfType(FieldType.number)).toBeTruthy();
+    expect(fieldCache.hasFieldOfType(FieldType.boolean)).toBeTruthy();
+    expect(fieldCache.hasFieldOfType(FieldType.other)).toBeTruthy();
+
+    expect(fieldCache.getFields(FieldType.time)).toMatchObject([expectedFields[0]]);
+    expect(fieldCache.getFields(FieldType.string)).toMatchObject([expectedFields[1]]);
+    expect(fieldCache.getFields(FieldType.number)).toMatchObject([expectedFields[2]]);
+    expect(fieldCache.getFields(FieldType.boolean)).toMatchObject([expectedFields[3]]);
+    expect(fieldCache.getFields(FieldType.other)).toMatchObject([expectedFields[4], expectedFields[5]]);
+
+    expect(fieldCache.getFieldByIndex(0)).toMatchObject(expectedFields[0]);
+    expect(fieldCache.getFieldByIndex(1)).toMatchObject(expectedFields[1]);
+    expect(fieldCache.getFieldByIndex(2)).toMatchObject(expectedFields[2]);
+    expect(fieldCache.getFieldByIndex(3)).toMatchObject(expectedFields[3]);
+    expect(fieldCache.getFieldByIndex(4)).toMatchObject(expectedFields[4]);
+    expect(fieldCache.getFieldByIndex(5)).toMatchObject(expectedFields[5]);
+    expect(fieldCache.getFieldByIndex(6)).toBeNull();
+
+    expect(fieldCache.getFirstFieldOfType(FieldType.time)).toMatchObject(expectedFields[0]);
+    expect(fieldCache.getFirstFieldOfType(FieldType.string)).toMatchObject(expectedFields[1]);
+    expect(fieldCache.getFirstFieldOfType(FieldType.number)).toMatchObject(expectedFields[2]);
+    expect(fieldCache.getFirstFieldOfType(FieldType.boolean)).toMatchObject(expectedFields[3]);
+    expect(fieldCache.getFirstFieldOfType(FieldType.other)).toMatchObject(expectedFields[4]);
+
+    expect(fieldCache.hasFieldNamed('tim')).toBeFalsy();
+    expect(fieldCache.hasFieldNamed('time')).toBeTruthy();
+    expect(fieldCache.hasFieldNamed('string')).toBeTruthy();
+    expect(fieldCache.hasFieldNamed('number')).toBeTruthy();
+    expect(fieldCache.hasFieldNamed('boolean')).toBeTruthy();
+    expect(fieldCache.hasFieldNamed('other')).toBeTruthy();
+    expect(fieldCache.hasFieldNamed('undefined')).toBeTruthy();
+
+    expect(fieldCache.getFieldByName('time')).toMatchObject(expectedFields[0]);
+    expect(fieldCache.getFieldByName('string')).toMatchObject(expectedFields[1]);
+    expect(fieldCache.getFieldByName('number')).toMatchObject(expectedFields[2]);
+    expect(fieldCache.getFieldByName('boolean')).toMatchObject(expectedFields[3]);
+    expect(fieldCache.getFieldByName('other')).toMatchObject(expectedFields[4]);
+    expect(fieldCache.getFieldByName('undefined')).toMatchObject(expectedFields[5]);
+    expect(fieldCache.getFieldByName('null')).toBeNull();
+  });
+});

packages/grafana-ui/src/utils/fieldCache.ts

@@ -0,0 +1,76 @@
+import { Field, FieldType } from '../types/index';
+
+export interface IndexedField extends Field {
+  index: number;
+}
+
+export class FieldCache {
+  private fields: Field[];
+  private fieldIndexByName: { [key: string]: number };
+  private fieldIndexByType: { [key: string]: number[] };
+
+  constructor(fields?: Field[]) {
+    this.fields = [];
+    this.fieldIndexByName = {};
+    this.fieldIndexByType = {};
+    this.fieldIndexByType[FieldType.time] = [];
+    this.fieldIndexByType[FieldType.string] = [];
+    this.fieldIndexByType[FieldType.number] = [];
+    this.fieldIndexByType[FieldType.boolean] = [];
+    this.fieldIndexByType[FieldType.other] = [];
+
+    if (fields) {
+      for (let n = 0; n < fields.length; n++) {
+        const field = fields[n];
+        this.addField(field);
+      }
+    }
+  }
+
+  addField(field: Field) {
+    this.fields.push({
+      type: FieldType.other,
+      ...field,
+    });
+    const index = this.fields.length - 1;
+    this.fieldIndexByName[field.name] = index;
+    this.fieldIndexByType[field.type || FieldType.other].push(index);
+  }
+
+  hasFieldOfType(type: FieldType): boolean {
+    return this.fieldIndexByType[type] && this.fieldIndexByType[type].length > 0;
+  }
+
+  getFields(type?: FieldType): IndexedField[] {
+    const fields: IndexedField[] = [];
+    for (let index = 0; index < this.fields.length; index++) {
+      const field = this.fields[index];
+
+      if (!type || field.type === type) {
+        fields.push({ ...field, index });
+      }
+    }
+
+    return fields;
+  }
+
+  getFieldByIndex(index: number): IndexedField | null {
+    return this.fields[index] ? { ...this.fields[index], index } : null;
+  }
+
+  getFirstFieldOfType(type: FieldType): IndexedField | null {
+    return this.hasFieldOfType(type)
+      ? { ...this.fields[this.fieldIndexByType[type][0]], index: this.fieldIndexByType[type][0] }
+      : null;
+  }
+
+  hasFieldNamed(name: string): boolean {
+    return this.fieldIndexByName[name] !== undefined;
+  }
+
+  getFieldByName(name: string): IndexedField | null {
+    return this.hasFieldNamed(name)
+      ? { ...this.fields[this.fieldIndexByName[name]], index: this.fieldIndexByName[name] }
+      : null;
+  }
+}

packages/grafana-ui/src/utils/index.ts

@@ -14,3 +14,4 @@ export { getMappedValue } from './valueMappings';
 export * from './validate';
 export { getFlotPairs } from './flotPairs';
 export * from './object';
+export * from './fieldCache';

packages/grafana-ui/src/utils/processSeriesData.ts

@@ -43,16 +43,6 @@ function convertTimeSeriesToSeriesData(timeSeries: TimeSeries): SeriesData {
   };
 }
 
-export const getFirstTimeField = (series: SeriesData): number => {
-  const { fields } = series;
-  for (let i = 0; i < fields.length; i++) {
-    if (fields[i].type === FieldType.time) {
-      return i;
-    }
-  }
-  return -1;
-};
-
 // PapaParse Dynamic Typing regex:
 // https://github.com/mholt/PapaParse/blob/master/papaparse.js#L998
 const NUMBER = /^\s*-?(\d*\.?\d+|\d+\.?\d*)(e[-+]?\d+)?\s*$/i;

public/app/core/logs_model.ts

@@ -1,7 +1,22 @@
 import _ from 'lodash';
+import moment from 'moment';
+import ansicolor from 'vendor/ansicolor/ansicolor';
 
-import { colors, TimeSeries, Labels, LogLevel } from '@grafana/ui';
+import {
+  colors,
+  TimeSeries,
+  Labels,
+  LogLevel,
+  SeriesData,
+  findCommonLabels,
+  findUniqueLabels,
+  getLogLevel,
+  toLegacyResponseData,
+  FieldCache,
+  FieldType,
+} from '@grafana/ui';
 import { getThemeColor } from 'app/core/utils/colors';
+import { hasAnsiCodes } from 'app/core/utils/text';
 
 export const LogLevelColor = {
   [LogLevel.critical]: colors[7],
@@ -23,7 +38,6 @@ export interface LogRowModel {
   duplicates?: number;
   entry: string;
   hasAnsi: boolean;
-  key: string; // timestamp + labels
   labels: Labels;
   logLevel: LogLevel;
   raw: string;
@@ -56,27 +70,11 @@ export interface LogsMetaItem {
 
 export interface LogsModel {
   hasUniqueLabels: boolean;
-  id: string; // Identify one logs result from another
   meta?: LogsMetaItem[];
   rows: LogRowModel[];
   series?: TimeSeries[];
 }
 
-export interface LogsStream {
-  labels: string;
-  entries: LogsStreamEntry[];
-  search?: string;
-  parsedLabels?: Labels;
-  uniqueLabels?: Labels;
-}
-
-export interface LogsStreamEntry {
-  line: string;
-  ts: string;
-  // Legacy, was renamed to ts
-  timestamp?: string;
-}
-
 export enum LogsDedupDescription {
   none = 'No de-duplication',
   exact = 'De-duplication of successive lines that are identical, ignoring ISO datetimes.',
@@ -326,3 +324,136 @@ export function makeSeriesForLogs(rows: LogRowModel[], intervalMs: number): Time
     };
   });
 }
+
+function isLogsData(series: SeriesData) {
+  return series.fields.some(f => f.type === FieldType.time) && series.fields.some(f => f.type === FieldType.string);
+}
+
+export function seriesDataToLogsModel(seriesData: SeriesData[], intervalMs: number): LogsModel {
+  const metricSeries: SeriesData[] = [];
+  const logSeries: SeriesData[] = [];
+
+  for (const series of seriesData) {
+    if (isLogsData(series)) {
+      logSeries.push(series);
+      continue;
+    }
+
+    metricSeries.push(series);
+  }
+
+  const logsModel = logSeriesToLogsModel(logSeries);
+  if (logsModel) {
+    if (metricSeries.length === 0) {
+      logsModel.series = makeSeriesForLogs(logsModel.rows, intervalMs);
+    } else {
+      logsModel.series = [];
+      for (const series of metricSeries) {
+        logsModel.series.push(toLegacyResponseData(series) as TimeSeries);
+      }
+    }
+
+    return logsModel;
+  }
+
+  return undefined;
+}
+
+export function logSeriesToLogsModel(logSeries: SeriesData[]): LogsModel {
+  if (logSeries.length === 0) {
+    return undefined;
+  }
+
+  const allLabels: Labels[] = [];
+  for (let n = 0; n < logSeries.length; n++) {
+    const series = logSeries[n];
+    if (series.labels) {
+      allLabels.push(series.labels);
+    }
+  }
+
+  let commonLabels: Labels = {};
+  if (allLabels.length > 0) {
+    commonLabels = findCommonLabels(allLabels);
+  }
+
+  const rows: LogRowModel[] = [];
+  let hasUniqueLabels = false;
+
+  for (let i = 0; i < logSeries.length; i++) {
+    const series = logSeries[i];
+    const fieldCache = new FieldCache(series.fields);
+    const uniqueLabels = findUniqueLabels(series.labels, commonLabels);
+    if (Object.keys(uniqueLabels).length > 0) {
+      hasUniqueLabels = true;
+    }
+
+    for (let j = 0; j < series.rows.length; j++) {
+      rows.push(processLogSeriesRow(series, fieldCache, j, uniqueLabels));
+    }
+  }
+
+  const sortedRows = rows.sort((a, b) => {
+    return a.timestamp > b.timestamp ? -1 : 1;
+  });
+
+  // Meta data to display in status
+  const meta: LogsMetaItem[] = [];
+  if (_.size(commonLabels) > 0) {
+    meta.push({
+      label: 'Common labels',
+      value: commonLabels,
+      kind: LogsMetaKind.LabelsMap,
+    });
+  }
+
+  const limits = logSeries.filter(series => series.meta && series.meta.limit);
+
+  if (limits.length > 0) {
+    meta.push({
+      label: 'Limit',
+      value: `${limits[0].meta.limit} (${sortedRows.length} returned)`,
+      kind: LogsMetaKind.String,
+    });
+  }
+
+  return {
+    hasUniqueLabels,
+    meta,
+    rows: sortedRows,
+  };
+}
+
+export function processLogSeriesRow(
+  series: SeriesData,
+  fieldCache: FieldCache,
+  rowIndex: number,
+  uniqueLabels: Labels
+): LogRowModel {
+  const row = series.rows[rowIndex];
+  const timeFieldIndex = fieldCache.getFirstFieldOfType(FieldType.time).index;
+  const ts = row[timeFieldIndex];
+  const stringFieldIndex = fieldCache.getFirstFieldOfType(FieldType.string).index;
+  const message = row[stringFieldIndex];
+  const time = moment(ts);
+  const timeEpochMs = time.valueOf();
+  const timeFromNow = time.fromNow();
+  const timeLocal = time.format('YYYY-MM-DD HH:mm:ss');
+  const logLevel = getLogLevel(message);
+  const hasAnsi = hasAnsiCodes(message);
+  const search = series.meta && series.meta.search ? series.meta.search : '';
+
+  return {
+    logLevel,
+    timeFromNow,
+    timeEpochMs,
+    timeLocal,
+    uniqueLabels,
+    hasAnsi,
+    entry: hasAnsi ? ansicolor.strip(message) : message,
+    raw: message,
+    labels: series.labels,
+    searchWords: search ? [search] : [],
+    timestamp: ts,
+  };
+}

public/app/core/specs/logs_model.test.ts

@@ -6,7 +6,10 @@ import {
   LogsDedupStrategy,
   LogsModel,
   LogsParsers,
+  seriesDataToLogsModel,
+  LogsMetaKind,
 } from '../logs_model';
+import { SeriesData, FieldType } from '@grafana/ui';
 
 describe('dedupLogRows()', () => {
   test('should return rows as is when dedup is set to none', () => {
@@ -329,3 +332,216 @@ describe('LogsParsers', () => {
     });
   });
 });
+
+describe('seriesDataToLogsModel', () => {
+  it('given empty series should return undefined', () => {
+    expect(seriesDataToLogsModel([] as SeriesData[], 0)).toBeUndefined();
+  });
+
+  it('given series without correct series name should not be processed', () => {
+    const series: SeriesData[] = [
+      {
+        fields: [],
+        rows: [],
+      },
+    ];
+    expect(seriesDataToLogsModel(series, 0)).toBeUndefined();
+  });
+
+  it('given series without a time field should not be processed', () => {
+    const series: SeriesData[] = [
+      {
+        fields: [
+          {
+            name: 'message',
+            type: FieldType.string,
+          },
+        ],
+        rows: [],
+      },
+    ];
+    expect(seriesDataToLogsModel(series, 0)).toBeUndefined();
+  });
+
+  it('given series without a string field should not be processed', () => {
+    const series: SeriesData[] = [
+      {
+        fields: [
+          {
+            name: 'time',
+            type: FieldType.time,
+          },
+        ],
+        rows: [],
+      },
+    ];
+    expect(seriesDataToLogsModel(series, 0)).toBeUndefined();
+  });
+
+  it('given one series should return expected logs model', () => {
+    const series: SeriesData[] = [
+      {
+        labels: {
+          filename: '/var/log/grafana/grafana.log',
+          job: 'grafana',
+        },
+        fields: [
+          {
+            name: 'time',
+            type: FieldType.time,
+          },
+          {
+            name: 'message',
+            type: FieldType.string,
+          },
+        ],
+        rows: [
+          [
+            '2019-04-26T09:28:11.352440161Z',
+            't=2019-04-26T11:05:28+0200 lvl=info msg="Initializing DatasourceCacheService" logger=server',
+          ],
+          [
+            '2019-04-26T14:42:50.991981292Z',
+            't=2019-04-26T16:42:50+0200 lvl=eror msg="new token…t unhashed token=56d9fdc5c8b7400bd51b060eea8ca9d7',
+          ],
+        ],
+        meta: {
+          limit: 1000,
+        },
+      },
+    ];
+    const logsModel = seriesDataToLogsModel(series, 0);
+    expect(logsModel.hasUniqueLabels).toBeFalsy();
+    expect(logsModel.rows).toHaveLength(2);
+    expect(logsModel.rows).toMatchObject([
+      {
+        timestamp: '2019-04-26T14:42:50.991981292Z',
+        entry: 't=2019-04-26T16:42:50+0200 lvl=eror msg="new token…t unhashed token=56d9fdc5c8b7400bd51b060eea8ca9d7',
+        labels: { filename: '/var/log/grafana/grafana.log', job: 'grafana' },
+        logLevel: 'error',
+        uniqueLabels: {},
+      },
+      {
+        timestamp: '2019-04-26T09:28:11.352440161Z',
+        entry: 't=2019-04-26T11:05:28+0200 lvl=info msg="Initializing DatasourceCacheService" logger=server',
+        labels: { filename: '/var/log/grafana/grafana.log', job: 'grafana' },
+        logLevel: 'info',
+        uniqueLabels: {},
+      },
+    ]);
+
+    expect(logsModel.series).toHaveLength(2);
+    expect(logsModel.meta).toHaveLength(2);
+    expect(logsModel.meta[0]).toMatchObject({
+      label: 'Common labels',
+      value: series[0].labels,
+      kind: LogsMetaKind.LabelsMap,
+    });
+    expect(logsModel.meta[1]).toMatchObject({
+      label: 'Limit',
+      value: `1000 (2 returned)`,
+      kind: LogsMetaKind.String,
+    });
+  });
+
+  it('given one series without labels should return expected logs model', () => {
+    const series: SeriesData[] = [
+      {
+        fields: [
+          {
+            name: 'time',
+            type: FieldType.time,
+          },
+          {
+            name: 'message',
+            type: FieldType.string,
+          },
+        ],
+        rows: [['1970-01-01T00:00:01Z', 'WARN boooo']],
+      },
+    ];
+    const logsModel = seriesDataToLogsModel(series, 0);
+    expect(logsModel.rows).toHaveLength(1);
+    expect(logsModel.rows).toMatchObject([
+      {
+        entry: 'WARN boooo',
+        labels: undefined,
+        logLevel: 'warning',
+        uniqueLabels: {},
+      },
+    ]);
+  });
+
+  it('given multiple series should return expected logs model', () => {
+    const series: SeriesData[] = [
+      {
+        labels: {
+          foo: 'bar',
+          baz: '1',
+        },
+        fields: [
+          {
+            name: 'ts',
+            type: FieldType.time,
+          },
+          {
+            name: 'line',
+            type: FieldType.string,
+          },
+        ],
+        rows: [['1970-01-01T00:00:01Z', 'WARN boooo']],
+      },
+      {
+        name: 'logs',
+        labels: {
+          foo: 'bar',
+          baz: '2',
+        },
+        fields: [
+          {
+            name: 'time',
+            type: FieldType.time,
+          },
+          {
+            name: 'message',
+            type: FieldType.string,
+          },
+        ],
+        rows: [['1970-01-01T00:00:00Z', 'INFO 1'], ['1970-01-01T00:00:02Z', 'INFO 2']],
+      },
+    ];
+    const logsModel = seriesDataToLogsModel(series, 0);
+    expect(logsModel.hasUniqueLabels).toBeTruthy();
+    expect(logsModel.rows).toHaveLength(3);
+    expect(logsModel.rows).toMatchObject([
+      {
+        entry: 'INFO 2',
+        labels: { foo: 'bar', baz: '2' },
+        logLevel: 'info',
+        uniqueLabels: { baz: '2' },
+      },
+      {
+        entry: 'WARN boooo',
+        labels: { foo: 'bar', baz: '1' },
+        logLevel: 'warning',
+        uniqueLabels: { baz: '1' },
+      },
+      {
+        entry: 'INFO 1',
+        labels: { foo: 'bar', baz: '2' },
+        logLevel: 'info',
+        uniqueLabels: { baz: '2' },
+      },
+    ]);
+
+    expect(logsModel.series).toHaveLength(2);
+    expect(logsModel.meta).toHaveLength(1);
+    expect(logsModel.meta[0]).toMatchObject({
+      label: 'Common labels',
+      value: {
+        foo: 'bar',
+      },
+      kind: LogsMetaKind.LabelsMap,
+    });
+  });
+});

public/app/core/utils/explore.ts

@@ -11,7 +11,17 @@ import TableModel, { mergeTablesIntoModel } from 'app/core/table_model';
 import { getNextRefIdChar } from './query';
 
 // Types
-import { colors, TimeRange, RawTimeRange, TimeZone, IntervalValues, DataQuery, DataSourceApi } from '@grafana/ui';
+import {
+  colors,
+  TimeRange,
+  RawTimeRange,
+  TimeZone,
+  IntervalValues,
+  DataQuery,
+  DataSourceApi,
+  toSeriesData,
+  guessFieldTypes,
+} from '@grafana/ui';
 import TimeSeries from 'app/core/time_series2';
 import {
   ExploreUrlState,
@@ -22,7 +32,7 @@ import {
   QueryOptions,
   ResultGetter,
 } from 'app/types/explore';
-import { LogsDedupStrategy } from 'app/core/logs_model';
+import { LogsDedupStrategy, seriesDataToLogsModel } from 'app/core/logs_model';
 
 export const DEFAULT_RANGE = {
   from: 'now-6h',
@@ -293,15 +303,12 @@ export function calculateResultsFromQueryTransactions(
       .filter(qt => qt.resultType === 'Table' && qt.done && qt.result && qt.result.columns && qt.result.rows)
       .map(qt => qt.result)
   );
-  const logsResult =
+  const logsResult = seriesDataToLogsModel(
-    datasource && datasource.mergeStreams
-      ? datasource.mergeStreams(
     _.flatten(
       queryTransactions.filter(qt => qt.resultType === 'Logs' && qt.done && qt.result).map(qt => qt.result)
-          ),
+    ).map(r => guessFieldTypes(toSeriesData(r))),
     graphInterval
-        )
+  );
-      : undefined;
 
   return {
     graphResult,

public/app/features/explore/Logs.tsx

@@ -248,9 +248,9 @@ export default class Logs extends PureComponent<Props, State> {
         <div className="logs-rows">
           {hasData &&
           !deferLogs && // Only inject highlighterExpression in the first set for performance reasons
-            firstRows.map(row => (
+            firstRows.map((row, index) => (
               <LogRow
-                key={row.key + row.duplicates}
+                key={index}
                 getRows={getRows}
                 highlighterExpressions={highlighterExpressions}
                 row={row}
@@ -264,9 +264,9 @@ export default class Logs extends PureComponent<Props, State> {
           {hasData &&
             !deferLogs &&
             renderAll &&
-            lastRows.map(row => (
+            lastRows.map((row, index) => (
               <LogRow
-                key={row.key + row.duplicates}
+                key={PREVIEW_LIMIT + index}
                 getRows={getRows}
                 row={row}
                 showDuplicates={showDuplicates}

public/app/features/explore/LogsContainer.tsx

@@ -81,7 +81,6 @@ export class LogsContainer extends PureComponent<LogsContainerProps> {
           data={logsResult}
           dedupedData={dedupedResult}
           exploreId={exploreId}
-          key={logsResult && logsResult.id}
           highlighterExpressions={logsHighlighterExpressions}
           loading={loading}
           onChangeTime={onChangeTime}

public/app/plugins/datasource/loki/datasource.test.ts

@@ -1,6 +1,7 @@
 import LokiDatasource from './datasource';
 import { LokiQuery } from './types';
 import { getQueryOptions } from 'test/helpers/getQueryOptions';
+import { SeriesData } from '@grafana/ui';
 
 describe('LokiDatasource', () => {
   const instanceSettings: any = {
@@ -50,8 +51,10 @@ describe('LokiDatasource', () => {
       expect(backendSrvMock.datasourceRequest.mock.calls[0][0].url).toContain('limit=20');
     });
 
-    test('should return log streams when resultFormat is undefined', async done => {
+    test('should return series data', async done => {
-      const ds = new LokiDatasource(instanceSettings, backendSrvMock, templateSrvMock);
+      const customData = { ...(instanceSettings.jsonData || {}), maxLines: 20 };
+      const customSettings = { ...instanceSettings, jsonData: customData };
+      const ds = new LokiDatasource(customSettings, backendSrvMock, templateSrvMock);
       backendSrvMock.datasourceRequest = jest.fn(() => Promise.resolve(testResp));
 
       const options = getQueryOptions<LokiQuery>({
@@ -60,21 +63,10 @@ describe('LokiDatasource', () => {
 
       const res = await ds.query(options);
 
-      expect(res.data[0].entries[0].line).toBe('hello');
+      const seriesData = res.data[0] as SeriesData;
-      done();
+      expect(seriesData.rows[0][1]).toBe('hello');
-    });
+      expect(seriesData.meta.limit).toBe(20);
-
+      expect(seriesData.meta.search).toBe('(?i)foo');
-    test('should return time series when resultFormat is time_series', async done => {
-      const ds = new LokiDatasource(instanceSettings, backendSrvMock, templateSrvMock);
-      backendSrvMock.datasourceRequest = jest.fn(() => Promise.resolve(testResp));
-
-      const options = getQueryOptions<LokiQuery>({
-        targets: [{ expr: 'foo', refId: 'B', resultFormat: 'time_series' }],
-      });
-
-      const res = await ds.query(options);
-
-      expect(res.data[0].datapoints).toBeDefined();
       done();
     });
   });

public/app/plugins/datasource/loki/datasource.ts

@@ -5,13 +5,11 @@ import _ from 'lodash';
 import * as dateMath from 'app/core/utils/datemath';
 import { addLabelToSelector } from 'app/plugins/datasource/prometheus/add_label_to_query';
 import LanguageProvider from './language_provider';
-import { mergeStreamsToLogs } from './result_transformer';
+import { logStreamToSeriesData } from './result_transformer';
 import { formatQuery, parseQuery } from './query_utils';
-import { makeSeriesForLogs } from 'app/core/logs_model';
 
 // Types
-import { LogsStream, LogsModel } from 'app/core/logs_model';
+import { PluginMeta, DataQueryRequest, SeriesData } from '@grafana/ui/src/types';
-import { PluginMeta, DataQueryRequest } from '@grafana/ui/src/types';
 import { LokiQuery } from './types';
 
 export const DEFAULT_MAX_LINES = 1000;
@@ -54,12 +52,6 @@ export class LokiDatasource {
     return this.backendSrv.datasourceRequest(req);
   }
 
-  mergeStreams(streams: LogsStream[], intervalMs: number): LogsModel {
-    const logs = mergeStreamsToLogs(streams, this.maxLines);
-    logs.series = makeSeriesForLogs(logs.rows, intervalMs);
-    return logs;
-  }
-
   prepareQueryTarget(target, options) {
     const interpolated = this.templateSrv.replace(target.expr);
     const start = this.getTime(options.range.from, false);
@@ -85,29 +77,23 @@ export class LokiDatasource {
     const queries = queryTargets.map(target => this._request('/api/prom/query', target));
 
     return Promise.all(queries).then((results: any[]) => {
-      const allStreams: LogsStream[] = [];
+      const series: SeriesData[] = [];
 
       for (let i = 0; i < results.length; i++) {
         const result = results[i];
-        const query = queryTargets[i];
-
-        // add search term to stream & add to array
         if (result.data) {
           for (const stream of result.data.streams || []) {
-            stream.search = query.regexp;
+            const seriesData = logStreamToSeriesData(stream);
-            allStreams.push(stream);
+            seriesData.meta = {
+              search: queryTargets[i].regexp,
+              limit: this.maxLines,
+            };
+            series.push(seriesData);
           }
         }
       }
 
-      // check resultType
+      return { data: series };
-      if (options.targets[0].resultFormat === 'time_series') {
-        const logs = mergeStreamsToLogs(allStreams, this.maxLines);
-        logs.series = makeSeriesForLogs(logs.rows, options.intervalMs);
-        return { data: logs.series };
-      } else {
-        return { data: allStreams };
-      }
     });
   }
 

public/app/plugins/datasource/loki/result_transformer.test.ts

@@ -1,122 +1,6 @@
-import { LogsStream } from 'app/core/logs_model';
+import { logStreamToSeriesData } from './result_transformer';
 
-import { mergeStreamsToLogs, logStreamToSeriesData, seriesDataToLogStream } from './result_transformer';
+describe('convert loki response to SeriesData', () => {
-
-describe('mergeStreamsToLogs()', () => {
-  it('returns empty logs given no streams', () => {
-    expect(mergeStreamsToLogs([]).rows).toEqual([]);
-  });
-
-  it('returns processed logs from single stream', () => {
-    const stream1: LogsStream = {
-      labels: '{foo="bar"}',
-      entries: [
-        {
-          line: 'WARN boooo',
-          ts: '1970-01-01T00:00:00Z',
-        },
-      ],
-    };
-    expect(mergeStreamsToLogs([stream1]).rows).toMatchObject([
-      {
-        entry: 'WARN boooo',
-        labels: { foo: 'bar' },
-        key: 'EK1970-01-01T00:00:00Z{foo="bar"}',
-        logLevel: 'warning',
-        uniqueLabels: {},
-      },
-    ]);
-  });
-
-  it('returns merged logs from multiple streams sorted by time and with unique labels', () => {
-    const stream1: LogsStream = {
-      labels: '{foo="bar", baz="1"}',
-      entries: [
-        {
-          line: 'WARN boooo',
-          ts: '1970-01-01T00:00:01Z',
-        },
-      ],
-    };
-    const stream2: LogsStream = {
-      labels: '{foo="bar", baz="2"}',
-      entries: [
-        {
-          line: 'INFO 1',
-          ts: '1970-01-01T00:00:00Z',
-        },
-        {
-          line: 'INFO 2',
-          ts: '1970-01-01T00:00:02Z',
-        },
-      ],
-    };
-    expect(mergeStreamsToLogs([stream1, stream2]).rows).toMatchObject([
-      {
-        entry: 'INFO 2',
-        labels: { foo: 'bar', baz: '2' },
-        logLevel: 'info',
-        uniqueLabels: { baz: '2' },
-      },
-      {
-        entry: 'WARN boooo',
-        labels: { foo: 'bar', baz: '1' },
-        logLevel: 'warning',
-        uniqueLabels: { baz: '1' },
-      },
-      {
-        entry: 'INFO 1',
-        labels: { foo: 'bar', baz: '2' },
-        logLevel: 'info',
-        uniqueLabels: { baz: '2' },
-      },
-    ]);
-  });
-
-  it('detects ANSI codes', () => {
-    expect(
-      mergeStreamsToLogs([
-        {
-          labels: '{foo="bar"}',
-          entries: [
-            {
-              line: "foo: 'bar'",
-              ts: '1970-01-01T00:00:00Z',
-            },
-          ],
-        },
-        {
-          labels: '{bar="foo"}',
-          entries: [
-            {
-              line: "bar: 'foo'",
-              ts: '1970-01-01T00:00:00Z',
-            },
-          ],
-        },
-      ]).rows
-    ).toMatchObject([
-      {
-        entry: "bar: 'foo'",
-        hasAnsi: false,
-        key: 'EK1970-01-01T00:00:00Z{bar="foo"}',
-        labels: { bar: 'foo' },
-        logLevel: 'unknown',
-        raw: "bar: 'foo'",
-      },
-      {
-        entry: "foo: 'bar'",
-        hasAnsi: true,
-        key: 'EK1970-01-01T00:00:00Z{foo="bar"}',
-        labels: { foo: 'bar' },
-        logLevel: 'unknown',
-        raw: "foo: 'bar'",
-      },
-    ]);
-  });
-});
-
-describe('convert SeriesData to/from LogStream', () => {
   const streams = [
     {
       labels: '{foo="bar"}',
@@ -143,9 +27,8 @@ describe('convert SeriesData to/from LogStream', () => {
     expect(data.length).toBe(2);
     expect(data[0].labels['foo']).toEqual('bar');
     expect(data[0].rows[0][0]).toEqual(streams[0].entries[0].ts);
-
+    expect(data[0].rows[0][1]).toEqual(streams[0].entries[0].line);
-    const roundtrip = data.map(series => seriesDataToLogStream(series));
+    expect(data[1].rows[0][0]).toEqual(streams[1].entries[0].ts);
-    expect(roundtrip.length).toBe(2);
+    expect(data[1].rows[0][1]).toEqual(streams[1].entries[0].line);
-    expect(roundtrip[0].labels).toEqual(streams[0].labels);
   });
 });

public/app/plugins/datasource/loki/result_transformer.ts

@@ -1,115 +1,7 @@
-import ansicolor from 'vendor/ansicolor/ansicolor';
+import { LokiLogsStream } from './types';
-import _ from 'lodash';
+import { SeriesData, parseLabels, FieldType, Labels } from '@grafana/ui';
-import moment from 'moment';
 
-import { LogsMetaItem, LogsModel, LogRowModel, LogsStream, LogsStreamEntry, LogsMetaKind } from 'app/core/logs_model';
+export function logStreamToSeriesData(stream: LokiLogsStream): SeriesData {
-import { hasAnsiCodes } from 'app/core/utils/text';
-import { DEFAULT_MAX_LINES } from './datasource';
-
-import {
-  parseLabels,
-  SeriesData,
-  findUniqueLabels,
-  Labels,
-  findCommonLabels,
-  getLogLevel,
-  FieldType,
-  formatLabels,
-  guessFieldTypeFromSeries,
-} from '@grafana/ui';
-
-export function processEntry(
-  entry: LogsStreamEntry,
-  labels: string,
-  parsedLabels: Labels,
-  uniqueLabels: Labels,
-  search: string
-): LogRowModel {
-  const { line } = entry;
-  const ts = entry.ts || entry.timestamp;
-  // Assumes unique-ness, needs nanosec precision for timestamp
-  const key = `EK${ts}${labels}`;
-  const time = moment(ts);
-  const timeEpochMs = time.valueOf();
-  const timeFromNow = time.fromNow();
-  const timeLocal = time.format('YYYY-MM-DD HH:mm:ss');
-  const logLevel = getLogLevel(line);
-  const hasAnsi = hasAnsiCodes(line);
-
-  return {
-    key,
-    logLevel,
-    timeFromNow,
-    timeEpochMs,
-    timeLocal,
-    uniqueLabels,
-    hasAnsi,
-    entry: hasAnsi ? ansicolor.strip(line) : line,
-    raw: line,
-    labels: parsedLabels,
-    searchWords: search ? [search] : [],
-    timestamp: ts,
-  };
-}
-
-export function mergeStreamsToLogs(streams: LogsStream[], limit = DEFAULT_MAX_LINES): LogsModel {
-  // Unique model identifier
-  const id = streams.map(stream => stream.labels).join();
-
-  // Find unique labels for each stream
-  streams = streams.map(stream => ({
-    ...stream,
-    parsedLabels: parseLabels(stream.labels),
-  }));
-  const commonLabels = findCommonLabels(streams.map(model => model.parsedLabels));
-  streams = streams.map(stream => ({
-    ...stream,
-    uniqueLabels: findUniqueLabels(stream.parsedLabels, commonLabels),
-  }));
-
-  // Merge stream entries into single list of log rows
-  const sortedRows: LogRowModel[] = _.chain(streams)
-    .reduce(
-      (acc: LogRowModel[], stream: LogsStream) => [
-        ...acc,
-        ...stream.entries.map(entry =>
-          processEntry(entry, stream.labels, stream.parsedLabels, stream.uniqueLabels, stream.search)
-        ),
-      ],
-      []
-    )
-    .sortBy('timestamp')
-    .reverse()
-    .value();
-
-  const hasUniqueLabels = sortedRows && sortedRows.some(row => Object.keys(row.uniqueLabels).length > 0);
-
-  // Meta data to display in status
-  const meta: LogsMetaItem[] = [];
-  if (_.size(commonLabels) > 0) {
-    meta.push({
-      label: 'Common labels',
-      value: commonLabels,
-      kind: LogsMetaKind.LabelsMap,
-    });
-  }
-  if (limit) {
-    meta.push({
-      label: 'Limit',
-      value: `${limit} (${sortedRows.length} returned)`,
-      kind: LogsMetaKind.String,
-    });
-  }
-
-  return {
-    id,
-    hasUniqueLabels,
-    meta,
-    rows: sortedRows,
-  };
-}
-
-export function logStreamToSeriesData(stream: LogsStream): SeriesData {
   let labels: Labels = stream.parsedLabels;
   if (!labels && stream.labels) {
     labels = parseLabels(stream.labels);
@@ -122,34 +14,3 @@ export function logStreamToSeriesData(stream: LogsStream): SeriesData {
     }),
   };
 }
-
-export function seriesDataToLogStream(series: SeriesData): LogsStream {
-  let timeIndex = -1;
-  let lineIndex = -1;
-  for (let i = 0; i < series.fields.length; i++) {
-    const field = series.fields[i];
-    const type = field.type || guessFieldTypeFromSeries(series, i);
-    if (timeIndex < 0 && type === FieldType.time) {
-      timeIndex = i;
-    }
-    if (lineIndex < 0 && type === FieldType.string) {
-      lineIndex = i;
-    }
-  }
-  if (timeIndex < 0) {
-    throw new Error('Series does not have a time field');
-  }
-  if (lineIndex < 0) {
-    throw new Error('Series does not have a line field');
-  }
-  return {
-    labels: formatLabels(series.labels),
-    parsedLabels: series.labels,
-    entries: series.rows.map(row => {
-      return {
-        line: row[lineIndex],
-        ts: row[timeIndex],
-      };
-    }),
-  };
-}

public/app/plugins/datasource/loki/types.ts

@@ -1,8 +1,20 @@
-import { DataQuery } from '@grafana/ui/src/types';
+import { DataQuery, Labels } from '@grafana/ui/src/types';
 
 export interface LokiQuery extends DataQuery {
   expr: string;
-  resultFormat?: LokiQueryResultFormats;
 }
 
-export type LokiQueryResultFormats = 'time_series' | 'logs';
+export interface LokiLogsStream {
+  labels: string;
+  entries: LokiLogsStreamEntry[];
+  search?: string;
+  parsedLabels?: Labels;
+  uniqueLabels?: Labels;
+}
+
+export interface LokiLogsStreamEntry {
+  line: string;
+  ts: string;
+  // Legacy, was renamed to ts
+  timestamp?: string;
+}

public/app/plugins/panel/graph2/getGraphSeriesModel.ts

@@ -1,7 +1,5 @@
 import {
   GraphSeriesXY,
-  getFirstTimeField,
-  FieldType,
   NullValueMode,
   calculateStats,
   colors,
@@ -10,6 +8,8 @@ import {
   getDisplayProcessor,
   DisplayValue,
   PanelData,
+  FieldCache,
+  FieldType,
 } from '@grafana/ui';
 import { SeriesOptions, GraphOptions } from './types';
 import { GraphLegendEditorLegendOptions } from './GraphLegendEditor';
@@ -27,26 +27,25 @@ export const getGraphSeriesModel = (
   });
 
   for (const series of data.series) {
-    const timeColumn = getFirstTimeField(series);
+    const fieldCache = new FieldCache(series.fields);
-    if (timeColumn < 0) {
+    const timeColumn = fieldCache.getFirstFieldOfType(FieldType.time);
+    if (!timeColumn) {
       continue;
     }
 
-    for (let i = 0; i < series.fields.length; i++) {
+    const numberFields = fieldCache.getFields(FieldType.number);
-      const field = series.fields[i];
+    for (let i = 0; i < numberFields.length; i++) {
-
+      const field = numberFields[i];
-      // Show all numeric columns
-      if (field.type === FieldType.number) {
       // Use external calculator just to make sure it works :)
       const points = getFlotPairs({
         series,
-          xIndex: timeColumn,
+        xIndex: timeColumn.index,
-          yIndex: i,
+        yIndex: field.index,
         nullValueMode: NullValueMode.Null,
       });
 
       if (points.length > 0) {
-          const seriesStats = calculateStats({ series, stats: legendOptions.stats, fieldIndex: i });
+        const seriesStats = calculateStats({ series, stats: legendOptions.stats, fieldIndex: field.index });
         let statsDisplayValues;
 
         if (legendOptions.stats) {
@@ -77,7 +76,6 @@ export const getGraphSeriesModel = (
       }
     }
   }
-  }
 
   return graphs;
 };

public/app/plugins/panel/singlestat2/SingleStatPanel.tsx

@@ -16,9 +16,9 @@ import {
   PanelProps,
   getDisplayProcessor,
   NullValueMode,
-  FieldType,
   calculateStats,
-  getFirstTimeField,
+  FieldCache,
+  FieldType,
 } from '@grafana/ui';
 
 interface SingleStatDisplay {
@@ -51,16 +51,15 @@ export class SingleStatPanel extends PureComponent<PanelProps<SingleStatOptions>
 
     const values: SingleStatDisplay[] = [];
     for (const series of data.series) {
-      const timeColumn = sparkline.show ? getFirstTimeField(series) : -1;
+      const fieldCache = new FieldCache(series.fields);
+      const timeColumn = sparkline.show ? fieldCache.getFirstFieldOfType(FieldType.time) : null;
+      const numberFields = fieldCache.getFields(FieldType.number);
 
-      for (let i = 0; i < series.fields.length; i++) {
+      for (let i = 0; i < numberFields.length; i++) {
-        const field = series.fields[i];
+        const field = numberFields[i];
-
-        // Show all fields that are not 'time'
-        if (field.type === FieldType.number) {
         const stats = calculateStats({
           series,
-            fieldIndex: i,
+          fieldIndex: field.index,
           stats: [stat], // The stats to calculate
           nullValueMode: NullValueMode.Null,
         });
@@ -100,11 +99,11 @@ export class SingleStatPanel extends PureComponent<PanelProps<SingleStatOptions>
           };
         }
 
-          if (sparkline.show && timeColumn >= 0) {
+        if (sparkline.show && timeColumn) {
           const points = getFlotPairs({
             series,
-              xIndex: timeColumn,
+            xIndex: timeColumn.index,
-              yIndex: i,
+            yIndex: field.index,
             nullValueMode: NullValueMode.Null,
           });
 
@@ -119,7 +118,6 @@ export class SingleStatPanel extends PureComponent<PanelProps<SingleStatOptions>
         values.push(v);
       }
     }
-    }
 
     if (values.length === 0) {
       values.push({