IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Revert "DataLinks: Encode variable params for data link URLs (#46100)" (#47763)

Browse Source 
This reverts commit b47f5433d7.
This commit is contained in:
kay delaney
2022-04-20 10:15:36 +01:00
committed by GitHub
parent 1696a9abee
commit ff60f39e96
3 changed files with 5 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
e2e/dashboards-suite/templating-dashboard-links-and-variables.spec.ts
View File

@@ -34,7 +34,7 @@ e2e.scenario({
expect(links).to.have.length.greaterThan(13);
for (let index = 0; index < links.length; index++) {
expect(Cypress.$(links[index]).attr('href')).contains(`var-custom=${encodeURI(variableValue)}`);
expect(Cypress.$(links[index]).attr('href')).contains(`var-custom=${variableValue}`);
}
});
};
@@ -44,14 +44,6 @@ e2e.scenario({
// verify all links, should have All value
verifyLinks('All');
// Data links should percent encode var values
e2e()
.get('[aria-label="Data link"]')
.should('exist')
.and((link) => {
expect(link.attr('href')).contains(encodeURI('test%25value'));
});
e2e.pages.Dashboard.SubMenu.submenuItemValueDropDownValueLinkTexts('All').should('be.visible').click();
e2e.pages.Dashboard.SubMenu.submenuItemValueDropDownOptionTexts('p2').should('be.visible').click();