IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: add selector for items in the megamenu (#65633)

Browse Source 
add selector for items in the megamenu
This commit is contained in:
Ashley Harrison 2023-03-30 16:57:08 +01:00 committed by GitHub
parent 31aadeaecd
commit ff96cd1342
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/grafana-e2e-selectors/src/selectors/components.ts
View File

@ -247,6 +247,9 @@ export const Components = {
button: 'Reporting',
},
},
NavMenu: {
item: 'data-testid Nav menu item',
},
NavToolbar: {
container: 'data-testid Nav toolbar',
},

23
public/app/core/components/MegaMenu/NavBarMenuItem.tsx
View File

@ -2,6 +2,7 @@ import { css, cx } from '@emotion/css';
import React from 'react';
import { GrafanaTheme2 } from '@grafana/data';
import { selectors } from '@grafana/e2e-selectors';
import { Icon, IconName, Link, useTheme2 } from '@grafana/ui';
export interface Props {
@ -31,7 +32,11 @@ export function NavBarMenuItem({ children, icon, isActive, isChild, onClick, tar
);
let element = (
<button className={cx(styles.button, styles.element)} onClick={onClick}>
<button
data-testid={selectors.components.NavMenu.item}
className={cx(styles.button, styles.element)}
onClick={onClick}
>
{linkContent}
</button>
);
@ -39,11 +44,23 @@ export function NavBarMenuItem({ children, icon, isActive, isChild, onClick, tar
if (url) {
element =
!target && url.startsWith('/') ? (
<Link className={styles.element} href={url} target={target} onClick={onClick}>
<Link
data-testid={selectors.components.NavMenu.item}
className={styles.element}
href={url}
target={target}
onClick={onClick}
>
{linkContent}
</Link>
) : (
<a href={url} target={target} className={styles.element} onClick={onClick}>
<a
data-testid={selectors.components.NavMenu.item}
href={url}
target={target}
className={styles.element}
onClick={onClick}
>
{linkContent}
</a>
);