Commit Graph

20250 Commits

Author SHA1 Message Date
kay delaney
b215d2f0fb Library Panels: Fix library panel creation with RBAC enabled (#76553) 2023-10-25 16:29:57 +03:00
Kuba Siemiatkowski
327ae398e6 Add SumoLogic plugin (#77025)
- add Sumo to plugins list
- remove duplicated sqlyze from the plugins list
2023-10-25 15:02:03 +02:00
Alexander Zobnin
aa7a6da985 Role picker: Fix flickering at service accounts page (#77049)
* Role picker: Fix flickering at service accounts page

* Set role picker fixed width

* Fix betterer

* Fix styles
2023-10-25 13:03:12 +02:00
Gareth Dawson
c25ea17d10 SQL: Fix config page backwards compatibility (#76951)
fix
2023-10-25 11:38:16 +01:00
Karl Persson
b156267e39 ServiceAccount: Add pagination to service accout table (#77044)
* Add pagination to service account table
2023-10-25 12:21:01 +02:00
Sofia Papagiannaki
00c9981c51 Chore: Fix missing enterprise operation from swagger (#77122) 2023-10-25 13:20:36 +03:00
Joey
37dbf037de Tracing: Improve frame type checking (#76898)
Improve frame type checking
2023-10-25 10:16:17 +01:00
Sonia Aguilar
f1ce73dc2c Alerting: Fix NoRulesSplash being rendered for some seconds, fater creating a rule (#77048)
* Fix NoRulesSplash being rendered for some seconds, fater creating a rule

* Add ruler response/loading,dispatched,error to the logic in hasNoAlertRulesCreatedYet expression
2023-10-25 09:32:28 +02:00
Sofia Papagiannaki
b0b033584e Chore: Update OpenAPI specs (#77107) 2023-10-25 10:27:37 +03:00
ismail simsek
d75886c3ac Chore: Remove default metadata key from influxdb sql config page (#76994)
Remove default metadata key
2023-10-24 20:11:37 +02:00
Kat Yang
bbcc81405b Chore: Add CI Pipeline to generate Grafana's OpenAPI specification (#75393)
* chore: move over initial changes from sofia's pr #58029

* chore: remove go_image

* chore: begin removing edition, remove unused imports

* chore: remove edition from swagger_gen.star and generate .drone.yml

* chore: regen drone.yml

* fix: fix order of load statements

* fix: try #2 fix order of load statements

* linter fixes

* chore: add doc comment explaining purpose of new clone_pr_branch step

* fix: add placeholder documentation for ver_mode arg

* attempt #1 to import and use clone_enterprise_step_pr

* Update scripts/drone/pipelines/swagger_gen.star

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>

* attempt #2 to import and use clone_enterprise_step_pr

* fix: fix drone lint err invalid or unknown step dependency

* fix: regen hmac to make drone run

* fix: fix drone lint err

* fix: update swagger-clean cmd in step

* attempt to return non zero exit code

* test to see if pipeline fails

* fix: add git to clone pr branch step

* fix: add git and make to swagger-gen step

* try to rerun drone

* debug: figure out why cannot find make swagger-clean

* debug: see if cd grafana/grafana fixes things

* debug: undo cd grafana/grafana

* debug: add more logging statements

* debug: try and remove cd grafana in swagger-gen

* debug: removed grafana after clone statement; add debug before cloning

* fix: remove disable clone

* regen specs to see if swagger-gen step passes now

* add descriptive error message to swagger-gen step

* remove api-spec.json from .gitignore

* revert backend change, regen spec

* add back backend change, regen specs

* Update scripts/drone/pipelines/swagger_gen.star

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>

* Update scripts/drone/pipelines/swagger_gen.star

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>

* revert gitignore change, set enterprise source to drone source branch

* chore: remove unused variable, change committish var name to source

* testing functionality: make a new BE change without gen spec, pipeline should fail

* test functionality: does removing err msg cause step to fail properly

* test functionality: add back err msg and && after

* chore: remove debug statements from swagger gen step

* chore: remove debug lines from clone_pr_branch step

* test functionality: regen specs, swagger_gen step should pass

* test funcionality: regen specs again ????

* chore: update swagger-gen step err msg

* test functionality: make BE change dont regen spec, swagger gen should fail

* test functionality: regen the specs, swagger-gen should pass

* chore: revert test BE change, regen spec

* chore: remove unused clone step

* chore: regen drone.yml

---------

Co-authored-by: Timur Olzhabayev <timur.olzhabayev@grafana.com>
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
2023-10-24 13:01:04 -04:00
Jev Forsberg
41db5b645c Transformations: Separate useful doc content for UI use (#75781)
* baldm0mma/doc_builder/ add to gitignore

* baldm0mma/doc_builder/ add makefile commands

* baldm0mma/doc_builder/ add content

* baldm0mma/doc_builder/ format content

* baldm0mma/doc_builder/ update makefile

* baldm0mma/docs_builder/ update content

* baldm0mma/doc_builder/ add back content

* baldm0mma/doc_builder/ run builder

* baldm0mma/doc_builder/ update naming

* baldm0mma/doc_builder/ remove unused note

* baldm0mma/doc_builder/ update template

* baldm0mma/doc_builder/ add new line in makefile

* baldm0mma/doc_builder/ rem new line

* baldm0mma/doc_builder/ add final line

* Much of this full PR was Co-Authored-By: Jack Baldry <jack.baldry@grafana.com>

* baldm0mma/doc_builder/ update readme

* baldm0mma/doc_builder/ update guidlines

* Update scripts/docs/generate-transformations.ts

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update scripts/docs/generate-transformations.ts

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update scripts/docs/generate-transformations.ts

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update scripts/docs/generate-transformations.ts

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update scripts/docs/generate-transformations.ts

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update docs/README.md

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update docs/README.md

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update scripts/docs/generate-transformations.ts

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* baldm0mma/doc_builder/ update concat

* baldmomma/doc_builder/ finish concat table

* baldm0mma/docs_builder/ update with suggestions

* baldm0mma/doc_builder/ update content to use getHelperDocs

* baldm0mma/doc_builder/ update calculateField

* baldm0mma/doc_builder/ update to byRefId

* baldm0mma/doc_builder/ update filterByValue

* baldm0mma/doc_builder/ update filterFieldsByName

* baldm0mma/doc_builder/ update formatTime

* baldm0mma/doc_builder/ update groupBy

* baldm0mma/doc_builder/ update groupingToMatrix

* baldm0mma/doc_update/ update heatmap

* baldm0mma/doc_builder/ update histogram

* baldm0mma/doc_builder/ update joinByField

* baldm0mma/doc_builder/ update joinByLabels

* baldm0mma/doc_builder/ update labelsToFields

* baldm0mma/doc_builder/ update limit

* baldm0mma/doc_builder/ update merge

* baldm0mma/doc_builder/ update organize

* baldm0mma/doc_builder/ update partitionByValues

* baldm0mma/doc_builder/ update prepareTimeSeries

* baldm0mma/doc_builder/ update reduce

* baldm0mma/doc_builder/ update renameByRegex

* baldm0mma/doc_builder/ update rowsToFields

* baldm0mma/doc_builder/ update seriesToRows

* baldm0mma/doc_builder/ update sortBy

* baldm0mma/doc_builder/ update spatial

* baldm0mma/doc_builder/ update timeSeriesTable

* baldm0mma/doc_builder/ rerender all

* baldm0mma/doc_builder/ update calculateField

* baldm0mma/doc_builder/ gitignore conflicts

* baldm0mma/doc_builder/ add formatString

* baldm0mma/doc_builder/ update vars

* baldm0mma/doc_builder/ update naming

* baldm0mma/doc_builder/ rerender markdown

* Update public/app/features/transformers/docs/content.ts

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* baldm0mma/doc_builder/ update content

* baldm0mma/doc_builder/ add to codeownders

* baldm0mma/doc_builder/ correct spelling

* baldm0mma/doc_builder/ update comment

---------

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
2023-10-24 10:30:10 -06:00
Josh Hunt
ec84caf389 Navigation: Basic e2e tests for docked mega menu (#77000)
* Navigation: Basic e2e tests for docked mega menu

* give mega menu an e2e selector

* make existing tests narrower so menu doesn't default to docked. add test for auto docking at large viewport

* use new selector in nondocked menu
2023-10-24 15:56:00 +00:00
Fabrizio
3899620234 Tempo: Add new structural operators (#77056) 2023-10-24 17:46:36 +02:00
Drew Slobodnjak
97be80d1f0 Geomap: Fix route layer crosshair share (#76702)
* Geomap: Fix route layer crosshair share

* Update crosshair styling

* Consolidate horizontal and vertical lines

* Consolidate clear out

* Create const for crosshair color

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-10-24 08:15:31 -07:00
Sonia Aguilar
ed54239a9f Alerting: Dont show 1 firing series when no data in Expressions PreviewSummary (#76981)
* Dont show 1 firing series when no data in Expressions PreviewSummary

* Add comment to make clear we need to filter out undefineds for firing count

* Move logic to a new getGroupedByStateAndSeriesCount method and added test to it
2023-10-24 15:50:50 +02:00
Fabrizio
b8d005ae23 Plugins: Improvements to NodeGraph (#76879) 2023-10-24 15:16:10 +02:00
Eric Leijonmarck
813a7625a5 RBAC: Default to None role on SA creation if accesscontrol enabled (#77035)
* Check accesscontrol enabled on service account creation

* fix test

* linting
2023-10-24 13:52:55 +01:00
Eric Leijonmarck
8914849733 Revert "RBAC: Allow the basic role None as option of the org role #76335 (#77033)
Revert "RBAC: Allow the basic role None as option of the org role selector (#76335)"

This reverts commit 43928d38af.
2023-10-24 13:02:17 +01:00
Ashley Harrison
07cc7504ee Icon: Simplify and remove wrapping <div> (#76819)
* remove wrapping div

* update tests, just gotta figure out how to handle fontawesome :(

* add spinner.svg which matches the font-awesome spinner

* add mock for react-inlinesvg

* update mock and fix some tests

* fix FormField test

* fix CorrelationsPage tests

* increase timeout
2023-10-24 12:16:32 +01:00
Victor Marin
575981201c revert table tracking (#77021) 2023-10-24 13:58:14 +03:00
Ashley Harrison
ced065c7e9 Chore: fix some more types (#76535)
* clean up some e2e/runtime types

* fix some stories

* some more fixes

* fix route props

* update unit tests

* update more unit tests

* don't throw here
2023-10-24 11:53:22 +01:00
Ashley Harrison
fbbc524cb6 Navigation: Default MegaMenu to docked when screensize > 1440 (#76960)
default megamenu to docked when screensize > 1440
2023-10-24 09:27:23 +01:00
Matias Chomicki
4ea4156b08 Elasticsearch: decouple from timeSrv and templateSrv (#76894)
* Elasticsearch: remove timeSrv dependencies

* Elastisearch: decouple from templateSrv

* Prettier

* Elasticsearch: improve typescript in mocks file

* Prettier
2023-10-24 10:25:23 +02:00
Jack Westbrook
afa697f954 Build: Faster external plugin builds (#76974)
* build(plugin-configs): move swc-loader to configs and use require.resolve for less duplicate deps

* build(plugins): move cacheLocation to ESLintPlugin, run lint and tscheck plugins in dev

* revert(plugins): remove obsolete stats setting
2023-10-24 09:28:23 +02:00
Juan Cabanas
a174e69c52 Identity: Fix org role none comparison (#76999) 2023-10-23 17:14:01 -03:00
Todd Treece
b0eeeb9404 Playlists: Fix K8s list interface (#76993) 2023-10-23 12:47:39 -07:00
Adela Almasan
4df4844c1d Canvas: Button API update toaster error message (#76988) 2023-10-23 14:34:16 -05:00
ismail simsek
63abe25b74 InfluxDB: Fix table parsing with backend mode (#76899)
* Add resultFormat to query model

* don't add row name if the result format is table

* No need special formatting since we use unified dataframes

* betterer

* specify visualization type in response

* Unit tests

* fix unit tests
2023-10-23 19:21:30 +02:00
Drew Slobodnjak
4f2bbd490f Canvas: Add PUT to Canvas Button (#76844)
* Add PUT to canvas button

* Update cue file to include PUT

* Re run make gen cue

* fix gen-cue

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-10-23 09:24:34 -07:00
Ashley Harrison
efea86eb52 Navigation: Expand active page hierarchy and scroll into center if not visible (#76949)
* expand page hierarchy and scroll into center if not visible

* remove unnecessary id
2023-10-23 15:47:16 +01:00
William Assis
65a7bddcee Analytics: Add option to pass destSDKBaseURL to rudderstack load method (#74926)
* Add option to pass destSDKBaseURL to rudderstack load method

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-10-23 12:43:33 +00:00
Gareth Dawson
f6a0f6912f SQL: Update configuration pages (#75525)
* update psql config page to follow guidelines

* make small changes to mysql config page

* update shared tls config to match guidelines

* revert back to text area

* remove type assertion

* prettier

* remove unused imports

* update required fields

* add secure sox proxy to additional settings

* make additional settings collapsible

* make user permissions collapsable

* make db name and password optional

* mysql: move from alert to collapse
2023-10-23 11:29:28 +01:00
Ashley Harrison
f9a89e5cd2 Navigation: correctly mark a MegaMenuItem as active if it has active children (#76944)
correctly mark a MegaMenuItem as active if it has active children
2023-10-23 10:55:25 +01:00
Dominik Prokop
120247667b DashboardScene: Transform scene repeats to snapshot (#76428)
* WIP : Transform scene panel repeats to snapshot

* Set scoped vars correctly on repeated panel snapshot

* Row repeats snapshots

* Fix scoped vars for repeated rows

* Tests

* Fix merge
2023-10-23 02:46:35 -07:00
Josh Hunt
685b494e05 BrowseDashboards: Prevent unnecessary searches (#76424) 2023-10-23 09:44:07 +01:00
Ophir LOJKINE
4b6b3b7018 NodeGraph: Fix edges dataframe miscategorization (#76842)
* in node graph, fix edges dataframe miscategorization

A dataframe named "edges" could end up getting categorized as a nodes dataframe if it was missing a "source" field, resulting in a very confusing error message "id field is required for nodes dataframe" instead of a more sensible error message about the missing source field.

* Fix lint

---------

Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
2023-10-23 10:30:58 +02:00
Ashley Harrison
a2921d9dfb DockedMegaMenu: More consistent spacing on active state (#76873)
* more consistent spacing on active state

* use correct secondary variant buttons
2023-10-23 09:15:39 +01:00
Krishna Dhakal
cfa7311fd4 a11y: Fix no-static-element-interactions in xy chart editor (#76170)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-10-21 07:53:00 +03:00
Nathan Marrs
0ed0e0397c Geomap: Fix broken symbol alignment options for older geomap panels (#76850) 2023-10-20 10:29:52 -07:00
Dominik Prokop
534ca29707 Fix scenes runtime error for legacy angular panels (#76883) 2023-10-20 17:18:14 +02:00
Torkel Ödegaard
7759e2f8a3 DashboardScene: Panel Keybindings and some others (#76233)
* DashboardScene: Keybindings like v to view panel

* more bindings

* Fix imports

* Progress

* Nit update

* Fix merge

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-10-20 06:22:56 -07:00
Drew Slobodnjak
7028406b6d Geomap: Fix Share View (#76787)
* Geomap: Fix Share View

* Fix share view for multiple panels and options

* clean up

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-10-20 15:00:40 +02:00
siddhikhapare
3e24a500bf Tempo: Rename label in TraceQL builder (#76685)
* Rename label in TraceQL builder

* Suggested enhancement added

---------

Co-authored-by: André Pereira <adrapereira@gmail.com>
2023-10-20 10:35:57 +01:00
Ashley Harrison
f5758e9f4b Navigation: Correctly highlight a SectionNavItem if it has children that are active (#76860)
correctly highlight a sectionnavitem if it has children that are active
2023-10-20 10:27:25 +01:00
renovate[bot]
8985f79aab Update dependency webpack to v5.89.0 (#76832)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-20 09:23:11 +01:00
Carl Tablante
a0ec0baef3 chore(76107): Removed LegacyForm from FolderSettingsPage (#76313)
chore: Removed LegacyForm from FolderSettingsPage
2023-10-20 08:30:00 +03:00
Piotr Jamróz
6531cd94c4 Explore: Cancel previous queries when a new query is run (#76674)
* Cancel streaming queries before running new queries

* Cancel previous queries when a new query is run

* Remove redundant dependency

---------

Co-authored-by: Kristina Durivage <kristina.durivage@grafana.com>
2023-10-19 19:31:23 +02:00
Piotr Jamróz
8f6a3c18c5 Explore: Do not assert order of query history items when initializing from URL (#76806)
Assert initial state of the query history without requiring correct order.
2023-10-19 19:31:06 +02:00
Brendan O'Handley
5580d06101 Prometheus: PromQAIL frontend, drawer, feature toggle, workflow, etc. (#73020)
* initial commit for PromQAIL

* add feature toggle and start button

* add drawer

* set up drawer and state

* fix styles and start the conditional text display

* add data info list going to ai

* add logos and style

* metric display table style, neeed to make responsive

* make feature toggle frontend only

* add logic for want prompt for list or not, add helpers, addquerysuggestion type

* make query suggestion component

* add buttons to add or refine prompt

* refactor logic to add interactions to have multiple AI or historical interactions

* refactor and enable multiple questions, all flow

* add colorful AI icon to drawer open button

* fix linting

* refactor for hooking up promQail app and only giving one suggestion

* design fixes

* fix next prompt button styling

* historical suggestions give us 5, fixed that and some design things

* hook up the api, provide defense filler if it's down, refactor lots

* use query, fix linting

* add metadata to explain for ai suggestions

* styling fixes

* give metadata for historical suggestions by parsing query on the fly

* no prompt field to query-suggestion endpoint if prompt is empty

* fix linting

* use suggest rte for historical list, fix long code style

* use suggest rte for historical list, fix long code style

* fix historical bug

* added prompt file

* updated llm logic in explainer helper

* bump @grafana/experimental from 1.7.0 to 1.7.2

* use llmservice and vectorservice

* cleanup prompts + streaming explainer

* promqail feature toggle: fix re-order

* PromQL non-llm failback recommendation logic (#75469)

* added template recommendation logic directly in helpers

* also added selected labels to recommendation

* PromQail: query gen: fix prompt formatting and fetch metric labels to be used (#75450)

* PromQail: query gen: fix prompt formatting and fetch metric labels to be used

* Code fixes as suggested

* Use newly decided collection name for promql templates

* Prometheus: Promqail tests and bug fixes (#75852)

* add tests for drawer

* refine one prompt at a time, fix css

* scroll into view on interaction change

* fix styles for light

* disable prompt input after getting sugestions for that interaction

* make buttons disappear after selecting refine prompt or show historical queries to prevent user from clicking many times

* fix border radius

* fix new eslint rule about css requiring objects and not template literals

* add scrollIntoView for test

* grafana_prometheus_promqail_explanation_feedback - add feedback rudderstack interaction for explanation

* add form link to feedback for query suggestions

* fix bugs

* for prettier

* PromQL Builder Explainer: Added promql documentation and updated prompt (#75593)

* added promql documentation and updated prompt

* refactor prompt generation into isolated function

* updated prompt to answer with a question

* removed commented code

* updated metadata logic

* updated documentation body logic

* Prometheus: PromQAIL UI fixes (#76654)

* align buttons at 16px

* only autoscroll when an interaction has been added or the suggestions have been updated

* add 12px below explain for suggested queries

* add . after suggestion number

* fix linting error

* Prometheus: PromQAIL feedback improvements (#76711)

* align buttons at 16px

* only autoscroll when an interaction has been added or the suggestions have been updated

* add 12px below explain for suggested queries

* add . after suggestion number

* add text indication for explanation feedback

* add form for suggestion feedback, add form for not helpful explanation feedback

* fix linting error

* make radio button feedback required

* required text, padding additions, thank you for your feedback

* PromQL Builder Suggestion: Added type level templates and removed explainer steps for fallback suggestion logic (#75764)

* adding more detailed templates to promql fallback suggest

* remove debug logs

* added missing explain logic

* Fix brendan's type issue

---------

Co-authored-by: Brendan O'Handley <brendan.ohandley@grafana.com>
Co-authored-by: bohandley <brendan.ohandley@gmail.com>

* make yarn.lock equal to current in main

* fix feature toggles

* fix prettier issues

---------

Co-authored-by: Edward Qian <edward.qian@grafana.com>
Co-authored-by: Yasir Ekinci <yas.ekinci@grafana.com>
Co-authored-by: Edward Qian <edward.c.qian@gmail.com>
Co-authored-by: Gerry Boland <gerboland@users.noreply.github.com>
2023-10-19 10:45:32 -05:00