Provide new feature in Prometheus dashboards to cache queried time series data, modify requests to not include previously cached data in order to improve dashboard refresh performance.
Co-authored-by: Galen <galen.kistler@grafana.com>
Co-authored-by: Leon <leon.sorokin@grafana.com>
* define initial service and add to wire
* update caching service interface
* add skipQueryCache header handler and update metrics query function to use it
* add caching service as a dependency to query service
* working caching impl
* propagate cache status to frontend in response
* beginning of improvements suggested by Lean - separate caching logic from query logic.
* more changes to simplify query function
* Decided to revert renaming of function
* Remove error status from cache request
* add extra documentation
* Move query caching duration metric to query package
* add a little bit of documentation
* wip: convert resource caching
* Change return type of query service QueryData to a QueryDataResponse with Headers
* update codeowners
* change X-Cache value to const
* use resource caching in endpoint handlers
* write resource headers to response even if it's not a cache hit
* fix panic caused by lack of nil check
* update unit test
* remove NONE header - shouldn't show up in OSS
* Convert everything to use the plugin middleware
* revert a few more things
* clean up unused vars
* start reverting resource caching, start to implement in plugin middleware
* revert more, fix typo
* Update caching interfaces - resource caching now has a separate cache method
* continue wiring up new resource caching conventions - still in progress
* add more safety to implementation
* remove some unused objects
* remove some code that I left in by accident
* add some comments, fix codeowners, fix duplicate registration
* fix source of panic in resource middleware
* Update client decorator test to provide an empty response object
* create tests for caching middleware
* fix unit test
* Update pkg/services/caching/service.go
Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
* improve error message in error log
* quick docs update
* Remove use of mockery. Update return signature to return an explicit hit/miss bool
* create unit test for empty request context
* rename caching metrics to make it clear they pertain to caching
* Update pkg/services/pluginsintegration/clientmiddleware/caching_middleware.go
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
* Add clarifying comments to cache skip middleware func
* Add comment pointing to the resource cache update call
* fix unit tests (missing dependency)
* try to fix mystery syntax error
* fix a panic
* Caching: Introduce feature toggle to caching service refactor (#66323)
* introduce new feature toggle
* hide calls to new service behind a feature flag
* remove licensing flag from toggle (misunderstood what it was for)
* fix unit tests
* rerun toggle gen
---------
Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Takes a specific code path for data that identifies itself as dataplane instead of "guessing" what the data is.
The data must identify itself by being in the dataplane by having both the following frame metadata properties:
- TypeVersion property that is greater than 0.0
- 'Type' property
The flag is disableSSEDataplane and disables this functionality and uses the old code for all queries regardless.
See https://github.com/grafana/grafana-plugin-sdk-go/blob/main/data/contract_docs/contract.md for dataplane details.
* Add usage stats about correlations
* Add stats.correlations.count to collected stats
* Expose grafana_stat_totals_correlations metric
* Organize imports
* Correlations: Add documentation
* Add info about the feature toggle and move it to beta
* Remove incorrect bullet point
* Remove a bullet point that is not a step
* Update punctuation
* Update punctuation
* Fix typo
* Fix typo
* Grammar
* Rephrase
* Clarify
* Update transformation.field documentation
* Revert automatic merge formatting
* added what's new and upgrade guide 9.5 and updated whats new index page
* Added new nav and nested folders.
* added empty dashboard state and dashboards section
* fixed caption
* fixed formatting of link and UI element
* Add: onlyExternalOrgRoleSync
* Adds Alerting entries
* Adds alerting screenshots
* More alerting screenshots
* add dashboard panel redesign
* Update _index.md
* Adds search to notification policy entry
* deletes old line
* Removed nested folders (will be private preview and not part of what's new)
* Docs: support bundle section for 9.5 What's New (#65641)
* support bundle section for 9.5 what's new
* Update whats-new-in-v9-5.md
* Update docs/sources/whatsnew/whats-new-in-v9-5.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* doc feedback
---------
Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* Influxdb database field deprecation notice
* Update reasoning
* fixed typo
* Docs: what's new API keys UI update (#65720)
* API keys deprecation
* Update docs/sources/whatsnew/whats-new-in-v9-5.md
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
* Update docs/sources/whatsnew/whats-new-in-v9-5.md
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
---------
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
* Docs: API keys UI updates (#65723)
update
* Docs: add dashboard previews deprecation notice (#65692)
* previews deprecation notice
* Apply suggestions from code review
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
---------
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
* we set the FF emptyDashboardPage ON by default, so it's available by default
* Update docs/sources/whatsnew/whats-new-in-v9-5.md
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
* add whats new toggle for prom browser cache feature
* Prometheus: metric encyclopedia feature toggle
* spell check
* Product editorial pass
Adds hyperlinks, notes release stages, updates intro, Adds content to upgrade guide
* add blurb for prom query cache
* Add more context to org role sync
Add more context to organization role sync about the ability to change a user's organization role even then sync is enabled. Also outlined why this is valuable and when it should be used.
* copy edit of upgrade guide
* copy edit and link fixes
* Update docs/sources/whatsnew/whats-new-in-v9-5.md
Makes it clear what can happen after sign in.
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
* Update docs/sources/whatsnew/whats-new-in-v9-5.md
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
* Update docs/sources/whatsnew/whats-new-in-v9-5.md
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
* Apply suggestions from code review
* fixes link
* Adds dark screenshot for alerting
* fixes alerting title
* Update whats-new-in-v9-5.md
* added missing quotation mark
* trigger linting
* small change to trigger linting
* fix title to follow pattern
* Update whats-new-in-v9-5.md
* Clearer explanation
* wording edits
* fixed heading levels
* fix title wording
* wording edit and availability fix
* remove extra space
* final copy edit
---------
Co-authored-by: Zsofia <zsofia.komaromi@gmail.com>
Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com>
Co-authored-by: polinaboneva <polina.boneva@grafana.com>
Co-authored-by: Galen <galen.kistler@grafana.com>
Co-authored-by: bohandley <brendan.ohandley@gmail.com>
Co-authored-by: Mitchel Seaman <mitchel.seaman@gmail.com>
Co-authored-by: danielkenlee <115471695+danielkenlee@users.noreply.github.com>
Co-authored-by: Chris Moyer <chris.moyer@grafana.com>
Co-authored-by: Fabrizia Rossano <117294258+frossano-grafana@users.noreply.github.com>
* add: deprecation to api keys write path
* boolean w. meessage
* add read and delete endpoints
* better description of deprecation
* updated with puncutations
* removes references to CentOS
* starts reorg
* complete restructure
* updates alias
* Update docs/sources/setup-grafana/installation/rpm/index.md
* Apply suggestions from code review
Co-authored-by: Dan Cech <dcech@grafana.com>
* incorporates review feedback
* adds install on suse/opensuse
* updates aliases
* Apply suggestions from code review
Co-authored-by: Dan Cech <dcech@grafana.com>
* removes start server content from both topics; adds link to start server docs in Next steps
* Apply suggestions from code review
Co-authored-by: Dan Cech <dcech@grafana.com>
* incorporates review feedback
* Apply suggestions from code review
* typo fix
---------
Co-authored-by: Dan Cech <dcech@grafana.com>
* fixed headings
* added Cross-account observability section back
* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md
Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* broke out to 2 steps
* changed headings under Configure AWS aut
* changed headings, added link to IAM
* changed headings
* updated link
* formatting fixes
* more formatting fixes
* made requested change
* cleaned up wording
* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* removed new
---------
Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* Alerting: Remove and revert flag alertingBigTransactions
This is a partial revert of #56575 and a removal of the `alertingBigTransactions` flag.
Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count
came at the cost of significant increase in CPU usage and query latency.
* Fix lint backend
* Removed last bits of alertingBigTransactions
---------
Co-authored-by: Armand Grillet <2117580+armandgrillet@users.noreply.github.com>
* Added Phlare and added static data sources to intro instead of it just being TSDB sources
* Update docs/sources/introduction/_index.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* Update docs/sources/introduction/_index.md
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
---------
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* tracing: show backend trace ids in frontend
* better trace id naming
Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
* better trace id naming
Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
* better trace id naming
Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
* added feature flag
* bind functionality to the feature flag
* use non-generic name for traceid header
* fixed tests
* loki: do not create empty fields
* do not add empty fields
* fixed graphite test mock data
* added unit-tests to queryResponse
* added unit-tests for backend_srv
* more typescript-friendly check
* added unit-tests for runRequest
---------
Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
* Added note to contact Support
* Update docs/sources/setup-grafana/configure-security/configure-authentication/enhanced-ldap/index.md
* Update docs/sources/setup-grafana/configure-security/configure-authentication/enhanced-ldap/index.md
* makes prettier
* Apply suggestions from code review
---------
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Chris Moyer <chris.moyer@grafana.com>
* Feature Flags: Remove dev-mode from grpc server feature flag
---------
Co-authored-by: Todd Treece <todd.treece@grafana.com>
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
* navigation related text updates
* fixed lead-in sentences and indented config options as part of steps
* updated azure managed identity image
* Apply suggestions from code review
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
---------
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* update enhanced-ldap
documenting a potential issue with ldap active sync, when search filter and username attributes do not match.
* Update docs/sources/setup-grafana/configure-security/configure-authentication/enhanced-ldap/index.md
* formats example
* Update docs/sources/setup-grafana/configure-security/configure-authentication/enhanced-ldap/index.md
---------
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Chris Moyer <chris.moyer@grafana.com>
* docs(pluginextensions): initial commit detailing how to add menu items to grafana
* docs(pluginextensions): initial commit detailing how to do cross plugin linking
* Update cross-plugin-linking.md
* Update extend-the-grafana-ui-with-links-and-commands.md
* style(pluginextensions): prettier fix for extend the grafana ui with links and commands
* Update docs/sources/developers/plugins/extend-the-grafana-ui-with-links-and-commands.md
Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
* Update docs/sources/developers/plugins/cross-plugin-linking.md
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
* docs(pluginextensions): add info for placements and link to metadata
* docs(plugin-extensions): update metadata for new docs pages
* docs(plugin-extensions): pr feedback
* Update docs/sources/developers/plugins/cross-plugin-linking.md
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
* docs(plugin-extensions): remove all mention of commands
* chore(plugin-extensions): rename extension doc to remove reference to commands
* docs(plugin-extensions): replace usage of placement with extension point
* docs(plugin-extensions): lowercase ID
---------
Co-authored-by: Joseph Perez <45749060+josmperez@users.noreply.github.com>
Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
* empty dashboard related updates
* updated steps to clearly indicate button names
Some steps indicated the heading as the thing to click rather than the button text. Also some of the button text wasn't quite accurate.
* remove incorrect instruction
* apply suggestion from review
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
* pushing empty commit to trigger linting
* triggering linting
---------
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
