Arve Knudsen
3d3a7cbba8
Chore: Fix staticcheck issues ( #28860 )
...
* Chore: Fix issues reported by staticcheck
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Undo changes
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Chore: Fix issues reported by staticcheck
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-11-05 13:07:06 +01:00
Sofia Papagiannaki
48e753d888
Alerting: Log alert warnings for obsolete notifiers when extracting alerts and remove spammy error ( #28162 )
...
* Lower level of notification translation messages
* API: Log alert warnings when saving dashboard
* Remove spammy error
* Rename function parameter
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
* Apply suggestions from code review
* Fix test
* Change alertValidator return type
* Small fix
* Rename symbol
* Revert "Rename symbol"
This reverts commit 40b619b21a2df8319d1dad933863e3f728ece2dbf35c5f52af7f95800c5f95d3e75b001ac5c3f281
2020-10-22 14:43:12 +03:00
jgulick48
5bc6c447e3
Alerting: Return proper status code when trying to create alert notification channel with duplicate name or uid ( #28043 )
...
* Alerting: Return proper status code when trying to create an Alert Notification where the name or UID already exists.
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-10-20 13:53:48 +02:00
Agnès Toulet
0c4b7d3f5d
Alerting API: send 404 not found error and enrich delete with UID endpoint response with alert notification ID ( #27550 )
...
* Alerting API: Send back 404 not found error for update and delete endpoints
* Alerting API: send back alert notification id for delete with uid endpoint
2020-09-11 18:04:43 +02:00
Mitsuhiro Tanda
292c985b76
Alerting: Support storing sensitive notifier settings securely/encrypted ( #25114 )
...
Support storing sensitive notification settings securely/encrypted.
Move slack notifier url and api token to secure settings.
Migrating slack notifier to store token and url encrypted is currently
a manual process by saving an existing slack alert notification channel.
saving an existing slack alert notification channel will reset the stored
non-secure url and token.
Closes #25113
Ref #25967
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2020-07-08 10:17:05 +02:00
Dima Ryskin
44b7f3ea1c
AlertNotifications: Translate notifications IDs to UIDs in Rule builder ( #19882 )
...
* AlertNotifications: Translate notifications IDs to UIDs in alert Rule builder
* Avoid shadowing errors, raise validation error on non-existing notification id
* create a cache for notification Uids to minimize db overhead
* add cache usage test
* avoid caching empty notification Uids
* isolate db in alert notificationUid caching tests
2020-03-18 15:00:56 +02:00
Oleg Gaidarenko
54c1bf0cc9
Chore: a bit of spring cleaning ( #16710 )
...
* Chore: use early return technic everywhere
And enable "indent-error-flow" revive rule
* Chore: remove if-return rule from revive config
* Chore: improve error messages
And enable "error-strings" revive rule
* Chore: enable "error-naming" revive rule
* Chore: make linter happy
* Chore: do not duplicate gofmt execution
* Chore: make linter happy
* Chore: address the pull review comments
2019-04-23 11:24:47 +03:00
Marcus Efraimsson
5da1faf454
Alerting: Notification channel http api fixes ( #16379 )
...
Fixes so it's possible to create new notification channel and providing uid.
Fixes better error/result handling when updating a notifcation channel.
Fixes #16372
Ref #16219 #16012
2019-04-04 17:52:40 +02:00
Marcus Efraimsson
79b86466fd
Fix: Alerting Notification channel http api fixes ( #16288 )
...
Fix so that uid can be changed when updating notification
channels through the http api.
Update documentation
2019-03-29 09:42:38 +01:00
Marcus Efraimsson
2ae63e70c0
Alerting: Notification channel http api enhancements ( #16219 )
...
Now returns uid in response to get notification channel by id.
Adds GET/PUT/DELETE support for notification channel by uid,
/api/alert-notifications/uid/:uid.
Break apart alerting and alert notification http api docs in two
pages and update documentation to make it up to date
with current implementation.
Fixes #16012
2019-03-26 18:37:02 +07:00
Pavel Bakulev
f132e929ce
Added uid for alert notifications
2019-01-16 16:50:00 +02:00
bergquist
70385119bc
removes d in disableResolvedMessage
2018-10-17 10:41:18 +02:00
Dave Waters
c4dcf5a4ee
fix gofmt, add test, correct noted concerns with default value
2018-10-16 17:33:38 -04:00
Dave Waters
6376154b16
add channel option to disable the resolved alert (OK Message) that is sent when condition returns to normal.
2018-10-15 17:16:14 -04:00
bergquist
9022e871e3
avoid sending full notification state to pending/complete
2018-10-02 13:57:41 +02:00
bergquist
341d8af637
rename GetNotificationStateQuery to GetOrCreateNotificationStateQuery
2018-10-02 11:23:40 +02:00
bergquist
7f1d7cefc0
reminder: uses UpdatedAt to track state changes.
2018-10-02 11:19:09 +02:00
bergquist
75f832cda8
use alert state changes counter as secondary version
2018-10-01 15:58:30 +02:00
Marcus Efraimsson
5ec086dc56
don't notify if notification state pending
...
If notification state is pending and last update of state was made
less than a minute ago. In the case of a grafana instance is shut down/crashes
between setting pending state and before sending the notification/marks as complete
this logic should allow the notification to be sent after some time instead of
being left in an inconsistent state where no notifications are being sent.
2018-09-30 21:52:50 +02:00
Marcus Efraimsson
d412aafb7e
remove unused code
2018-09-30 20:16:01 +02:00
Marcus Efraimsson
c1763508e0
handle pending and completed state for alert notifications
2018-09-28 14:22:03 +02:00
Marcus Efraimsson
88bbc452a7
wip: send and mark as complete
2018-09-28 11:14:36 +02:00
bergquist
15ce474639
wip
2018-09-27 16:21:53 +02:00
bergquist
c5278af6c4
add support for mysql and postgres unique index error codes
2018-09-27 11:33:13 +02:00
bergquist
3fab616239
implement sql queries for transactional alert reminders
2018-09-27 11:14:44 +02:00
bergquist
ff79f80685
initial rename refactoring
2018-09-27 09:43:00 +02:00
bergquist
b04052f515
alerting: move all notification conditions to defaultShouldNotify
2018-09-26 14:34:10 +02:00
bergquist
83a12afc07
adds tests for journaling sql operations
2018-06-16 11:27:04 +02:00
bergquist
c21938d4c4
use epoch to compare timestamp
2018-06-16 00:03:13 +02:00
bergquist
171a38df99
alerting: fixes broken table rename
2018-06-05 14:29:48 +02:00
bergquist
7333d7b8d4
alerting: invert sendOnce to sendReminder
2018-06-05 10:44:17 +02:00
John Baublitz
bdf433594a
Implement code review changes
2018-06-04 13:19:14 +02:00
John Baublitz
fca97535d1
Fix multiple bugs
2018-06-04 13:19:14 +02:00
John Baublitz
3cb0e27e1c
Revert changes post code review and move them to notification page
2018-06-04 13:19:14 +02:00
bergquist
2ca7284a56
tech(notifications): splitt into 3 queries
...
closes #5883
2016-09-06 08:43:15 +02:00
bergquist
c893e5d241
feat(notifications): add support for default notifications
...
ref #5883
2016-09-05 21:35:37 +02:00
Torkel Ödegaard
a6c6094775
feat(alerting): started reworking notifications
2016-07-22 16:45:17 +02:00
bergquist
fa309ec925
feat(alerting): add default notification group
2016-06-20 15:24:48 +02:00
bergquist
b907ce341c
feat(alerting): enables deletes for alert notifications
2016-06-16 15:21:44 +02:00
bergquist
7f767224af
feat(alerting): basic support for creating and updating notifications
2016-06-16 14:29:20 +02:00
bergquist
9a8416416d
feat(alerting): converter for db model to notification
2016-06-16 08:16:16 +02:00
bergquist
dbf3795aaf
feat(alerting): add sql layer for alert notifications
2016-06-16 08:16:16 +02:00
bergquist
8b91e57ef6
feat(alerting): notification query
2016-06-16 08:16:16 +02:00
