Commit Graph

1489 Commits

Author SHA1 Message Date
Sonia Aguilar
2090270a13
Gops: Fix data field in incidents query (#88682)
Remove data field in incidents query
2024-06-04 14:42:56 +02:00
Sonia Aguilar
88a2485cc2
Alerting: Update translations in GrafanaEvaluationBehaviour component (#88638)
* Update translations

* Fix key in translations

* Interpolate point char in the Trans children text

* Use interpolation correctly in Trans component
2024-06-04 11:19:53 +03:00
Pepe Cano
2a8a6d755f
Alerting: update Set evaluation behavior text (#88301)
* Alerting: update `Set evaluation behavior` text

* Update `Evaluation group` description for the `Evaluation group` modal view
2024-06-03 15:41:34 +02:00
Tom Ratcliffe
dfd64ed469
Alerting: Ensure we fetch AM config before saving new configuration (#88458) 2024-05-31 17:19:01 +02:00
Gilles De Mey
f6a1ed3581
Alerting: Replace Strong component (#88186) 2024-05-30 13:05:37 +02:00
Konrad Lalik
93870c1cd8
Alerting: Use new endpoints to fetch single GMA rule on view and edit pages (#87625) 2024-05-30 12:55:06 +02:00
Gilles De Mey
b7db268798
Alerting: Correctly handle duplicating notification templates (#88487)
Co-authored-by: Alex Petrov <alex.petrov.vt@gmail.com>
Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
Co-authored-by: Alex Petrov <apetrov@fastly.com>
2024-05-30 12:43:03 +02:00
Sonia Aguilar
650f291054
Gops: Fix incidents url adding plugin twice in it (#88472)
Fix incidents url adding plugin twice in it
2024-05-30 11:05:20 +02:00
Tom Ratcliffe
5bb7d4da4c
Alerting: Remove regex reference in silences filter tooltip (#88455) 2024-05-30 09:05:34 +01:00
Tom Ratcliffe
3adb07cf4d
Alerting: Make regex notification routing preview consistent with notification policies implementation (#88413)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-05-29 17:04:35 +01:00
Gilles De Mey
781f67dfb6
Alerting: Support alertingDisableSendAlertsExternal feature toggle (#88384) 2024-05-29 13:54:07 +02:00
Laura Fernández
6d98f53e8b
Chore: Remove returnToPrevious feature toggle (#88332) 2024-05-27 17:47:57 +02:00
Gilles De Mey
99b5259cc1
Alerting: New list view UI – Part 1 (#87907) 2024-05-24 16:40:49 +02:00
Pepe Cano
51e27200a6
Alerting: add NeedHelpInfo for Configure No data and error handling (#88145) 2024-05-24 15:30:12 +02:00
Tom Ratcliffe
859b3ff78b
Alerting: Fix "copy link" not including full URL (#88210) 2024-05-24 15:02:46 +02:00
Tom Ratcliffe
ebdad80dfa
Alerting: Fix rules deleting when reordering whilst filtered (#88221) 2024-05-24 13:49:52 +02:00
Sonia Aguilar
caeb9bcea2
Alerting: Template selector in contact points form (#87689)
* WIP

* Refactor and update how we display these fields in the form

* Add test for getTemplateOptions and udpate parseTemplates to handle minus simbol

* fix betterer

* Fix wrapper

* Create new usePreviewTemplate to be reused from TemplatePreview and TemplateContentAndPreview

* remove unnecessary check

* track interactions

* Include the whole content of the template in the preview

* Update parseTemplates function to return default templates

* handle nested templates in parseTemplates function

* Missing border fixed, whitespaces preserved and no empty space at the bottom

* remove unused styles and add a comment in test

* Add missing error in getPreviewResults

* fix styles for template selector containers

* Alerting: PR feedback to move default templates into RTKQ (#88172)

Move default templates to RTKQ API + constant

* move parseTemplates to a utils file and refactor last part of this function

* Keep selected options when loading exising input and when switching between tabs

* Update descritpion in tabs

* Fix not previewing when loading existing values

* Update text addressing Brenda's feedback

* Add test for matchesOnlyOneTemplate function

* Add minheight to viewer container and fix getContentFromOptions function

---------

Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
2024-05-24 13:35:48 +02:00
Sonia Aguilar
e8e14a5e53
Gops: Fix wrong endpoint for incidents check (#88238)
Fix wrong endpoint for incidents check
2024-05-23 18:23:50 +03:00
Gilles De Mey
8cc944f64f
Alerting: Docs feedback (#88125)
update OK to Normal label, matching instances to instances
2024-05-21 18:10:12 +03:00
Tom Ratcliffe
dbf258b837
Alerting: Center "need help" icons (#87981) 2024-05-21 12:04:10 +01:00
Tom Ratcliffe
938fcab1c8
Alerting: Skip flakey silencing test (#87994) 2024-05-16 18:49:18 +03:00
Tom Ratcliffe
9e29c215c3
Alerting: Update silences creation to support __alert_rule_uid__ and move into drawer (#87320) 2024-05-16 09:34:07 +01:00
Tom Ratcliffe
aae6b5312a
Alerting: Fix "evalutation" typo (#87930) 2024-05-15 19:05:45 +03:00
Tom Ratcliffe
f4d55d2612
Alerting: Restructure mock server handlers slightly and remove unnecessary handlers (#87759) 2024-05-15 16:53:16 +01:00
Dominik Prokop
fa63e03df3
MultiSelect: Respect value passed to the component regardless of custom value being allowed or not (#87906)
* MultiSelect: Respect value passed to the component regardless of custom value being allowed or not

* reset input for test

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-05-15 16:24:30 +02:00
Sonia Aguilar
3aae2b7e04
Alerting: Assume built-in AM is receiving alerts in case of not having admin config (#87893) 2024-05-15 14:51:28 +02:00
Konrad Lalik
1cf1c5f03a
Alerting: Add hide plugins rules filter (#87445)
* Add hide plugins rules filter

* Change the filter label and available values

* Setup plugins hook in tests

* Fix lint errors

* remove unused code
2024-05-15 14:09:56 +02:00
Sonia Aguilar
ca0dae6812
Gops: Add configuration tracker on the existing IRM page (#85838)
* WIP

* add configure irm componet and pass it to Nav

* add check if theres datasource for Alerts

* update incident steps links

* uncomment done property in the interface

* Fix not having data sources in store and removing warning using wrong Icon name type

* call incidents api in done step

* Show checked steps with an icon instead of a badge

* Implemnt check contact point ready in essentials

* Fix codeowners and prettify file

* Check if there is one oncall integration in at least one contact point

* Refactor

* Check for oncall integration being created

* Add the test oncall integration action

* Do not hide any card in irm page, and refactor

* Refactor: move hooks to a separate file

* Implement oncall chatops checks

* update incidents hook

* Show new irm page only on cloud and for admins

* fix prettier in irmhooks

* remove unused import

* fix prettier in irm hooks

* fix axios method

* Add progress bar on essentials

* Update texts and some styles

* Refactor

* fix api call

* fix check is plugin is installed

* fix async call

* fix lint

* Do not show check icon when done field is undefined in a step

* refactor

* Add test for Essentials

* check if incident plugin installed

* call incidents api to get steps

* add the new api to get config

* fix prettier

* memoize the api call

* fix lint

* add proper api call

* check if response is valid

* fix typo

* use state to save the values

* fix lint

* fix response schema

* fix prettier

* update incident steps copy

* udapte texts in respond tooltips

* Fix confiure IRM route check

* Fix logic for the data source check: check if there is a data source that is alerting compatible

* Use existing header prop in NavLandingPage instead of creating a new prop

* fix wrong updated file

* Update logic for default contact point check and update some links

* Update texts and show only one item for oncall integration with alerting checks

* Update texts following suggestions in the doc

* Fix getting default contact point and update oncall link for slack tab

* Update texts, buttons and checks following last meeting action items

* remove unnecessary component drawer

* Track interactions: user open or close essentials drawer

* Refactor

* remove unnecessary createMonitoringLogger for tracking irm events

* remove unnecessary style

* refactor

* refactor

* Add fallback links and labels for action buttons when step is done

* Update irm card styles

* remove extra space after progress bar numbers

* remove progress bar border

* Address pr review comments

* remove unnecessary AlertmanagerProvider

* fix logic behind default contact point check

* update test

* Address pr review comments part1

* add aria and properties role for Progressbar

* Reorganize hooks into separate folders/files for each app

* move done field to the step level

* Handle empty dropdown options

* Handle loading state

* Update tooltip for connecting alerting to oncall

* Use RTKQ for incidents

* handle loading for oncall hooks

* refactor getting configuration for each app

* fix incident rtkq query to be a query instead of mutation

* refactor: rename variable

* Address some nits in the review

---------

Co-authored-by: reemtariqq <reem.tariq@grafana.com>
2024-05-14 16:42:22 +02:00
Sonia Aguilar
6b1a662f6b
Alerting: Fix deleting rules when silencing/resuming rule from a panel alert tab (#87710)
* Fix deleting rules when silencing/resuming rule from a panel alert tab

* fix test and return early when no group target is found

* address pr review comment
2024-05-14 10:01:08 +02:00
Konrad Lalik
c203a030e8
Alerting: Fix MatcherFilter onChange handling (#87511)
* Fix input onChange handler

* Remove unused variables
2024-05-10 15:42:23 +02:00
Ashley Harrison
670960f70c
Chore: Upgrade redux (#86877)
* update packages

* fix type errors

* upgrade redux toolkit as well

* don't need eslint-disable command

* remove comment

* fix unit tests

* call rtk query selector directly

* remove unnecessary checks
2024-05-10 14:28:51 +01:00
kay delaney
cbe868b118
Chore: Use getNextRefId instead of deprecated getNextRefIdChar (#87460) 2024-05-10 12:00:17 +01:00
Sonia Aguilar
4b720206d4
Alerting: Reduce number of request fetching rules in the dashboard view using rtkq (#86991)
* Reduce number of request fetching rules in the dashboard view using rtkq

* Fix UnifiedAlertStatesWorker work

* refactor ungroupRulesByFileName

* Address review comments and fix test

* fix DashboardQueryRunner test

* Fix tests

* Update AlertStatesDataLayer to use RTKQ

* Fix PanelAlertTabContent test

* Fix PanelAlertTabContent test after adding RTKQ

* fix test and address PR review comments

* Update useCombinedRuleNamespaces to have both dashboardUID and panelId as optional params and rename the hook

* Address review pr comment

* remove test about template variables

* Use poll interval in useCombinedRules
2024-05-10 12:27:06 +02:00
kay delaney
bc67b88301
Chore: Rewrite alerting css using object styles (#87114)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-05-07 10:57:25 +01:00
Gilles De Mey
19e8dca09c
Alerting: Allow editing of provisioned mutable Alertmanagers (#87385) 2024-05-06 14:29:28 +02:00
Ashley Harrison
1d6d5cc2cd
Chore: improve typings (#87306)
* some fixes

* some more fixes

* some canvas fixes

* use removeProperty instead

* few more

* fixy fix

* undo changes to ticks for now
2024-05-03 17:21:37 +01:00
Gilles De Mey
5e25afe6e9
Alerting: New settings page (#84501) 2024-05-03 17:42:42 +02:00
Gilles De Mey
7a12c5e0ef
Alerting: Add OAuth2 to HTTP settings for vanilla Alertmanager / Mimir (#87272)
add OAuth2 to HTTP settings for vanilla Alertmanager / Mimir
2024-05-03 13:23:37 +02:00
Gilles De Mey
12fa9e56e6
Alerting: Fix max alerts (#87271) 2024-05-03 13:22:42 +02:00
Gilles De Mey
1d06f33a8e
Alerting: Prevent search from locking the browser (#87132) 2024-05-02 14:41:33 +03:00
Tom Ratcliffe
b0f6913ef6
Alerting: unify alert rule actions between list and detail view (#86071)
* Add mock method for getting a plugin

* Update tests to find "more" button via label

* Remove test for Silence action in rule details

* Unify alert rule actions to pull from same place

* Restore behaviour of only showing incident button when firing

* Fix identifier and pause permission/logic

* Remove TODO comment related to refactor

* Update snapshot for useAbilities

* Undo optional param

* Rename alert rule menu hook to component

* Refactor hook to component

* Rename Rule action buttons component

* Chore: update style syntax for RuleDetails

* Add tests for refactored alert rule menu

* Only re-fetch Grafana managed alerts after pausing/resuming

* Remove console log and check for extensions

* Improve share rule generation of GMA rules

* Rename component

* Update action

* Refactor plugins and fix tests

* lint

---------

Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-04-30 16:17:55 +01:00
Konrad Lalik
9369f07e32
Alerting: Immutable plugin rules and alerting plugins extensions (#86042)
* Add pluginsApi

* Add rule origin badge

* Make plugin provided rules read-only

* Add plugin settings caching, add plugin icon on the rule detail page

* Add basic extension point for custom plugin actions

* Add support for alerting and recording rule extensions

* Move plugin hooks to their own files

* Add plugin custom actions to the alert list more actions menu

* Add custom actions renderign test

* Add more tests

* Cleanup

* Use test-utils in RuleViewer tests

* Remove __grafana_origin label from the label autocomplete

* Remove pluginsApi

* Add plugin badge tooltip

* Update tests

* Add grafana origin constant key, remove unused code

* Hide the grafana origin label

* Fix typo, rename alerting extension points

* Unify private labels handling

* Add reactive plugins registry handling

* Update tests

* Fix tests

* Fix tests

* Fix panel tests

* Add getRuleOrigin tests

* Tests refactor, smalle improvements

* Rename rule origin to better reflect the intent

---------

Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
2024-04-30 10:34:52 +02:00
Gilles De Mey
b679a32fad
Alerting: Allow deleting contact points referenced only by auto-generated policies (#86800) 2024-04-29 17:48:54 +01:00
Tom Ratcliffe
0a02508415 Add more robust error handling for stringifying API responses 2024-04-29 14:15:48 +01:00
Tom Ratcliffe
a34d22dcbf Include alertmanager param on creation 2024-04-29 14:15:48 +01:00
Tom Ratcliffe
e0ee0b09db Add test to check that a broken alertmanager will handle errors correctly 2024-04-29 14:15:48 +01:00
Tom Ratcliffe
aa2f52a2a1 Tidy up error message handling 2024-04-29 14:15:48 +01:00
Tom Ratcliffe
fd07b3d431 Link silence test handlers together more clearly and test more cases 2024-04-29 14:15:48 +01:00
Tom Ratcliffe
a34c02fcf2 Address misc PR feedback 2024-04-29 14:15:48 +01:00
Tom Ratcliffe
9860117399 Add more fine grained tag invalidation/providing for Silences 2024-04-29 14:15:48 +01:00