IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity
30,663 Commits 5,416 Branches 554 Tags
476a2275051c8586cea3df2d246020c12554ea6e
Commit Graph

6556 Commits

Author SHA1 Message Date
Marcus Efraimsson
477d4197fb Chore: Improve save dashboard error messages (#35780) 
Includes panel and dashboard id in alert
extractor errors.
Logs all non-400 dashboard errors.

Fixes #35751
 2021-06-16 14:56:55 +02:00
Ganesh Vernekar
dcd4bf1615 Alerting: Fill the empty GeneratorURL (#35740) 
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
 2021-06-16 15:34:12 +05:30
Sofia Papagiannaki
e5a5b8e3fe Alerting: Fix updating alert rule properties with missing/zero values (#35512) 
* Fix deleting labels and annotations

* Add test

* Keep no data and error start if not provided

* Allow setting interval and for to zero during rule updates
 2021-06-15 20:55:25 +03:00
Sofia Papagiannaki
abe35c8c01 Alerting: Add error recovery during rule evaluations (#35450) 
* Alerting: Eval recovery after query failure

* Apply suggestions from code review
 2021-06-15 19:30:21 +03:00
gotjosh
f7ed35336d Alerting: Implement /status for the notification system (#33227) 
* Alerting: Implement /status for the notification system

Implements the necessary plumbing to have a /status endpoint on the
notification system.

* Add API examples

* Update API specs

* Update prometheus/common dependency

Co-authored-by: Sofia Papagiannaki <sofia@grafana.com>
 2021-06-15 19:14:02 +03:00
Carl Bergquist
b40e78a943 Instrumentation: add context.Context to the dashboard get flow. (#34955) 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
 2021-06-15 16:08:27 +02:00
Andres Martinez Gotor
6b786e7f68 Avoid log entry if not set for debug (#35741) 2021-06-15 15:03:24 +02:00
Andrej Ocenas
9a3e3014dd CloudWatch/Logs: Fix missing response data for log queries (#35724) 2021-06-15 14:42:55 +02:00
Will Browne
adbb15a3a7 Plugins: fix test with bad symlink target (#35737) 2021-06-15 13:53:09 +02:00
Will Browne
303352a89b Plugins: Ignore symlinked folders when verifying plugin signature (#34434) 
* add check + test

* fix test

* add manifest

* fix linter

* add nolint

* separate err cond checks

* only collect relevant plugin files

* skip symlinks

* refactor

* add missing test files + enable scanning Chromium.app/

* remove test since case already covered

* remove unnecessary changes from before

* refactor

* remove comment
 2021-06-15 11:55:47 +02:00
Domas
5b5cb94809 Fix: fix loading symbolically linked plugins (#35635) 2021-06-15 09:10:30 +03:00
Sofia Papagiannaki
c997f646cc Alerting: Fix alert migration RefID generation (#35667) 
* Alerting: Fix alert migration RefID generation

if the alert has more than 26 conditions

* Remove TODO comment

* Make similar change under pkg/expr
 2021-06-14 22:13:45 +03:00
Tobias Skarhed
7f882eea05 Login: Require user to not be signed in to get request password email (#35421) 2021-06-14 18:02:05 +02:00
Karl Persson
395b942134 Access Control: Add fine-grained access control to GET stats and settings handlers (#35622) 
* add accesscontrol action for stats read

* use accesscontrol middleware for stats route

* add fixed role with permissions to read sever stats

* add accesscontrol action for settings read

* use accesscontrol middleware for settings route

* add fixed role with permissions to read settings

* add accesscontrol tests for AdminGetSettings and AdminGetStats

* add ability to scope settings

* add tests for AdminGetSettings
 2021-06-14 17:36:48 +02:00
Kyle Brandt
8a3d7b6446 Alerting: Increase alertmanager_conf column size if mysql (#35657) 
fixes #35583
 2021-06-14 11:02:35 -04:00
Sofia Papagiannaki
423474325a Alerting: fix postgres migration on conflict (#35556) 2021-06-14 16:43:33 +03:00
Andres Martinez Gotor
7109285ac9 AzureMonitor: Use auth middleware for QueryData requests (#35343) 2021-06-11 17:02:24 +02:00
Karl Persson
36c997a625 Access Control: Add fine-grained access control to ldap handlers (#35525) 
* Add new accesscontrol action for ldap config reload

* Update ldapAdminEditRole with new ldap config reload permission

* wrap /ldap/reload with accesscontrol authorize middleware

* document new action and update fixed:ldap:admin:edit with said action

* add fake accesscontrol implementation for tests

* Add accesscontrol tests for ldap handlers

Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com>
 2021-06-11 15:58:18 +02:00
Marcus Efraimsson
0611207f3b Postgres/MySQL/MSSQL: Fix concurrent map writes panic (#35510) 
Fixes panic/fatal error concurrent map writes in SQL data sources when multiple 
queries are executed concurrently and you interpolate SQL query before executing it.

Fixes #35469
 2021-06-11 14:56:29 +02:00
Javier Palomo
6531424c72 Datasource: Add support for max_conns_per_host in dataproxy settings (#35520) 
Allow configuring dataproxy.max_conns_per_host for HTTP data sources.

Ref #35519
Ref #35257
 2021-06-11 14:18:08 +02:00
Sofia Papagiannaki
aa8e09d383 Revert "Test datasource: Returns always float values (#34986)" (#35316) 
This reverts commit 51afde34bd.
 2021-06-11 14:12:11 +03:00
Stephanie Closson
83f26e9ce2 Fix: only recurse a symbolic link if it is a directory (#35455) 
* only recurse a symbolic link if it is a directory

* added test for detecting valid plugins using lib dirs with symbolic links in them (like oracle)

* fix linting errors

* added extra checks as per code-review
 2021-06-10 10:25:07 -03:00
shuotli
05f3985108 Upgrade ARG API version (#35464) 2021-06-10 12:33:34 +02:00
ying-jeanne
a07c53b671 [dataframe] convert opentsdb response to dataframes (#35307) 
* draft pr convert opentsdb response to dataframes

* Add test for parse response and fix go lint

* Add test case for create request

* Use go-cmp in test

* Remove comment

Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>
 2021-06-10 12:14:25 +02:00
Marcus Efraimsson
d15d87db8a Datasource: Fix storing timeout option as numeric (#35441) 
#31871 introduced support for configuring timeout in seconds
for HTTP data sources. That had a bug where backend expected
a numeric timeout value where it was actually stored as a
string. This should resolve this by requiring input to be
numbers, storing input as numeric and falling back to string
value if there's no numeric value.

Ref #31871
 2021-06-10 10:27:14 +02:00
Erik Sundell
eff2410bae Cloudwatch: Fix duplicated time series (#35433) 
* make sure queries are only ran once

* test aliases

* use correct dates
 2021-06-10 10:23:17 +02:00
Ikko Ashimine
e3afb63e62 Chore: Fix typo in nodes.go (#35312) 
formating -> formatting
 2021-06-09 16:59:44 -07:00
Kyle Brandt
f4e9dcd40b Alerting/SSE: Fix "count_non_null" reducer validation (#35451) 
fixes error "reducer 'count_non_null' in condition 2 is not a valid reducer"
 2021-06-09 14:42:48 -04:00
Ryan McKinley
4b8d796c54 Live: avoid panic when type changes (#35394) 2021-06-09 11:15:42 -07:00
Dimitris Sotirakis
7cdf8b3705 HTTP Client: Introduce go-conntrack into http client provider (#35314) 
* Introduce go-conntrack into http client provider

* Fixes according to reviewer's comments

* Fixes according to reviewer's comments
 2021-06-09 18:13:21 +02:00
Andres Martinez Gotor
086309700e Fix missing defaultRegion (#35436) 2021-06-09 17:19:43 +02:00
Marc Bachmann
9a5e10e6fb Annotations: Fix sql annotation parsing for empty responses (#35367) 
* fix sql annotation parsing for empty responses

* fix backend when no data returned

* add back frontend changes

Co-authored-by: Ying WANG <ying.wang@grafana.com>
 2021-06-09 21:14:28 +08:00
Will Browne
873e20b7ae Plugins: Ignore trailing slash in root URL check (#35338) 
* ignore trailing slash in root URL check

* apply pr feedback
 2021-06-09 09:57:32 +02:00
idafurjes
1f5a28ec63 Chore: Remove global setting var from azure ad oath (#35040) 
* Remove global setting var from azure ad oath

* Remove more glob var from social

* Use GrafanaComURL from cfg
 2021-06-08 16:08:25 +02:00
Andres Martinez Gotor
d225323049 AzureMonitor: Use plugin SDK contracts (#34729) 2021-06-07 14:54:51 +02:00
ying-jeanne
edf2029b52 [Scuemeta] Fix cue schema load on windows (#35185) 
* fix the load basic schema

* fix windows unittest

* fix error return for get current path

* fix windows notation
 2021-06-07 18:58:47 +08:00
Sofia Papagiannaki
fba90b8f9b Alerting: Recact html responses (#35277) 2021-06-04 20:57:24 +03:00
Sofia Papagiannaki
8cda1f5153 Alerting: Allow rules with same title across folders (#35270) 
* Alerting: Allow rules with same title across folders

* Add test
 2021-06-04 20:45:26 +03:00
Giordano Ricci
7a304223e6 Elasticsearch: Fix min_doc_count value when alerting (#35254) 
* Elasticsearch: Fix min_doc_count value when alerting

* Add tests
 2021-06-04 16:42:00 +02:00
Sofia Papagiannaki
15c55b0115 Alerting: Fix notification channel migration and handle case when Alertmanager default configuration is absent (#35086) 
* Fix dashboard alert and nootifier migration for MySQL

* Fix POSTing Alertmanager configuration if no current configuration exists

in case the default configuration has not be stored yet
or has failed to get stored

* Change CreatedAt field type
 2021-06-04 15:52:41 +03:00
Agnès Toulet
5f6c172b5a Renderer: add version information (#34964) 
* Renderer: add version information

* fix alerting test
 2021-06-04 14:33:49 +03:00
Sergey Kostrukov
412bcf1fb0 AzureMonitor: fix Azure Resource Graph queries in Azure China (#35235) 
* Optimize Azure Monitor routes

* Update API version compatible with Azure China
 2021-06-04 12:29:18 +01:00
Chris Cowan
f580c9149c Elasticsearch: Add Top Metrics Aggregation and X-Pack support (#33041) 
* Elasticsearch: Add Top Metrics Aggregation

* Adding support for non-timeseries visualizations

* removing console.logs

* restoring loadOptions type

* Honor xpack setting

* Adding test for elastic_response

* adding test for query builder

* Adding support of alerting

* Fixing separator spelling

* Fixing linting issues

* attempting to reduce cyclomatic complexity

* Adding elastic77 Docker block

* Update public/app/plugins/datasource/elasticsearch/components/QueryEditor/MetricAggregationsEditor/MetricEditor.test.tsx

Co-authored-by: Giordano Ricci <grdnricci@gmail.com>

* refactoring MetricsEditor tests

* Fixing typo

* Change getFields type & move TopMetrics to a separate component

* Fix SegmentAsync styles in TopMetrics Settings

* Fix field types for TopMetrics

* WIP

* Refactoring client side to support multiple top metrics

* Adding tests and finishing go implimentation

* removing fmt lib from debugging

* fixing tests

* reducing the cyclomatic complexity

* Update public/app/plugins/datasource/elasticsearch/elastic_response.ts

Co-authored-by: Giordano Ricci <grdnricci@gmail.com>

* Update public/app/plugins/datasource/elasticsearch/hooks/useFields.ts

Co-authored-by: Giordano Ricci <grdnricci@gmail.com>

* Checking for possible nil value

* Fixing types

* fix fake-data-gen param

* fix useFields hook

* Removing aggregateBy and size

* Fixing go tests

* Fixing TS tests

* fixing tests

* Fixes

* Remove date from top_metrics fields

* Restore previous formatting

* Update pkg/tsdb/elasticsearch/client/models.go

Co-authored-by: Dimitris Sotirakis <dimitrios.sotirakis@grafana.com>

* Update pkg/tsdb/elasticsearch/client/models.go

Co-authored-by: Dimitris Sotirakis <dimitrios.sotirakis@grafana.com>

* Fix code review comments on processTopMetricValue

* Remove underscore from variable names

* Remove intermediate array definition

* Refactor test to use testify

Co-authored-by: Giordano Ricci <grdnricci@gmail.com>
Co-authored-by: Elfo404 <me@giordanoricci.com>
Co-authored-by: Dimitris Sotirakis <dimitrios.sotirakis@grafana.com>
 2021-06-04 11:07:59 +01:00
Will Browne
2e9ad871b3 remove incorrect use of grafana-cli logger (#35228) 2021-06-04 11:06:34 +02:00
Dimitris Sotirakis
4c8ce8a450 Scuemata: Checking json validity by enabling skipped tests (#34385) 
* Make sure we don't skip any tests - refactoring

* Remove commented lines

* Move test folder
 2021-06-04 08:18:03 +02:00
Ganesh Vernekar
8417088969 Alerting: Expand {{$labels.xyz}} template in labels and annotations (#35159) 
* Alerting: Expand `{{$labels.xyz}}` template in labels and annotations

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Fix annotation not updating for same alert

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
 2021-06-03 19:24:36 +02:00
Sofia Papagiannaki
eeb84d09c2 SSE: Change math expression to accept any value convertible to float (#34996) 
* SSE: Change math expression to accept any scalar value

* Apply suggestions from code review

* Update test

* Remove TODO
 2021-06-03 18:06:12 +03:00
Ganesh Vernekar
a30e60a0b8 Alerting: Do not hard fail on templating errors in channels (#35165) 
* Alerting: Do not hard fail on templating errors in channels

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Fix review

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
 2021-06-03 19:39:32 +05:30
Dimitris Sotirakis
1c49986b2f Chore: Remove endpoints that contain the slug field (#35104) 
* Chore: Remove endpoints that contain the slug field

* More cleanups

* Lint fixes

* Remove unnecessary funcs

* Cleanup frontend code

* Remove deprecated endpoints from docs

* Revert change according to reviewer's comments
 2021-06-03 16:20:13 +03:00
Ganesh Vernekar
aa4c5bbfe4 Alerting: Don't save Alertmanager config on migration when 0 channels (#35119) 
* Alerting: Don't save Alertmanager config on migration when 0 channels

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Fix review

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
 2021-06-03 15:07:34 +02:00