IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-09-05 04:40:13 -05:00
Code Issues Packages Projects Releases Wiki Activity
44,216 Commits 892 Branches 731 Tags
4ba83173ea9fdebe3b8910e026e7d888e061833f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Sofia PapagiannakiandIsabel 3a50d7ea84 Docs: Update HTTP API docs for nested folders (#67412) 
* Docs: Update HTTP API docs for nested folders

* Apply suggestions from code review

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
 2023-07-19 12:20:21 +03:00
Sofia Papagiannaki 32ff712e98 Swagger: Fix response for the search users endpoint (#71272) 
* Regenerate OpenAPI specs for fetching the latest changes

* Fix swagger annotations for search users API
 2023-07-13 11:35:03 +03:00
Sofia Papagiannaki e21872bb15 SQLStore: Fix regression in PostgreSQL connection string (#71368) 
* SQLStore: Fix connection string for PostgreSQL

* better testing
 2023-07-11 16:47:35 +03:00
Sofia Papagiannaki 22147c6230 NestedFolders: Do not perform guardian checks for subfolders (#69769) 
Nested folders: Do not perform guardian checks for subfolders

Permissions are inherited so if the parent has access then
the subfolder has access too
 2023-07-07 21:26:01 +03:00
Sofia Papagiannaki e82d437e0e Drone: Enable running go benchmarks on demand (#70359) 
* Add benchmark

* Run pkg/api benchmarks in CI

* Conditionally run benchmarks for provided go packages

* Bypass fork check for promotes
 2023-07-07 11:55:01 +03:00
Sofia Papagiannaki 74e87ccbbd SQLStore: Align SQLite IsUniqueConstraintViolation() with other backend implementations (#69224) 
* Add integration test for primary key and unique constrain violation

* Align SQLite IsUniqueConstraintViolation implementation with other backends
 2023-05-29 14:45:08 +00:00
Sofia Papagiannaki 633b7875e7 Chore: Ignore unique constrain failure when creating the main organization (#68644) 
Chore: Ignore unique constrain failure when creatin the main organization
 2023-05-18 11:26:29 +03:00
Sofia Papagiannaki 14fb4ff779 API: Add deprecation notice for updating folder UID (#68543) 
* API: Add deprecation notice for updating folder UID
 2023-05-16 18:28:18 +03:00
Sofia Papagiannaki d458292b66 Nested folders: Allow renaming a folder multiple times (#68379) 
Return folder version in response that is required for updating
the entry in the dashboard table.
 2023-05-16 16:41:14 +03:00
Sofia PapagiannakiandArati R. d883404f50 Nested folders: Fix missing URL from folder responses (#68082) 
* Nested folders: Set URL in folder responses always

* Apply suggestions from code review

Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
 2023-05-10 16:20:16 +03:00
Sofia Papagiannaki 9812ad2cb2 Chore: Upgrade Go to 1.20.4 (#67748) 
Upgrade Go to 1.20.4
 2023-05-04 10:52:43 +03:00
Sofia Papagiannaki 893bf08dcf Nested folders: Fix API response ordering when fetching subfolders (#67258) 
* Nested folders: Fix ordering when getting subfolders

* Update endpoint swagger description

* Modify test
 2023-04-27 17:24:47 +03:00
Sofia Papagiannaki 7dbcd5ecd0 NestedFolders: Return full folder hierarchy in Folder response (#66835) 
* Delete redundant struct

* Include parent folders in DTO

* Add test

* Update swagger
 2023-04-25 11:22:20 +03:00
Sofia Papagiannaki 3bc002cd27 API: Add add deprecation notice for getting folder by sequential ID (#67091) 
* API: Add deprecation notice

* Update Swagger/openAPI
 2023-04-25 10:33:47 +03:00
Sofia Papagiannaki 24696d593b Nested folders: Fix error response codes (#66943) 
* Nested folders: Fix error response codes

Fix error handling
 2023-04-20 17:47:51 +03:00
Sofia Papagiannaki 7688ac6712 Swagger: Fix and update specifications with the latest changes (#66847) 2023-04-20 17:47:19 +03:00
Sofia Papagiannaki 04370f92dc Annotations: Improve get tags query performance (#66182) 
* Add benchmark

* Add fix
 2023-04-18 13:27:40 +03:00
Sofia PapagiannakiIevaEmil Tullstedt
 		988a120d6d Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275) 
* Add features dependency to SQLBuilder

* Add features dependency to AccessControlDashboardPermissionFilter

* Add test for folder inheritance

* Dashboard permissions: Return recursive query

* Recursive query for inherited folders

* Modify search builder

* Adjust db.SQLBuilder

* Pass flag to SQLbuilder if CTEs are supported

* Add support for mysql < 8.0

* Add benchmarking for search with nested folders

* Set features to AlertStore

* Update pkg/infra/db/sqlbuilder.go

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>

* Set features to LibraryElementService

* SQLBuilder tests with nested folder flag set

* Apply suggestion from code review

Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com>
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
 2023-04-06 11:16:15 +03:00
Sofia Papagiannaki caac9838d8 Build: Fix Redis/Memcached integration tests (#64298) 
* Build: Fix integration cache tests

* Allow REDIS_URL with scheme

* Reduce cache integration tests timeout to 5m

* Apply suggestion from code review

* Run redis/memcached integration tests in OSS pipelines

* Change redis image
 2023-04-05 11:55:55 +03:00
Sofia Papagiannaki a270188f0c Nested folders: Fix moving folder under root (#65684) 
* Nested folders: Fix moving folder under root

* Add store test for not empty parent after update

* Modify folder and document store update implementation

Move folder only if NewParentUID is not nil

* Apply suggestion from code review
 2023-04-03 21:24:36 +03:00
Sofia Papagiannaki 3cd3bb00ec API: Fix "Updated by" Column in dashboard versions table (#65351) 
* API: Fix dashboard versions created by field

* Add tests

* Update OpenAPI specs

* Apply suggestion from code review
 2023-03-30 17:31:53 +03:00
Sofia Papagiannaki c65cd5833a Nested folders: Fix move (#65526) 
* Nested Folders: Fix move response

Fix JSON tags to be consistent with the GET endpoint

* Add API test for moving to root folder

* Allow move to root folder

* Fix failure message

* Update OpenAPI specification
 2023-03-30 11:46:11 +03:00
Sofia Papagiannaki 4ee0be6fdf Chore: Add function for detecting if the SQL driver supported CTEs (#64441) 
* Add interface method for detecting if the SQL driver supported CTEs

* Update nested folder store to call RecursiveQueriesAreSupported()
 2023-03-20 10:27:08 +02:00
Sofia Papagiannaki f5cb8c660e SQLStore: Fix setting query tries for integration tests (#64944) 
* SQLStore: Pass testinfra database configuration to the test database

* Add test

* Bypass gocyclo check for initTestDB
 2023-03-17 17:31:03 +02:00
Sofia Papagiannaki 41843464d1 SQLStore: Fix SQLite error propagation if query retries are disabled (#64904) 
* SQLStore: Add test when query retrying is disabled

* Fix condition

* Add test cases for sqlite3.ErrLocked
 2023-03-17 12:57:13 +02:00
Sofia Papagiannaki 43095d84e4 Snapshots: Fix deleting snapshot with non existent dashboard ID (#64345) 
* Add test for deleting snapshot for non existent dashboard

* Add test for failure to fetch guardian other than ErrDashboardNotFound

* Fix dashboard snapshot delete
 2023-03-08 10:12:02 +02:00
Sofia Papagiannaki e41311e8be Library elements: Add MySQL migration for increasing the column size (#63856) 
* Library elements: Add MySQL migration for increasing column size
 2023-03-06 12:13:30 +01:00
Sofia Papagiannaki fde96c91c1 Chore: Differentiate the ErrOrgNotFound error messages (#64131) 
* Better org not found error messages
 2023-03-06 09:57:46 +02:00
Sofia Papagiannaki e6e8351ee9 Chore: Remove CreateUserForTests() (#64125) 
* Chore: Remove CreateUserForTests

* Apply suggestion from code review
 2023-03-03 11:01:23 -05:00
Sofia Papagiannaki 89569be3a6 SQLStore: Fix wrong usage of xorm's insert functions in tests (#63850) 
* SQLStore: Fix InsertId

* Prefs: Fix Insert return value

* Fix tests

* Add guidelines
 2023-03-02 13:01:36 +02:00
Sofia PapagiannakiandJosh Hunt 8aae7be4e5 API: Enable serving Swagger UI by default and add docs and guidelines (#63489) 
* Enable serving Swagger UI by default

It used to be served behind the `swaggerUi` feature toggle.

* Remove `swaggerUi` feature toggle

* Add docs and guidelines for updating swagger

* Apply suggestions from code review

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
 2023-03-01 16:36:37 +02:00
Sofia Papagiannaki e643437ee6 Prometheus: Fix panic-ing when closing response body (#63895) 
Prometheus: Fix panicing when closing response body
 2023-02-28 13:08:01 -05:00
Sofia Papagiannaki 225c8dbba7 Chore: Fix fetching the General folder when nested folders is set and improve error handling (#62951) 
* Nested folders: Modify Get() not to fail fetching the General folder

* Add test
 2023-02-08 17:16:53 +02:00
Sofia Papagiannaki ee2878f189 Chore: Fix logging message in folder service (#62939) 2023-02-06 13:11:32 +02:00
Sofia Papagiannaki 4eaff63eda SQLStore: Fix folder migration for MySQL < 5.7 (#62521) 
* Nested folders: Do not skip integration tests

* SQLStore: Fix folder migration

It reduces the length of the title column to be equal with the respective
dashboard column.
 2023-02-02 16:21:25 +02:00
Sofia Papagiannaki 29d3e696f0 Swagger: Fix circular reference (#62673) 
* Swagger: Fix circular reference

* gitignore intermediate swagger file

* Update specs

* Do not generate specs when building the backend
 2023-02-02 13:18:04 +02:00
Sofia Papagiannaki adaf82ffb7 Nested Folder: Fix for SQLite not to overwrite the parent on restarts (#62709) 
Nested Folder: Fix for SQLite not to overwrite the arent on restarts
 2023-02-02 12:06:51 +02:00
Sofia Papagiannaki f143b0a5b2 Chore: Move folder store interface, implementation and test under pkg/services/folder (#62586) 
* Chore: Move folder store into folder service package

* Split folder and dashboard store implementations
 2023-02-01 15:43:21 +02:00
Sofia Papagiannaki f8bd13ffad Chore: Regenerate swagger and openapi specifications (#62561) 2023-01-31 11:00:45 +00:00
Sofia Papagiannaki a502a2d1f8 Nested folders: Enable folder migration (#61936) 2023-01-30 10:17:40 +00:00
Sofia Papagiannaki cd27562c76 Access control: Modify dashboard/folder resolvers so that return also the inherited scopes (#62025) 
* Access Control: Add folder service dependency to the dashboard/folder resolvers

* Expose the function fetching parents to folder interface

* Add generic prepend utility

* Modify dashboard resolvers to return inherited scopes
 2023-01-26 10:21:10 +02:00
Sofia Papagiannaki e5e8bb4dea Chore: Use same JSON tag casing everywhere for parent UID (#61935) 
Chore: Use same JSON tag casing everywhere for parent UID
 2023-01-24 10:20:28 +02:00
Sofia Papagiannaki c7a7ebd3e0 Chore: Drop search service dependency from folder service (#61789) 
* Chore: Drop search service dependency from folder service
 2023-01-23 14:09:09 +02:00
Sofia Papagiannaki c104cc7020 Chore: Split folder store and dashboard store interfaces (#61655) 
* update folder store mock

* Split folder store and dashboard store interfaces
 2023-01-19 18:38:07 +02:00
Sofia Papagiannaki 4b634fadcf Chore: Fix Swagger and OpenAPI specifications (#61669) 
* Add go-swagger annotations for route

* Re-generate Swagger and OpenAPI specs
 2023-01-18 17:49:07 +02:00
Sofia Papagiannaki b80c9bb974 Chore: Drop dashboard service dependency from folder service (#61614) 
* Chore: Drop dashboard dependency from folder service
 2023-01-18 17:47:59 +02:00
Sofia Papagiannaki f25d5199c5 Chore: Fix folder service tests (#61659) 
* Chore: Fix folder service tests
 2023-01-18 12:22:23 +02:00
Sofia Papagiannaki e2ed42c2a3 Nested folders: Do not expose the sequential ID from the folder store (#60702) 
* Nested folders: Do not expose the sequential ID from the folder store
 2023-01-06 16:04:17 +02:00
Sofia Papagiannaki 4df78cebc2 Nested Folders: Unify folder services (#60390) 
* Nested Folders: Unify folder services
 2022-12-20 17:38:09 +02:00
Sofia Papagiannaki 55b014974d Nested folders: Refactor folder update (#60323) 
* Nested folders: Refactor folder update

* Apply suggestions from code review
 2022-12-20 15:00:33 +02:00
Sofia Papagiannaki b1ef5ab320 Nested Folders: Support listing nested folder children (#58566) 
* Nested Folders: Support listing nested folder children

* Filter out subfolders with no permissions

* Apply suggestion from code review
 2022-12-19 10:52:04 +02:00
Sofia Papagiannaki 11d8bcbea9 Guardian: Introduce additional constructors (#59577) 
* Guardian: Use dashboard UID instead of ID

* Apply suggestions from code review

Introduce several guardian constructors and each time use
the most appropriate one.
 2022-12-15 16:34:17 +02:00
Sofia Papagiannaki efd827fd65 Chore: Trigger backend lint on bingo updates (#60380) 
Chore: Trigger backend lind on bingo updates
 2022-12-15 06:48:00 -05:00
Sofia Papagiannaki 341d7b01ee Login: Fix failure to login a new user via an external provider if quota are enabled (#60015) 
* Login: Fix failure to login a new user via an external provider if quota are enabled
 2022-12-09 12:30:27 +01:00
Sofia Papagiannaki e7b25baf46 Chore: Fix failing feature toggle test (#60030) 2022-12-08 16:24:01 +02:00
Sofia Papagiannaki 4259b6bf58 API: Fix delete user failure due to quota not enabled (#59875) 2022-12-06 15:02:01 +02:00
Sofia Papagiannaki 798a8ceb9c Nested folders: Fix delete (#59627) 
* Fix deleting subfolder

It used to fail with beause of missing signed in user

* Add logging

* fixup

* Fail request if deleting nested folder has failed

Before we only used to log the error

* Fix failing test

During failed nested folder creation
call the dashboard store deletion instead of the service one.
 2022-12-01 05:27:40 -05:00
Sofia Papagiannaki 933879a347 Chore: Delete accidentally committed test database (#59238) 2022-11-29 10:33:43 +02:00
Sofia Papagiannaki 8ab7ca45cd Nested folder: Fix for PostgreSQL (#59405) 
* Nested Folders: Fix PostgreSQL LastInsertId failure

* Fix children sorting

* Fix store tests
 2022-11-28 17:48:44 +02:00
Sofia Papagiannaki f5c41ea497 Nested Folders: More API fixes (#59316) 
* Nested Folder: Fix create, use camel case for JSON properties

* Fix get parents if the folder does not exist

* Add store test for get parents
 2022-11-24 13:28:53 -05:00
Sofia Papagiannaki 8e6d343981 Nested Folders: Some API fixes (#59298) 
* Nested Folders: Fix API responses

* Fix panic during deletions

* Add test
 2022-11-24 08:59:47 -05:00
Sofia Papagiannaki f3da48bd50 SQLStore: Refactor query retries to use exponential backoff (#58559) 2022-11-24 13:12:50 +02:00
Sofia Papagiannaki ad96b240fc Nested Folder: Enforce maximum nested folder depth (#59213) 
* Nested Folder: Enforce maximum nested folder depth

* Cleanup

* Fix logging
 2022-11-23 09:44:45 -05:00
Sofia Papagiannaki 0af96936be Nested Folders: Do not refer to the configuration for checking for the flag (#59197) 
* Nested Folders: Do not refer to the configuration for checking for the flag

Use always features.IsEnabled() instead

* Depend on the interface instead
 2022-11-23 06:16:00 -05:00
Sofia Papagiannaki 02b6b09121 Nested Folders: Set user in the API level (#59148) 2022-11-23 11:13:47 +02:00
Sofia Papagiannaki 9926931d40 Nested Folder: Include URL into the GET response (#59099) 2022-11-22 07:04:09 -05:00
Sofia Papagiannaki 15561b83e4 Nested Folders: Make parent_uid column nullable (#59035) 
Nested Folders: Make parent UID column nullable
 2022-11-21 15:24:20 +01:00
Sofia Papagiannaki 18738cfd77 Quota: Fix failure in store due to missing scope parameters (#58874) 
Quota: Fix failure in store
 2022-11-17 18:08:25 +01:00
Sofia Papagiannaki ab36252c86 Quota: Fix failure when checking session limits (#58865) 2022-11-17 00:30:27 +01:00
Sofia Papagiannaki 93b4b9154e Chore: Restore folder properties (#58743) 
* Chore: Fix folder URL

* Restore more folder properties

* Fixup
 2022-11-15 12:58:12 +02:00
Sofia Papagiannaki 9855e74b92 Chore: Refactor quota service (#58643) 
Chore: Refactor quota service (#57586)

* Chore: refactore quota service

* Apply suggestions from code review
 2022-11-14 21:08:10 +02:00
Sofia PapagiannakiSerge ZaitsevidafurjesIda Furjesova
 		bf5a08e039 API: Support creating a nested folder (#58508) 
* API: Support nested folder creation

* Update swagger

* fixup

* Update pkg/api/dtos/folder.go

Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com>

* Fix some tests

* create legacy folder url from title and uid

Co-authored-by: idafurjes <36131195+idafurjes@users.noreply.github.com>
Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com>
Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>
 2022-11-10 04:41:03 -05:00
Sofia Papagiannaki 000b4f878d Chore: Retry queries by default in tests (#58535) 2022-11-09 19:56:47 +02:00
Sofia Papagiannaki 4d2be7a277 Nested Folders: Use recursive query if the driver supports it (#58178) 
* Nested Folders: Try first recursive query and fallback if it's not supported

* Apply suggestion from code review

Fix error msgID
 2022-11-08 14:53:05 -05:00
Sofia Papagiannaki 96cdf77995 Revert "Chore: Refactor quota service (#57586)" (#58394) 
This reverts commit 326ea86a57.
 2022-11-08 11:52:07 +02:00
Sofia Papagiannaki 326ea86a57 Chore: Refactor quota service (#57586) 
* Chore: refactore quota service

* Apply suggestions from code review
 2022-11-08 10:25:34 +02:00
Sofia Papagiannaki d131733f55 Nested Folder: Modify store Update() (#58183) 
* Nested Folder: Modify store Update()

* fixup
 2022-11-04 10:04:24 +01:00
Sofia Papagiannaki 5c973e58bd Nested Folders: Add tests for store methods (#57662) 
* Nested Folders: Add store tests

* Fix parent order

* Fix update

* skip tests!

* Export test helpers for now
 2022-11-03 14:21:41 +01:00
Sofia Papagiannaki 40a59c2793 Chore: Update developer guide for running integration tests (#57758) 2022-10-27 17:18:20 +03:00
Sofia PapagiannakiandChristopher Moyer 46fb4081ba SQLStore: Optionally retry queries if sqlite returns database is locked (#56096) 
* SQLStore: Retry queries if sqlite returns database is locked

* Configurable retries

* Apply suggestions from code review

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
 2022-10-17 21:23:44 +03:00
Sofia Papagiannaki 97730aec10 Chore: Bump golang.org/x/text (#56841) 2022-10-13 11:26:25 +03:00
Sofia Papagiannaki 7e24e19230 Swagger: Remove license (#56716) 2022-10-11 17:06:36 +03:00
Sofia Papagiannaki 4cdbfb7606 Chore: Timeout integration package tests faster (#56287) 2022-10-10 09:27:04 +02:00
Sofia Papagiannaki bba6eb1f2d Chore: update latest.json to 9.1.7 (#56315) 2022-10-04 19:32:13 +03:00
Sofia Papagiannaki 91b4ce08a9 Update github.com/labstack/echo/v4 (#56226) 2022-10-04 14:31:05 +03:00
Sofia Papagiannaki 6099e55e62 SQLStore: Remove call to deleted store.NewSession() (#56025) 2022-09-29 10:17:33 -04:00
Sofia Papagiannaki 8b77ee2734 SQLStore: Ensure that sessions are always closed (#55864) 
* SQLStore: Ensure that sessions are always closed

Delete `NewSession()` in favour of `WithDbSession()`

* Add WithDbSessionForceNewSession to the interface

* Apply suggestions from code review
 2022-09-29 15:55:47 +03:00
Sofia Papagiannaki b749cef78e Chore: Remove unnecessary transaction (#55819) 2022-09-28 18:50:19 +03:00
Sofia Papagiannaki d0e7765c6a Annotation: Optionally allow storing longer annotation tags (#54754) 
* Annotation: Optionally allow longer annotation tags

* Do not accept configuration lower than today's default (500)

* Apply suggestion from code review
 2022-09-23 06:04:41 -04:00
Sofia Papagiannaki 2f14575dd3 Chore: Move annotations cleanup to the annotations service (#55618) 2022-09-22 15:27:48 +03:00
Sofia Papagiannaki 55ef34bee4 Instrumentation: Add api/health to the unnamed handlers (#55478) 2022-09-22 13:03:20 +03:00
Sofia Papagiannaki 754eea20b3 Chore: SQL store split for annotations (#55089) 
* Chore: SQL store split for annotations

* Apply suggestion from code review
 2022-09-19 10:54:37 +03:00
Sofia Papagiannaki b157fcdd87 Chore: fix formating for swagger definitions (#54993) 2022-09-12 10:40:35 +03:00
Sofia Papagiannaki e57fd88644 Swagger: restore missing enterprise endpoints (#54765) 2022-09-06 16:26:55 +03:00
Sofia Papagiannaki 950715b255 API: Do not expose user input in datasource error responses (#53483) 2022-09-05 16:10:45 +03:00
Sofia Papagiannaki ae101bf935 Alerting: Fix migration (#53253) 2022-08-03 11:41:18 -04:00
Sofia Papagiannaki 5fec6cc4f5 API: Fix snapshot responses (#52998) 
* API: Fix response status when snapshots are not found

* API: Fix response status when snapshot key is empty

* Apply suggestions from code review
 2022-08-03 10:31:23 -04:00
Sofia Papagiannaki 3713a193d8 Chore: Fix Makefile target dependency (#53165) 2022-08-02 19:42:48 +03:00
Sofia Papagiannaki 3f58e8ec2a Chore: Cleanup Makefile (#53037) 
Remove redundant reference to deleted folder pkg/api/docs/definitions
 2022-08-01 16:31:49 +03:00
Sofia Papagiannaki 87004cc22d API: Do not expose user input in datasource error responses (#52992) 2022-07-29 08:46:51 -04:00