Gilles De Mey
4a568769e7
Alerting: fix flakey test ( #46845 )
2022-03-22 21:20:58 +01:00
Nathan Rodman
5a25ada3d0
Alerting: Add FGAC for Silences ( #46479 )
...
* add FGAC actions for silences table
* redirect users without permissions
* hide silence button in rules list
* add permissions checks to routes
* add read action for silences page
* add permissions checks to navigation
* add additional access checks for rule viewing
* create authorize component
* add tests for silences
* hide alerting nav for users without access
* nolint: gocyclo
* add permission check to alert details
* add check for external instances
* remove unecessary new lines
* use correct actions for alert details
* fix failing tests
Co-authored-by: Yuriy Tseretyan <yuriy.tseretyan@grafana.com>
2022-03-21 16:54:37 -07:00
Santiago
18c1c6ca6a
fix double slash in share link ( #46757 )
2022-03-21 08:00:54 -06:00
Gilles De Mey
64d4e6fcaa
Alerting: visual alert type picker ( #46111 )
2022-03-18 14:33:32 +01:00
Ikko Ashimine
d887068904
Alerting: Fix typo in matchers.test.ts ( #46641 )
...
occurence -> occurrence
2022-03-16 19:15:23 +00:00
Yaelle Chaudy
0b0d612372
A11y : Fix option panes not accessible when collapsed ( #46405 )
...
* Turned div into text button to make it accessible
* Only icon as button to avoid embedded buttons with overrides delete button
* use icon in Button directly
* Removed unused import
* moving id for labelledBy to h6 elem instead of icon
* Tweaking style, bigger caret
* Fixed aria-expanded
* Modifying and using CollapseToggle from unified alerting
* Added restOfProps to CollapseToggle
2022-03-14 15:37:13 +01:00
Konrad Lalik
2409405c34
Alerting: Integrate alerts with folders ( #45763 )
...
* Add Alert rules tab
* Add pagination and a simple name-based filtering
* Add name and label based filtering
* Improve pagination, handle the no results case
* Add tests for alerts folder view
* Add label filtering by clicking a tag
* Add tests for matcher to string method
* Add sorting, improve styles
* Use simple Select component for sorting
* Update default page size
* Remove unused code
* Use existingc thunk
* chore: update swagger spec
* Revert "chore: update swagger spec"
This reverts commit ee79ec7341
2022-03-14 15:21:29 +01:00
Torkel Ödegaard
79e5e5c024
DataSource: Default data source is no longer a persisted state but just the default data source for new panels ( #45132 )
...
* PanelEdit: Change the meaning of default data source to be just that the default for new panels
* Added migration, and also migration for annotation datasource prop to data source refs
* fix
* Fixing tests
* Fixes to annotation
* Fixing unit test
2022-03-08 08:56:12 +01:00
Gilles De Mey
a9b1a964b0
Alerting: adds support for federated rules ( #46037 )
2022-03-04 10:16:13 +01:00
Nathan Rodman
e814e7364b
Alerting: fix alert groups grouping ( #45012 )
...
* fix multiple non-grouped groupings
* drop duplicate alerts
* add test for multiple groups without labels
Co-authored-by: gillesdemey <gilles.de.mey@gmail.com>
2022-02-28 09:50:17 -08:00
Peter Holmberg
4ef58e595c
Alerting: Add validation to slack contact point ( #45618 )
...
* add requiredifempty
* rename field, fix logic
* update mockdata
* remove logs
* update test
* fix json expected payload in e2e tests
* fix test
* fix test again
Co-authored-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>
2022-02-25 15:10:21 +01:00
Peter Holmberg
9d61dcb02b
Alerting: Disable Alertmanager picker if there's only one Alertmanager ( #45781 )
2022-02-25 11:17:28 +01:00
Konrad Lalik
d6c580e338
Alerting: Lotex alert groups removal ( #45150 )
...
* Add lotex group removal UI
* Connect UI to delete group action
* Add rules' refreshing after deletion of a group
* Improve confirmation message
* Add tests for RulesGroup
* Remove redundant check
2022-02-24 11:31:36 +01:00
kay delaney
59317a22e4
AppNotifications: Migrate usage of deprecated appEvents.emit method to redux actions ( #45607 )
2022-02-23 11:31:15 +00:00
Jack Westbrook
d0d5304662
Revert "Update dependency react-hook-form to v7.26.1" ( #45761 )
...
* Revert "Update dependency react-hook-form to v7.26.1 (#43670 )"
This reverts commit 175891a5e3
2022-02-23 12:22:45 +01:00
renovate[bot]
175891a5e3
Update dependency react-hook-form to v7.26.1 ( #43670 )
...
* Update dependency react-hook-form to v7.27.0
* fix type errors for alerting components with new react-hook-form version (#45341 )
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Nathan Rodman <nathanrodman@gmail.com>
2022-02-18 17:13:31 +01:00
Peter Holmberg
0502a84922
Alerting: Add choice to external alertmanagers ( #45157 )
...
* implement alertmanagersChoice
* return empty array and remove non null assertion
2022-02-17 12:47:38 +01:00
Torkel Ödegaard
2b9e46d1f8
Angular: Option to disable angular support and isolate angular dependencies ( #45421 )
...
* Angular: Initial setting that disables angular, load angular support in separate chunk
* Load angular panels on demand
* Load alerting in separate chunk only when angularSupportEnabled
* progress, do not export core_module if angular disabled
* Progress
* Update public/app/features/plugins/built_in_plugins.ts
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
* Removing remaining usage of angular from outside angular app (not counting plugins)
* Update config and docs
* Fix sample.ini
* Update public/app/features/alerting/AlertTab.tsx
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
* Fixing prettier issue
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
2022-02-16 17:14:33 +01:00
Konrad Lalik
1886a59a12
Fix notification routes editing when filters are applied ( #45380 )
...
* Fix route editing when filters are applied
* Fix route delete operation, reset expanded item when filters change
* Refactor edit and delete functions, add tests
* Fix comment
2022-02-16 11:03:53 +01:00
Torkel Ödegaard
ed5b2e5210
Move QueryPartDef out from angular app ( #45386 )
2022-02-15 14:20:50 +01:00
Gilles De Mey
651bb773db
Alerting: do not unescape external AM label values ( #45334 )
2022-02-15 13:57:00 +01:00
Torkel Ödegaard
089d6d7f7a
Alerting: Fixing minor styling issues ( #45236 )
2022-02-11 12:34:32 +01:00
Torkel Ödegaard
cc49537965
Alerting: Refactor ActionIcon to use our normal Button and LinkButton components ( #45227 )
...
* Alerting: Refactor ActionIcon to use our normal Button and LinkButton components
* Fixed test
* Fixed test
2022-02-11 10:12:26 +01:00
Josh Hunt
c7a5d2c5c7
Chore: Remove our typeAsJestMock in favor of jest.mocked ( #45114 )
2022-02-09 23:50:59 +01:00
Nathan Rodman
f019ee886a
Alerting: fix act warnings in alerting tests ( #45113 )
...
* fix act warnings in alerting tests
* remove unnecessary angular dep
2022-02-09 08:47:50 -08:00
Torkel Ödegaard
7c0b453e19
Tooltips: Make tooltips non interactive by default ( #45053 )
...
* Tooltips: Make tooltips non interactive by default
* More updates and cleanup
* Update
* Make time range picker tooltip interactive
* Fix issue
* Trying to make Receivers test faster
* Make JSONCell tooltip interactive
2022-02-08 22:58:20 +01:00
Roy C
3d0cff5410
Alerting: remove error banner when Prometheus ruler is not supported ( #44571 )
2022-02-08 21:03:14 +01:00
Konrad Lalik
1cf48618de
Alerting: Improve Contact Points error handling ( #44888 )
...
* Add 400 and 408 errors handling to display useful error message
* Add generic error handling
* Improve type guard
2022-02-08 17:08:27 +01:00
Gilles De Mey
1680e284e5
Alerting: validate namespace and groupname for Grafana manages and Lotex alerts ( #44872 )
2022-02-04 15:04:11 +01:00
Josh Hunt
de7a920967
Chore: Suppress messages and logs from tests ( #44629 )
...
* Suppress "not wrapped in act()" warning in UserPicker test
* Add menuShouldPortal to AmRoutesExpandedForm to suppress deprecation warning
* use forwardRef in alerting ActionIcon to suppress ref warning
* Add menuShouldPortal to alerting GroupBy to suppress deprecation warning
2022-02-04 12:36:44 +11:00
Gilles De Mey
c1a0c2664c
Alerting: add custom grouping to Alert Panel ( #44559 )
...
Co-authored-by: Peter Holmberg <peterholmberg@users.noreply.github.com>
2022-02-03 19:07:27 +01:00
renovate[bot]
d87cd6f26c
Update dependency prettier to v2.5.1 ( #43473 )
...
* Update dependency prettier to v2.5.1
* prettier fixes
* chore(toolkit): bump prettier to 2.5.1
* style(eslint): bump grafana config to 2.5.2 in core and toolkit
* style(mssql-datasource): fix no-inferrable-types eslint errors
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2022-02-02 12:02:32 +00:00
Konrad Lalik
69e4796504
Alerting: Split legacy and unified routing configuration ( #44641 )
...
* Disable add alert menu entry for legacy alerting
* Split legacy and unified routing configuration
* Fix fallback routes configuration
2022-02-02 10:57:43 +01:00
Peter Holmberg
552c24a66e
Alerting: Show affected alert rules when creating Silence ( #44307 )
...
* first things
* show affected rules when creating silence
* revert typescript bump
* fix yarn lock
* fix import order
* fixing tests
* some layout for affected alerts
* fix test
* add default description
* review part 1
* Add a badge for number of affected alerts
* fix test
* remove blank space
2022-02-01 09:49:05 +01:00
Konrad Lalik
88f3dff6d2
Alerting: Fix moving alert rules to a different folder ( #44533 )
...
* Prevent rule deletion when creation in a new folder fails
* Fix handling duplication of rules when moving between folders
* Add unit test for unique name generator
* Fix typo
2022-01-31 12:09:06 +01:00
Gilles De Mey
26ddeaf3d7
fix: multiple queries in alerting regression ( #44585 )
2022-01-28 16:05:19 +01:00
Konrad Lalik
c6e6e92a80
Alerting: Filtering for notification policies ( #44363 )
...
* Add filtering by matching label
* Add label and contact based filters to Notification policies
* Improve filters UI, add clear filters option
* Add clearing of filters before switching to adding mode
* Move filtering code to the AmRoutesTable component
* Fix the clearing of silences filter
* Remove key-based input resetting
* Use uniqueId for input key generation
* Add tests for notification policies filtering
2022-01-28 09:40:05 +01:00
Peter Holmberg
a7423d8760
Alerting: Fix Card link in legacy alerting items ( #44094 )
...
* remove href
* revert yarn.lock
2022-01-24 16:16:55 +01:00
Timur Olzhabayev
c3f69cc4d9
Adding reload to datasourceSrv ( #44217 )
2022-01-24 10:45:05 +01:00
Christopher Norris
f2da409703
Chore: fix typo ( #44188 )
2022-01-21 15:58:40 +01:00
Jean-Philippe Quéméner
8ee3f59cd4
Alerting: recognize Cortex datasources correctly in the frontend ( #44316 )
...
* Alerting: always use msg field for user facing errors
* fix: revert front-end Cortex detection
Co-authored-by: gillesdemey <gilles.de.mey@gmail.com>
2022-01-21 15:44:11 +01:00
Kyle Brandt
74193b3c1b
SSE: Remove beta tooltip ( #43912 )
2022-01-20 08:52:36 -05:00
Nathan Rodman
b98a1d79cf
Alerting: mute timing improvements ( #43940 )
...
* mute timing table ui fixes
* add options for CTA to use link
* fix validation for time range
2022-01-18 10:46:36 -08:00
Gilles De Mey
bd9df4f829
Alerting: show deleted datasource ( #43891 )
2022-01-17 14:30:00 +01:00
Gilles De Mey
55ec05b560
Alerting: remove dead code ( #43956 )
2022-01-13 16:23:49 +01:00
Konrad Lalik
c829535f14
Alerting: Fix the silence url's matcher parameters ( #43898 )
...
* Split silence matchers parameter into a separate entry for each label
* Unify the silence link creation
* Remove duplicated matchers when parsing to/from query params
* Add tests for matchers
* Add a comment with a duplication removal explanation
* Improve label duplication comment
* Remove redundant code
* Use uniqBy to simplify the code. Rename matchers parameter
* Fix Silence test data
2022-01-13 10:48:13 +01:00
Peter Holmberg
fc037e1798
Alerting: Add delete to rule edit ( #43673 )
2022-01-11 09:46:21 +01:00
Gilles De Mey
7b841c7947
Alerting: run validation before testing contact point ( #43721 )
2022-01-10 13:28:36 +01:00
Gilles De Mey
be61f192c8
Alerting: add support for absolute URLs in ActionIcon ( #43367 )
2022-01-10 13:11:43 +01:00
Nathan Rodman
0dd88d9480
only show datasources that support alerting in query editor ( #43776 )
2022-01-07 09:27:20 -08:00
