Commit Graph

8764 Commits

Author SHA1 Message Date
Matias Chomicki
62a87885fc Annotations: fix testid attribute (#66877) 2023-04-19 20:43:46 +00:00
Giordano Ricci
47121e6e8a Explore: make ExploreToolbar a function component (#66867) 2023-04-19 20:52:08 +01:00
Josh Hunt
e0c5b4f0e0 NestedFolders: Basic item selection (#66843)
* NestedFolders: Item selection state

* Select children in state

* Unselect parents when children are unselected

* remove unneeded comment

* tests

* tidy test a little bit

* tidy test a little bit

* tidy test a little bit

* tidy test a little bit

* tidy test a little bit
2023-04-19 22:44:07 +03:00
Kristina
d1a918489e Explore: Remove click tracking for external links (#66801)
Remove click tracking for external links
2023-04-19 10:40:25 -05:00
Ivana Huckova
33186e3e23 Explore: Fix using data source line limit when opening logs sample in split view (#66601)
* Logs sample: Use data source max lines setting when opening logs in split view

* Add internal tags
2023-04-19 17:04:47 +02:00
Ivan Ortega Alba
c7af53b79f [Under FF] New DS Picker with advance mode (#66566)
* Add a wrapper to switch between the previous and new DS picker depending on the feature toggle advancedDataSourcePicker.

* Add a new component to represent the modal DS picker, which we will refer as advanced DS picker
Integrate this into the Edit panel, for now, until we're ready to replace everywhere the grafana-runtime DS picker by the wrapper.

* Replace Drawer component with the dropdown

* Adjust the first version of the styles to fit into this Figma design

* Adjust the design of the FileDropzoneDefaultChildren to match with the new DS modal but everywhere else is used nowadays.

---------

Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>
2023-04-19 16:08:09 +03:00
Torkel Ödegaard
ee247e33b4 AngularMigration: Clear old angular panel props when auto migrating (#66719)
* AngularMigration: Clear old angular panel props when auto migrating

* Update test name
2023-04-19 13:47:55 +02:00
Joey
c13ec0fc15 Tracing: Span filters reset filters and button (#66781)
* Reset filters and button

* Add tests
2023-04-19 11:58:00 +01:00
Torkel Ödegaard
ba92f6f98a AppRootPage: Reduce flickering while loading plugin (#66799)
* AppRootPage: Reduce flickering while loading

* Use current layout
2023-04-19 12:10:57 +02:00
Torkel Ödegaard
5c129455f6 PluginBrowse: Fix double margin due to paragraph tag inside description (#66776) 2023-04-19 11:10:03 +02:00
Andres Martinez Gotor
98778289cb Catalog: Show install error with incompatible version (#65059) 2023-04-19 10:22:24 +02:00
Ryan McKinley
9452c0d718 Annotations: Support filtering the target panels (#66325)
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-04-18 15:39:30 -05:00
Joey
743fdc159b Traces: Trace view header tweaks (#66049)
* Update header info

* Modify content

* Update test

* Update test

* Add back url and remove tooltip

* Update css
2023-04-18 17:56:14 +01:00
Ivana Huckova
f612a72f96 Loki: Update log context UI (#66730)
* fix logrowcontext scrolling behavior

* Loki: Update loki context ui menu

* Update

* Add test, update

* Use escapeLabelValueInSelector when displaying labels

* Update test for new appliedContextFilters

---------

Co-authored-by: Sven Grossmann <svennergr@gmail.com>
2023-04-18 15:59:22 +02:00
Ashley Harrison
0741f47876 Navigation: Move SectionNav to AppChrome (#64391)
* move section nav to app chrome

* unit tests

* Move SectionNav to AppChrome folder

* fix duplicate variable rendering

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-04-18 14:58:00 +01:00
Gilles De Mey
2cec402647 Alerting: Fix share URL for Prometheus rules on subpath (#66752) 2023-04-18 15:47:57 +02:00
Josh Hunt
28b8d564fe NestedFolders: Add link to new work-in-progress UI (#66684) 2023-04-18 13:42:40 +01:00
Kristina
9d69d3173f Correlations: Add transformation editor (#66217)
* There was an attempt

* Change disabled state based on transformation type

* Add validation to transformation type

* Revert "Add validation to transformation type"

This reverts commit 2188a3d9a93aec5eeafcdd40510391ba1a53671a.

* Add validation to transformation type

* Move transformations editor to a separate file

* Make name more descriptive

* Ensure type dropdown has always the same width

* Add tooltips around transformation options

* Slight style changes

* Remove autofocus on append, integrate read only to transformationeditor, save values that disappear so they come back

* Remove yaml changes

* Have variable background color work with alternating colors on different themes

* Make expression required for regular expressions

* Remove unused empty form object

* Fix bug about transformation’s values saved in memory

* Better validation formatting for expression

* Add labels and (for now) non working test, attempt to fix saved transformation delete/add bug

* Fix datalink comment

* Remove fancy CSS due to background change

* Fix deleting saved transformation bug, finish tests

* Consolidate transformation types

* Double check aria labels

* Change aria labels, fix tests

* Add a transformation with the create correlation test

---------

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
2023-04-18 07:17:30 -05:00
Levente Balogh
652fd8889e Chore: Remove accidental console.log statements (#66725)
chore: remove accidental console.log statements
2023-04-18 09:59:11 +02:00
Ryan McKinley
cdb49887d8 HelpWizard: Use scenes to render dashboard inline dashboard (#64936)
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-04-17 23:45:14 -07:00
Levente Balogh
c22c31ed13 Plugins: Fix plugin catalog filtering (#66663)
* fix: make the filters work together

* tests: add more tests
2023-04-18 09:15:35 +03:00
Adela Almasan
45e1bfe421 Testdata: Update testdata annotations editor (#66620)
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2023-04-18 01:05:09 +03:00
Ryan McKinley
09f03e92bf FieldValues: Use simple array in panel visualizations (#66706)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2023-04-17 14:46:29 -07:00
Ryan McKinley
50cb4f8998 FieldValues: Use simple array in transformations and grafana/data (#66702)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2023-04-17 14:02:51 -07:00
Ashley Harrison
ab08b4f7f2 Chore: Clean up NavModel interface (#66548)
* clean up navmodel interface

* remove concept of sections from NavModel interface

* clean up applinks
2023-04-17 16:01:32 +01:00
Sonia Aguilar
8485deb2c0 Alerting: Split silences view expired/not-expired (#66562)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-04-17 16:30:41 +02:00
Eric Mustin
6462c81f81 Trace View: Update the queryType to traceql for checking if same trace when clicking span link (#66645)
* TraceView: update the queryType to traceql for checking if same trace when clicking span link

* TraceView: linting

* TraceView: remove traceid check completely
2023-04-17 14:17:53 +01:00
Kyle Cunningham
6ffc0c3eda SQL Datasources: Fix saving of max idle connections and max connection lifetime (#66662)
Add brackets around property name so that it's dynamic
2023-04-17 18:46:22 +07:00
Sven Grossmann
9a4c7ef758 Logs: Fix LogContext scrolling behavior (#66654)
fix logrowcontext scrolling behavior
2023-04-17 13:05:56 +02:00
Josh Hunt
9b15c79e19 NestedFolders: Virtual tree view (#66102)
* poc for virtual tree

* remove my silly debug stuff

* wip

* style table

* improve styles

* fix

* start to split tree into seperate component

* cleanup unused function

* split into more components

* more better

* secondary color type column

* simple tests for DashboardsTree

* restore styles from dodgy rebase

* remove my weirdo text component thing
2023-04-17 11:08:24 +01:00
Kyle Cunningham
92d92187d9 SQL Datasources: Update Max Connection and Max Idle Connection Defaults to 100 and add auto mode (#65834)
* Update connection configuration for SQL datasources

* Working auto state for connection numbers

* Add migration

* Use defaults from constants file

* Remove dead code

* Add tests and restructure useMigrateDatabaseField

* Update function names

* Update docs

* Make sure we don't continually issue updates

* Update docs

* Use onOptionsChnage in ConnectionLimits

* Update docs

* Clean up docs

* Update migration

* Fix default values in docs

* Fix spacing issue

* Fix test

* Update default values for SQL connections

* Include consts

* Allow override for default SQL datasource connection parameters

* Fix linter errors

* Remove extra @ts-ignore

* Centralize logic for default values

* Remove debugging

* Remove unecessary function

* Update configuration docs

* minor suggested change

* Fix comment misspelling

* Remove unecessary default setting code

* Update docs to indicate that code was included for backport version

* Remove dead code

---------

Co-authored-by: lwandz13 <larissa.wandzura@grafana.com>
2023-04-17 11:44:05 +03:00
Armand Grillet
075070db3e Alerting: Update legacy alerting warning (#66269)
* Update legacy alerting warning

* Apply suggestions from code review

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update DeprecationNotice.tsx

* silly linter

* Clarify alerting deprecation

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
2023-04-17 11:02:29 +03:00
Joey
9391700d84 Traces: Span filtering (#65725)
* Filters

* Service/span/duration filters

* Renames for focused span and matches

* Tag filters and new component

* Tag filtering

* Multiple tags and enable next/prev appropriately

* Enum, renames, fixes

* Clean up unecessary props

* setFocusedSearchMatch

* Faster options

* Perf enhancements and cleanup

* General improvements to tags etc

* Updates to filtering

* Add datasourceType in next/prev

* Integrate TracePageSearchBar with NewTracePageSearchBar

* Design tweaks

* Update sticky elem and header design

* Fix tests

* Self review

* Enhancements

* More enhancements

* Update tests

* tests

* More tests

* Add span filters to docs

* Update image link

* Update docs

* Update buttonEnabled and text

* PR review

* Update sticky header

* Doc updates

* Set values for service/span name

* Buffer and dash update
2023-04-17 08:30:27 +01:00
Ryan McKinley
39c04a8e36 Chore: Remove deprecated dashboardId from panel query runner (#64786) 2023-04-14 16:50:10 -07:00
Sven Grossmann
a6a7cebbe5 Logs: Redesign and improve LogContext (#65939)
* Logs: Add new LogRowContext types to grafana/data

* use right type for `RowContextOptions`

* add missing renames

* add show context modal

* no need to call

* removed unused css

* sort properties

* rename

* use correct

* use

* add tests for

* wip

* remove add/minus buttons

* add tests

* disable processing of context results in Loki

* moved into table to align properly

* remove imports

* add highlighting of opened logline

* improve scrolling behavior

* correct style for the table

* use correct query direction

* fix text

* use LoadingBar

* use overflow auto

* rename `onToggleContext` to `onOpenContext`

* add missing import

* mock scrollIntoView

* update unused props

* remove unused import

* no need to process context dataframes

* only show `LogRowContextModal` if `getRowContext` is defined

* remove unused param

* use `userEvent` rather `fireEvent`

* change to `TimeZone`

* directly use style classes

* revert change to public_dashboard_service_mock.go

* improved styling

* add missing await in test

* fix lint

* fix lint

* remove LogRow scrolling when context is opened

* remove references to `scrollElement`

* Update public/app/features/logs/components/log-context/LogRowContextModal.tsx

Co-authored-by: Matias Chomicki <matyax@gmail.com>

* fix lint

* add comment explaining `onCloseContext`

* add comment about debounced onClose

* add comments and remove `showRowMenu`

* scroll twice to correctly center the element

* revert double scrolling

* remove unnecessary `processDataFrame`

* trigger drone

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-04-14 17:05:43 +02:00
Ryan McKinley
e65163ba4e FieldValues: Use plain arrays instead of Vector (part 2 of 2) (#66224)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2023-04-14 09:03:45 -05:00
Ryan McKinley
b8188eead4 FieldValues: Use plain arrays instead of Vector (part 1 of 2) (#66187)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-04-14 07:36:53 -05:00
Piotr Jamróz
4f5b80095e Dashboards: Fix broken internal data links (#66567)
* In dashboards splitOpenFn is not passed, instead "href" link is used. When we added tracking we changed the behaviour so onClickFn is always passed when generating the model. To bring back the previous behaviour we skip the onClickFn if the split function is not provided.

* Fix test and add a task to re-check the logic
2023-04-14 14:25:07 +02:00
Ivana Huckova
060728b3d5 Explore: Add tooltip to explain what logs sample is (#66568)
* Explore: Add tooltip to logs sample

* Update tooltip
2023-04-14 13:53:12 +02:00
Josh Hunt
a438576a6d Chore: Use @types/chance types (#66569) 2023-04-14 12:20:25 +01:00
Ivan Ortega Alba
7bc31ab04b Replace the DS drawer toggle with the new DS picker one (#66551) 2023-04-14 13:01:10 +02:00
Giordano Ricci
d84bbfd51b Explore: fix table sizing with few rows (#66546) 2023-04-14 11:47:52 +01:00
Piotr Jamróz
b5e2b0d14c Explore: Allow supplementary query data provider to be undefined for mixed data sources (#66422)
* Switch back to the API where data provider for a supplementary query can be undefined

* Promote exploreMixedDatasource to beta

* Revert "Promote exploreMixedDatasource to beta"

This reverts commit a3bc167d1c.

* Resolve data source in parallel

* Do not modify function params

* Reorganize code for better readability

* Improve readability

* Simplify code

* Stop using a deprecated error property
2023-04-14 11:31:46 +02:00
Ashley Harrison
4abe0249ba Chore: Clean up old navigation (#66287)
* remove code outside of the topnav feature flag

* delete NavBar folder

* remove topnav toggle from backend

* restructure AppChrome folder

* fix utils mock

* fix applinks tests

* remove tests since they're covered in e2e

* fix 1 of the approotpage tests

* Fix another dashboardpage test

* remove reverse portalling + test for plugins using deprecated onNavChanged method

* kick drone

* handle correlations
2023-04-14 09:43:11 +01:00
Marcus Andersson
c3fee5881f E2E: Fixed so openPanelMenuItem flow works with new/old panel chrome without breaking changes (#66118)
Fixed so the openPanelMenuItem works with both angular and react panels.
2023-04-14 09:11:15 +02:00
Alexander Zobnin
7476219b0c SAML: Configuration UI (#64054)
* Add initial authentication config page skeleton

* Add initial SAML config page WIP

* Add few more pages

* Add connect to IdP page

* Assertion mappings page stub and url params

* Able to save settings

* Some tweaks for authentication page

* Tweak behaviour

* Tweak provider name

* Move SAML config pages to enterprise

* minor refactor

* Able to reset settings

* Configure key and cert from UI

* Refactor WIP

* Tweak styles

* Optional save button

* Some tweaks for the page

* Don't show info popup when save settings

* Improve key/cert validation

* Fetch provider status and display on auth page

* Add settings list to the auth page

* Show call to action card if no auth configured

* clean up

* Show authentication page only if SAML available

* Add access control for SSO config page

* Add feature toggle for auth config UI

* Add code owners for auth config page

* Auth config UI disabled by default

* Fix feature toggle check

* Apply suggestions from review

* Refactor: use forms for steps

* Clean up

* Improve authentication page loading

* Fix CTA link

* Minor tweaks

* Fix page route

* Fix formatting

* Fix generated code formatting
2023-04-13 16:07:43 +02:00
Torkel Ödegaard
7d1b61e033 AlertRules: Update design to align it with recent changes to lists and tables (#66461)
* AlertRules: Update design to be less boxy

* tag alignment fix

* Minor tweak
2023-04-13 16:00:03 +02:00
Joey
22fde6a3f2 Tracing: Add links to documentation in config pages (#66442)
Add links to documentation in config pages and clean up styles
2023-04-13 14:56:35 +01:00
Torkel Ödegaard
4796a63554 InteractiveTable: Updated design and minor tweak to Correlactions page (#66443)
* InteractiveTable: Updated design

* Fix css issue

* Fixed test

* Removed leftover
2023-04-13 15:50:49 +02:00
Laura Benz
725f29e6d0 Design System: Set TextArea to display: block in order to remove spacing below (#66262)
refactor: set textarea to display: block and add margin
2023-04-13 14:21:36 +02:00