owensmallwood
5121e32722
When generating the pubdash url, use the base url from the Grafana config. This allows the url generation to work in the case that Grafana is hosted on a subpath. ( #55204 )
...
Support subpaths when generating public dashboard url
2022-09-15 09:46:11 -06:00
Guilherme Caulada
82708df287
PublicDashboards: Add link to public dashboards docs to sharing modal ( #55186 )
2022-09-14 15:05:15 -03:00
juanicabanas
1e06b0170b
PublicDashboards: UI improvements ( #55130 )
...
* Public dashboard modal UI modifications
2022-09-14 14:35:46 -03:00
Ashley Harrison
4c3e08db91
Chore: Convert ShareLink tests to RTL ( #55026 )
...
* Convert ShareLink tests to RTL
* use findByRole instead of findByLabelText to be more robust
2022-09-12 14:34:06 +01:00
Ezequiel Victorero
bcab0194f1
PublicDashboards: disable form if user does not has permissions ( #54853 )
2022-09-07 18:29:01 -03:00
Andrej Kiripolský
59ba64f29b
Dashboard: Fix typos in feedback request sentence ( #54429 )
...
* Fix typo in feedback request
* prettier
Co-authored-by: Domas <domasx2@gmail.com >
2022-09-01 09:29:52 -05:00
Jeff Levin
f5b99e5ca7
add tests for api urls ( #54116 )
...
Create function for generating api urls and add tests
2022-08-24 08:51:35 -06:00
Ashley Harrison
3cf95d7eee
Chore: fix some anys pt.2 ( #53928 )
...
* correctly type some more any's
* undo this change for now...
2022-08-22 16:51:33 +01:00
Joao Silva
a84873a52b
i18n: Translates the Share Panel modal ( #53297 )
2022-08-04 16:43:49 +01:00
Ezequiel Victorero
e0d71f02b1
Public Dashboards: add e2e tests for public dashboards ( #52970 )
2022-08-01 11:20:49 -03:00
Jeff Levin
58ff0f07b4
public dashboards: check to see if dashboard state is different from persisted on save ( #52008 )
...
* public dashboards: check to see if dashboard state is different from persisted on save
Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com >
2022-08-01 09:35:09 -03:00
eledobleefe
42e92665f3
Internationalisation: Translate the Share modal ( #52457 )
2022-07-22 13:01:57 +02:00
Ezequiel Victorero
0633840777
GrafanaUI: Add success state to ClipboardButton ( #52069 )
...
* User Experience: apply the same pattern feedback for all copy to clipboard buttons
* add copy icon to all ClipboardButton use cases
* Change primary color for copy to clipboard in create token
* Add success button variant
* Remove copy confirmation from TableCellInspectModal because it's in the base component now
* Design tweaks to copy confirmation
- Only change the icon to tick to avoid the button changing size
- Change button to success green
- Only show copy confirmation state for 2 seconds
* revert TabelCellInspectModal text button back
* revert accidental change to ShareLink
Co-authored-by: joshhunt <josh@trtr.co >
2022-07-20 10:33:46 +01:00
Ezequiel Victorero
05dd0d7f57
Public Dashboards: add information about how time settings works ( #52152 )
2022-07-13 11:28:55 -03:00
Jeff Levin
fcfde8abd8
public dashboards:fix time regression ( #51998 )
...
This PR fixes a regression bug for public dashboards and adds a test to ensure the regression does not resurface.
2022-07-11 08:50:34 -03:00
Ezequiel Victorero
ba2d8cd838
Public Dashboards: disable saving button instead of hide before accepting checkboxes ( #51744 )
2022-07-06 18:21:00 -03:00
Ezequiel Victorero
10a33be2c2
Public Dashboards: add icon buttons with links to useful information for the user ( #51722 )
2022-07-06 16:34:23 -03:00
Ezequiel Victorero
9f6297ca9b
Public Dashboards: use default dashboard time range instead of current ( #51656 )
2022-07-06 13:37:39 -03:00
Ezequiel Victorero
99f921cf32
Public Dashboards: adding telemetry for Sharing Modal options and Public Dashboards events ( #50834 )
...
* Public Dashboards: adding telemetry for Sharing Modal options and Public Dashboards events
2022-06-27 12:33:30 -03:00
Jeff Levin
d076bedb5e
public dashboards: finalize db schema & v1 feature complete ( #50467 )
...
This PR completes public dashboards v1 functionality and simplifies public dashboard conventions. It exists as a large PR so that we are not making constant changes to the database schema.
models.PublicDashboardConfig model replaced with models.PublicDashboard directly
dashboard_public_config table renamed to dashboard_public
models.Dashboard.IsPublic removed from the dashboard and replaced with models.PublicDashboard.isEnabled
Routing now uses a uuid v4 as an access token for viewing a public dashboard anonymously, PublicDashboard.Uid only used as database identifier
Frontend utilizes uuid for auth'd operations and access token for anonymous access
Default to time range defined on dashboard when viewing public dashboard
Add audit fields to public dashboard
Co-authored-by: Owen Smallwood <owen.smallwood@grafana.com >, Ezequiel Victorero <ezequiel.victorero@grafana.com >, Jesse Weaver <jesse.weaver@grafana.com >
2022-06-22 13:58:52 -08:00
Jeff Levin
52ed651958
public dashboards: insert default public dashboard config into database on save ( #49131 )
...
This PR adds endpoints for saving and retrieving a public dashboard configuration and and api endpoint to retrieve the public dashboard.
All of this is highly experimental and APIs will change. Notably, we will be removing isPublic from the dashboard model and moving it over to the public dashboard table in the next release.
Further context can be found here: https://github.com/grafana/grafana/pull/49131#issuecomment-1145456952
2022-06-02 18:27:23 -08:00
Ashley Harrison
3ace282c29
add tracking for snapshot creation ( #49165 )
2022-05-18 14:53:49 +01:00
Jeff Levin
c7f8c2cc73
add isPublic to dashboard ( #48012 )
...
adds toggle to make a dashboard public
* config struct for public dashboard config
* api endpoints for public dashboard configuration
* ui for toggling public dashboard on and off
* load public dashboard config on share modal
Co-authored-by: Owen Smallwood <owen.smallwood@grafana.com >
Co-authored-by: Torkel Ödegaard <torkel@grafana.com >
2022-05-17 14:11:55 -08:00
Ashley Harrison
06d3c27bc1
Select: Portal menu by default ( #48176 )
...
* Remove menuShouldPortal from all <Select /> components
* fix unit tests
* leave menuShouldPortal as an escape hatch
* Fix import order
2022-05-04 15:12:59 +01:00
Josh Hunt
3c6e0e8ef8
Chore: ESlint import order ( #44959 )
...
* Add and configure eslint-plugin-import
* Fix the lint:ts npm command
* Autofix + prettier all the files
* Manually fix remaining files
* Move jquery code in jest-setup to external file to safely reorder imports
* Resolve issue caused by circular dependencies within Prometheus
* Update .betterer.results
* Fix missing // @ts-ignore
* ignore iconBundle.ts
* Fix missing // @ts-ignore
2022-04-22 14:33:13 +01:00
kay delaney
f1c3177e79
Chore: Add type info for grafana boot data ( #45322 )
...
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com >
2022-03-30 10:48:58 +01:00
Torkel Ödegaard
79e5e5c024
DataSource: Default data source is no longer a persisted state but just the default data source for new panels ( #45132 )
...
* PanelEdit: Change the meaning of default data source to be just that the default for new panels
* Added migration, and also migration for annotation datasource prop to data source refs
* fix
* Fixing tests
* Fixes to annotation
* Fixing unit test
2022-03-08 08:56:12 +01:00
Hugo Häggmark
dbec2b02fd
Variables: move state tree into a keyed state ( #44642 )
...
* Variables: move state tree into a keyed state
* Update public/app/features/variables/state/transactionReducer.ts
Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com >
* Chore: fix prettier error
* Chore: renamed slices and lastUid
* Chore: rename toUidAction
* Chore: rename dashboardVariableReducer
* Chore: rename state prop back to templating
* Chore renames variable.dashboardUid
* Chore: rename toDashboardVariableIdentifier
* Chore: rename getDashboardVariable
* Chore: rename getDashboardVariablesState
* Chore: rename getDashboardVariables
* Chore: some more renames
* Chore: small clean up
* Chore: small rename
* Chore: removes unused function
* Chore: rename VariableModel.stateKey
* Chore: rename KeyedVariableIdentifier.stateKey
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com >
Co-authored-by: kay delaney <kay@grafana.com >
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com >
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com >
2022-02-18 06:06:04 +01:00
Ashley Harrison
0cb3037b55
Panel: Embed URL is now correctly generated for a panel in the home dashboard ( #44706 )
...
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* test tidyup
* Add comment for route
Co-authored-by: kay delaney <kay@grafana.com >
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com >
Co-authored-by: joshhunt <josh@trtr.co >
Co-authored-by: Muaaz Saleem <muaazsaleem@Muaazs-MacBook-Pro.local >
2022-02-02 13:38:23 +00:00
renovate[bot]
d87cd6f26c
Update dependency prettier to v2.5.1 ( #43473 )
...
* Update dependency prettier to v2.5.1
* prettier fixes
* chore(toolkit): bump prettier to 2.5.1
* style(eslint): bump grafana config to 2.5.2 in core and toolkit
* style(mssql-datasource): fix no-inferrable-types eslint errors
Co-authored-by: Renovate Bot <bot@renovateapp.com >
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com >
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com >
2022-02-02 12:02:32 +00:00
Alex Khomenko
55e1c53e36
NavModel: Enable adding suffix elements to tabs ( #44155 )
...
* Trigger extra events
* Extend html attributes
* Add suffix to tabs
* Add upgrade routes
* suffix => highlightText
* suffix => suffixText
* Add size prop
* Update prop name
* Convert tabSuffix to a component
2022-01-26 09:15:45 +02:00
Agnès Toulet
5eaaadd59d
Tabs: add suffix prop for the tab name ( #43869 )
...
* Tabs: add suffix prop for the tab name
* Replace FC with JSX.Element
2022-01-12 15:37:16 +01:00
Josh Hunt
9fc5193ecd
Dashboard: Disable image renderer link for unsaved dashboards ( #41249 )
2021-11-03 12:17:16 +01:00
Hugo Häggmark
09bb890092
WIP Chore: reduce strict errors ( #40462 )
...
* Chore: reduce strict error in ngReact
* Chore: reduce strict errors for ShareModal
* Chore: reduce strict errors in VersioHistory
* Chore: reduce strict error in ExpressionDatasource
* Chore: reduce strict error in DashboardWatcher
* Chore: reduce strict error in PluginPage
* Chore: reduce strict errors for guard
* Chore: update threshold
* Chore: reduce strict errors in Graph
* Chore: reduce threshold
* Apply suggestions from code review
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com >
* Chore: reduce strict errors in TimeSeries
* Chore: reduce threshold
* Chore: reduce strict errors in polyfill
* Chore: reduce threshold
* Chore: update after PR comments
* Update public/app/features/plugins/PluginPage.tsx
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com >
* Update public/app/features/plugins/PluginPage.tsx
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com >
* Chore: changes after PR comments
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com >
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com >
2021-10-15 08:57:55 +02:00
Hugo Häggmark
a981ea22fb
A11y: Fix fastpass issues for share modal ( #40386 )
2021-10-14 07:13:15 +02:00
kay delaney
3c52df960a
A11y/Dashboard: Fix a few more miscellaneous fastpass issues ( #40328 )
...
See #39429
2021-10-12 14:35:48 +01:00
kay delaney
c443f244a0
A11y/Dashboard: Fix misc. fastpass issues ( #40296 )
...
* A11y/Dashboard: Fix misc. fastpass issues
See #39429
2021-10-12 13:26:01 +01:00
Hugo Häggmark
65d79d9a30
Dashboard: Short url generation works for variables values with spaces ( #39552 )
2021-09-23 11:50:09 +02:00
Ashley Harrison
8aa3845f70
Select: Make portalling the menu opt-in, but opt-in *everywhere* ( #37501 )
...
* Select: Don't portal by default
* Select: Portal all the Selects
* Fix indendentation in this comment
* Select: Remove @example docs until formatting is correct
* Docs: Add some documentation for the Select changes
* Update docs/sources/whatsnew/whats-new-in-v8-1.md
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
* Update docs/sources/whatsnew/whats-new-in-v8-1.md
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
* Update packages/grafana-ui/src/components/Select/types.ts
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
* Update public/app/core/components/TransformersUI/configFromQuery/ConfigFromQueryTransformerEditor.tsx
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
* Update public/app/core/components/TransformersUI/configFromQuery/ConfigFromQueryTransformerEditor.tsx
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
* Update public/app/core/components/TransformersUI/configFromQuery/ConfigFromQueryTransformerEditor.tsx
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
* Update public/app/core/components/TransformersUI/prepareTimeSeries/PrepareTimeSeriesEditor.tsx
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
* Docs: Variants instead of varients
* Update public/app/core/components/TransformersUI/configFromQuery/ConfigFromQueryTransformerEditor.tsx
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com >
2021-08-04 15:47:53 +01:00
Torkel Ödegaard
4907d09ffe
Snapshots: Remove dashboard links from snapshots ( #35567 )
2021-06-11 17:42:42 +02:00
ying-jeanne
b391e43472
[Dashboard] Revert feature toggle trimdefaults ( #34888 )
...
* Revert "solve comments and retrigger the test"
This reverts commit f08d2d9ecacc09ceb85346fe8ed5963b3ceee16e3b7f3b8e15b9c62608768e4c4d7c93d01cfcc2edmarcus.efraimsson@gmail.com >
* Update docs/sources/dashboards/export-import.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com >
* fix comments
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com >
2021-05-28 22:29:30 +02:00
ying-jeanne
c59a2e1bcf
remove feature toggle + add libraryPaneldefinition ( #34488 )
...
* remove feature toggle + add libraryPaneldefinition
* update doc
* update comments
* Apply suggestions from code review
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com >
* fix typo
* remove post trim
* update api doc
* solve comments and retrigger the test
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com >
2021-05-27 11:14:58 +02:00
Marcus Andersson
545d930a13
Dashboard: prevent error when sharing a dashboard. ( #33680 )
2021-05-05 10:36:42 +02:00
kay delaney
2cc66e548a
Library panels: Normalize feature name as "Library panels" ( #33540 )
2021-05-04 09:00:44 +01:00
ying-jeanne
22b2d3c38a
frontend for trim/apply defaults and some bug fixing ( #33561 )
...
* remove empty object and workaround on list
* frontend
* add toggle on frontend
2021-05-04 15:03:42 +08:00
Hugo Häggmark
22ac0fc3cd
Chore: Migrates remaining Angular modals to React ( #33476 )
...
* HelpModal: Migrates to new style
* Alerting: Migrates how to do alerting modal to React
* ApiKeysModal: migrates to new theme
* Dashboard: View dasboard json modal migrated to React and new theme
* PluginPage: migrates update plugin modal to react and new theme
* Chore: deprecates events and functions
* Simplify help modal
* Updated json modal to use Modal.ButtonRow
* Tweak to api key design
* Tests: updates snapshot
Co-authored-by: Torkel Ödegaard <torkel@grafana.com >
2021-04-28 15:22:28 +02:00
Torkel Ödegaard
eef4e18b62
Theme: Use outline buttons for Cancel & Back actions ( #33418 )
...
* Buttons: Use new outline button for cancel & back buttons
* More buttons
* More tweaks
* Updated row snapshot
2021-04-27 15:36:48 +02:00
Jack Westbrook
45fa5fdf48
Buttons: introduce buttonStyle prop ( #33384 )
...
* Wip
* Updates to colors to make secondary outline work
* refactor: prefer buttonStyle="text" over variant="link" for text buttons
* revert(button): put back mdx story page
* fix(button): variant link disabled as text disabled
* docs(button): remove link variant from stories
* feat(grafana-ui): introduce basic deprecation notice for button and linkbutton components
* docs(button): update usage of href with button and buttonlink
* feat(button): add grafana/ui to deprecation warning
* refactor(buttons): use a more descriptive name for prop warning function
* test(buttonrow): update snapshots
* refactor(buttons): change prop name from buttonStyle to fill
Co-authored-by: Torkel Ödegaard <torkel@grafana.com >
2021-04-27 12:03:06 +02:00
Torkel Ödegaard
4643bfa539
Modals: design update ( #33368 )
...
* Modals: Style update draft
* Modal.ButtonRow to control spacing better in a centralised way
* Remove header border if no tabs
* Added border and made buttons right aligned and changed order of buttons
* Updating the overlay
* Tweaks to paddings
* Updated share modals
2021-04-26 18:26:56 +02:00
Torkel Ödegaard
cf2d557974
Alerts/InfoBox: Replaces all uses of InfoBox & FeatureInfoBox with Alert ( #33352 )
...
* Alerts/InfoBox: Replaces all uses of InfoBox & FeatureInfoBox with Alert
* Fixes some more stuff
* fixed border radius
2021-04-26 07:18:46 +02:00
